Skip to content

Run make verify on every pull request and in the merge queue - #2

Merged
don-petry merged 1 commit into
mainfrom
ci/factory-verify
Oct 11, 2026
Merged

don-petry merged 1 commit into
mainfrom
ci/factory-verify

Conversation

@don-petry

@don-petry don-petry commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

What this is

The repo's one required check: workflow factory, job verify. It runs make verify, then python3 -m tools.mutants, on the commit and nothing else.

Property How
Runs on every pull request and in the merge queue pull_request and merge_group, no path filter, so a required check on it always reports
Runner pinned by version ubuntu-24.04
Action pinned by commit actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1, which the GitHub API returns as the commit of release v7.0.1. Looked up, not guessed
Least privilege Workflow permissions: {}; the job holds contents: read; persist-credentials: false
Bounded timeout-minutes: 15
Nothing installed The runner's own python3; the repo uses the standard library only

The file is, word for word, examples/workflows/verify.yml from the local branch slice-0/context-engineering, so that branch's workflow standard and its example agree with the real file when it lands.

Verification

This pull request is the workflow's first run: the check on it is the evidence. Locally, make verify and python3 -m tools.mutants pass on this branch (19 of 19 mutants killed).

What follows, and is not in this change

  • The ruleset on main (this check required, the merge queue, no direct pushes, no required approving review yet) is applied after this merges, once the check name GitHub reports has been read from this run.
  • Known for the branch slice-0/context-engineering: once .github/workflows/ exists, its tools/check_context.py asks three decision records (0001 boundary 5, 0005 boundary 4, 0008 boundary 7) to name the check that holds them. That is the check working as written; the records are updated on that branch.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

The workflow `factory`, job `verify`: what `make verify` runs, then the
mutation check, on the commit and nothing else. It runs on pull_request and
merge_group with no path filter, so a required check on it always reports.

The runner image is pinned by version. The one action is pinned by commit:
actions/checkout at 3d3c42e, which the GitHub API gives as release v7.0.1.
The job holds contents: read and leaves no credential on disk.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@coderabbitai

coderabbitai Bot commented Oct 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 28 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 7801cf5e-111c-43a9-a2dc-8ed891af0aeb

📥 Commits

Reviewing files that changed from the base of the PR and between c115149 and 9a78b63.


📒 Files selected for processing (1)
  • .github/workflows/verify.yml

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codeant-ai

codeant-ai Bot commented Oct 11, 2026

Copy link
Copy Markdown

CodeAnt Nitpicks

1 code suggestion

1. make verify is documented as running everything required, but this separate mutation step can fail after it passes, so the documented local check misses CI failures.

Api mismatch · .github/workflows/verify.yml:19

@codeant-ai

codeant-ai Bot commented Oct 11, 2026

Copy link
Copy Markdown

CodeAnt PR Risk: Low Risk

  • The PR appears safe to merge; it adds a narrowly scoped verification workflow with read-only repository access.

Assessed commit: 9a78b63bb496

@don-petry
don-petry merged commit 27aa091 into main Oct 11, 2026
4 checks passed
@don-petry
don-petry deleted the ci/factory-verify branch October 20, 2026 17:21
This was referenced Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant