Repository navigation
The approving act finds its Decision by the run-name's Intent, and its token may read a compare of two commits (#688's fourth dry run) - #720
Conversation
…s token may read a compare of two commits (#688's fourth dry run) Dry run 4 on #688 reached converged/approval_due, and both approve.yml runs ended superseded/not_the_decision. harness/read.py's `decided` compared the run-name's Intent, `issue-approval`, with the Decision's action, `issue_approval`, so every approving Run was read as an admission. It now compares with kernel.terms.ISSUE_APPROVAL. Walking approve.job's whole path on #688's live shape found the next stop: the approver's transport refused any path holding two dots, and the facts snapshot reads its diff, its files and a review's content by `compare/{base}...{head}`. `Approving` now lets two dots through in a compare of two full commit ids of the item's repo, and in nothing else. Tests: the step run through the real approve.job on a pass record that holds an admission and the act, with each part of the run-name moved in turn; the snapshot read whole through `Approving`; the compare's boundary cases. Mutants for each. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…its end; an act that names no content is no run-name's The security pass and Muse on 7a2a103. - tools/mutants.py: "the approver's reads may climb out of the repo" named text the file no longer holds, so it was stale. It names the guard as it now reads. - harness/read.py: an act issuing the approval with no content_id, which the schema allows, raised in place of stopping `not_the_decision`. It is read with `.get`. - The reader's stop on an approving run-name is live for the first time, and had no test and no mutant. It has both. - adapters/effects.py: the compare is held as its one whole match. tests/test_approve.py refuses the head's short and capital forms, two dots and another character, and a line's end, each with a mutant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…e the approver reads Astra on 923ca07: loosening either commit's clause of the compare to any forty lowercase letters and digits survived, so a name that could be a branch's was not held out by a test. tests/test_approve.py refuses one on each side, each with its mutant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
No file of this change conflicts; main's new mutants sit beside issue 552's. Co-Authored-By: Claude <noreply@anthropic.com>



Slice 1's fourth dry run, on "AGENTS.md: say what is built; drop the model claim no check holds" (#688) at v0.1.4, reached
converged/approval_duefor the first time (pass 42869707264). Both approving Runs then endedsuperseded/not_the_decision(approve.yml 42870315808 and 42870857986). The Factory Builder asked for the fix, for a walk of the approving act's whole path on the live record's shape, and for anything else that walk found in the same pull request. It opens labelledfactory:hands-off. No record: no rule changes.What
harness/read.pydecidedcompared the run-name's Intent,issue-approval, withapprove.APPROVAL, the Decision's actionissue_approval. Every approving Run was read as an admission, found none, and stopped. It now compares withkernel.terms.ISSUE_APPROVAL. The defect is as old as the approving act (#334); the approval branch ofdecidedhad no test and no mutantadapters/effects.pyApproving._readrefused any path holding two dots. The facts snapshot reads its diff, its files and a review's content byGET /repos/{repo}/compare/{base}...{head}, so the act's read again would have endedenvironment/snapshot_diff_unreadableon every Run. Two dots are now let through when the whole path is a compare of two full commit ids in the item's repo, and in nothing else. Decision 0055's rule stands as written: the token reads the item's repo, and no path climbs outtests/test_steps.pyapprove.jobon a pass record that holds an admission and the act, by the name the pass dispatched, to the one write. Then each part of the run-name is moved in turn (Run id, content, Role, item, Intent): each finds no Decision and writes nothing. So does an act that names no content. The run step's reader, given the approving run-name, builds no Task:not_the_decisiontests/test_adapters.pyApproving, from the canary's recorded sequence, and equals the plain readtests/test_approve.pytools/mutants.pyThe walk
A desk script wrapped a read-only
gh apitransport ineffects.Approvingfor #688 and ranharness/reread.py'sitem, the schema checks,effects.approval_ofanddecide/still_wanted, asapprove.jobdoes. With the fix: 52 requests, none refused byApproving, every one answered 200; the facts passfacts/1; the content is the one decided; no approval is recovered; and on the pass's facts the Kernel still wants the approval. On the facts read now it holds,hands_off, since #688 was labelled again at 18:02Z.Not verified, and not mine to verify: the walk ran on the Maintainer's
ghlogin, not the machine user's token. The live Runs proved that token reads the runs and artifacts. Its reads of the Pause variables (actions_variables: read), and its one write (pull_requests: write), are untried.About the stop code:
approve_stepalready prints it, throughharness/steps.run, as every step does (not_the_decision, in the job's log at 17:58:21Z). Only GitHub's annotation shows the exit code alone. Nothing is changed there.Verification
make checks: ok.tests.test_approve,tests.test_steps,tests.test_adapters,tests.test_token_needs,tests.test_effects,tests.test_harness: ok, 278 tests.not_the_decision, the snapshot withUnansweredatpull.diff.923ca07, all ofharness/read.py's and of the approver's transport's; the compare's 12 of 12 again at0070092. None stale.verifyis the answer, per the Maintainer's standing change of 2026-11-09.7a2a1037a2a1037a2a103923ca077a2a103content_id, which the schema allows, raised indecidedin place of stopping.get, with its case and mutantapply_stepnow gets the act for an approving run-name;apply.admittedstill refuses it,no_decisionSHA.matchwith$inadapters/pull.pyandadapters/timeline.pytakes a trailing newlineApprovingrefuses such a compare hereadapters/candidate.py's compare carries?per_page=1, whichApprovingrefusespasses.findandreread.item; only the facts snapshot runs through a realApprovingreread.itemthroughApproving, 52 requests, none refused; the reviewer traced the rest by hand and found none refused🤖 Generated with Claude Code