Skip to content

AGENTS.md: say what is built; drop the model claim no check holds - #688

Merged
don-petry merged 2 commits into
mainfrom
claude/agents-md-what-is-built
Nov 11, 2026
Merged

don-petry merged 2 commits into
mainfrom
claude/agents-md-what-is-built

Conversation

@don-petry

@don-petry don-petry commented Nov 9, 2026 •

Copy link
Copy Markdown
Contributor

The dry run of "Epic: slice 1, first approval. A Release on next reviews a pull request to this repo, and the machine user's approval stands" (#182), under ruling 1 of "The ruleset switch: main requires the machine user's approval of the most recent commit, and slice 1's event is recorded" (#198). This is one small, genuine pull request, for a Release on next to review and approve before any approval is required. The Factory Builder approved this change on 2026-11-09, as the Maintainer's scoping ruled. It opens labelled factory:hands-off, like every open pull request here. The Maintainer takes that label off this one alone when he unpauses.

What

The root AGENTS.md said two things that stopped being true.

Line Was Now
4 "the first of the ports … nothing talks to a model yet" Names what is built: the Lifecycle, the Controller, the Harness, the evals, the workflows, the Release's rules, the Role pr-review and the ports built so far. "Only adapters/github.py talks to GitHub" stays, since tools/check_repo.py holds it
60 "Not built yet … roles, evals and the workflows" "every Role but pr-review"; the four directories' AGENTS.md still name their parts to come

Line 4 no longer says anything about which module talks to a model. A rule no check holds does not belong in this file, and tools/ scripts call the CLI at the Maintainer's terminal.

AGENTS.md alone changes, still at 60 lines. It is on neither the protected nor the reported list of config/hooks.json, and no review Role reads it as an input.

Verification

CI's verify passes at the head, 2a60aef6 (the same two commits rebased on main 7ff090d, the v0.1.1 commit). Export verify passed at 90fc0360, before the rebase. make checks: ok.

Reviewer Head Unread parts Blocking Major Minor Info
agy a399b90 none 0 0 0 0
muse a399b90 none 0 0 0 0
claude-review a399b90 none 0 1 1 0
claude-security a399b90 none 0 0 1 0
claude-review 90fc036 (rebased as 2a60aef) none 0 0 0 0
claude-security 90fc036 (rebased as 2a60aef) none 0 0 0 0
Finding Severity Criterion Where What Disposition
claude-review#1 major PR-5 AGENTS.md:4 "Only harness/engine.py talks to a model" is held by no check, and tools/ scripts and harness/run.py start the CLI fixed in 90fc036: the sentence is dropped
claude-review#2 minor none AGENTS.md:4 The built list left out evals and the workflows, and said "the ports" while some are still to come fixed in 90fc036
claude-security#1 minor PR-5 AGENTS.md:4 The same model sentence states a trust boundary that no check holds at the module level fixed in 90fc036: the sentence is dropped

🤖 Generated with Claude Code

don-petry and others added 2 commits November 9, 2026 14:55
…s to a model

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Claude review and the security pass of a399b90: 'only harness/engine.py talks to a model' read as a rule no check holds, and tools/ scripts call the CLI. Evals, the workflows and the Lifecycle are named as built.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 9, 2026 20:56
@don-petry don-petry added the factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) label Nov 9, 2026
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-09T20:56:48.766098Z
We couldn’t complete this review. Comment @codex review to try again.
2a60aef PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@sonarqubecloud

sonarqubecloud Bot commented Nov 9, 2026

Copy link
Copy Markdown

@don-petry don-petry added factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) and removed factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) labels Nov 9, 2026
@don-petry don-petry added factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) and removed factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) labels Nov 10, 2026
@don-petry don-petry added factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) and removed factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) labels Nov 10, 2026
@don-petry don-petry removed the factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) label Nov 10, 2026

@combsmith-sf-pr-review combsmith-sf-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings: the AGENTS.md status lines match the directories the head holds.

@don-petry don-petry added the factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) label Nov 10, 2026
@don-petry don-petry added factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) and removed factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) labels Nov 10, 2026
don-petry added a commit that referenced this pull request Nov 10, 2026
…t a refused read alone (record 0187)

Dry runs 5 and 6 of #688 both ended facts_unreadable in the approving act, the sixth after the machine user's token was
widened, so a fault of the read's own code is now the likeliest stop. The act records every fault of the read again,
and a stage told only a read GitHub did not answer, so such a fault kept the one code. A stage and a snapshot's part
now tell any fault; the read again names the context's building as a stage; the snapshot names the facts' putting
together as a part; and a context that is none is the context's. Record 0187 amends 0179.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry don-petry added factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) and removed factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) labels Nov 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants