Skip to content

The approving act names a Pause the port could not read by the port's part (#688's dry runs 5 to 7, record 0192) - #731

Merged
don-petry merged 5 commits into
mainfrom
claude/approve-names-the-pause
Nov 11, 2026
Merged

don-petry merged 5 commits into
mainfrom
claude/approve-names-the-pause

Conversation

@don-petry

@don-petry don-petry commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

This is the second half of #728, "A Pause the port could not read is named by which read it was and why", split in two to stay under the Factory's review budget. The first half, #729, gave the Pause's port its parts and merged as be4992d. This half makes the approving act name them, and carries the decision record. It is hardening, not a fix.

Why

Slice 1's dry runs 5, 6 and 7 on "AGENTS.md: say what is built; drop the model claim no check holds" (#688) each stopped in the approving act, at facts_unreadable twice and then at pause_unreadable: the Pause, and not which of its two reads, or how. The cause was the machine user's token, whose Variables grant was waiting for the org's approval. A code that said "GitHub refused the list of the org's variables" would have pointed at the grant at dry run 5.

What this half changes

  • harness/reread.py: item takes name_pause. Asked, it reads the Pause through the port's explained and raises a Pause the port could not read as a read of the pause stage, its part the first unreadable scope's, the org's before the repo's. It raises after the run records are found unread, and never while a scope pauses.
  • harness/approve_step.py asks by name, so the act records pause_<part>_unreadable through unread in harness/shared.py, as it records a snapshot's part: pause_org_refused_unreadable, pause_org_unnamed_unreadable, pause_repo_refused_unreadable, pause_org_unreadable or pause_repo_unreadable.
  • Record 0192 amends 0179's row "The parts" and 0187's row "A part not as its schema holds it", for the Pause. Its boundary rows name the first half's test and mutants as well as this half's.

What does not change

  • The Controller: read hands back what it did, so pause_unreadable is still its one code.
  • Apply: it does not ask by name, and names its Pause in its own order.
  • The outcome's kind: only the approving act's reason is finer, so no Decision moves.
  • In the approving act, pause_unreadable is left for a Pause the port read whose value is no Pause, and for a fault of the read's own code.

One order does change, and the record says so: a Pause the port could not read is now raised by the read again, so the act names it before it holds the run records and the snapshot to their schemas, as it does any read that raised.

Checks it adds

  • tests/test_steps.py::test_the_item_is_read_again: asked by name, each part is raised at the pause stage; not asked, nothing is raised; a scope that pauses, a value that is no Pause and a Pause read clear raise nothing; unread run records are named first.
  • tests/test_steps.py::test_the_approver_holds_to_its_item and ::test_an_approving_run_finds_its_act_by_its_run_name_and_approves: the step asks by name, and ends pause_org_refused_unreadable on a refused list.
  • tests/test_steps.py::test_apply_reads_with_reads: apply asks for no part.
  • tests/test_approve.py::test_each_fault_of_the_act_is_classed_as_the_design_classes_it: the five codes.
  • Twelve new mutants, each killed by a test its record row names, and one older mutant of harness/reread.py reworded to the text as it now stands.

Checks

Check Result
make checks OK
tests.test_effects, test_steps, test_approve, test_controller, test_apply, test_token_needs OK, 165 tests
Mutants of adapters/pause.py and the five touched files under harness/, run alone on an export 146 of 146 killed, at 554f3e6; the head, 1f63a2e, differs from it in one sentence of the record
Diff 31,948 characters and 362 lines, under the Factory's review budget
Full make verify Not run locally, by the Maintainer's standing change of 2026-11-09; CI's verify is the answer

Reviews

The five readers read this code on #728. This half's files are #728's at ff8e4f4 but for the record's number, 0192 where it was 0191, and one sentence of its Status, which a review comment on this pull request had put the title before the number in. So no reader read again.

Reviewer Head on #728 Unread parts Blocking Major Minor Info
agy (Carbon) ec6c7a5 none 0 4 2 0
muse aa0e10d none 1 1 0 0
astra dd12cb2 none 0 0 0 0
claude-review aa0e10d none 0 0 2 1
claude-security aa0e10d none 0 0 0 0

Every finding and its disposition is in #728's description. Those that touched this half: the placeholder number (Muse, Carbon), now 0192 by the Factory Builder's ruling that numbers go in order of readiness; unread's docstring (the Claude review); a mutant for the read again's own call of the port (Carbon); and Carbon's minor asking for a mutant of harness/approve.py, which is no change, since only its docstring changed and the code is formed by unread.

🤖 Generated with Claude Code

don-petry and others added 4 commits November 10, 2026 21:09
…#688's dry runs 5 to 7, first of two)

explained in adapters/pause.py hands back the same read as read, and beside it a code for each scope unreadable:
org_refused, org_unnamed, repo_refused, and org or repo for anything else. A rate limit's 403 is no refusal. read is
explained's first part, so the Controller reads the Pause as it did, and nothing calls explained yet: the approving
act's use of it is the second pull request, which carries record 0191.

This is the first half of pull request 728, split to stay under the Factory's review budget.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… part (#688's dry runs 5 to 7, record 0191)

The read again takes name_pause: asked, it raises a Pause the port could not read as a read of the pause stage, its
part the first unreadable scope's. The approve step asks by name, so the act records pause_<part>_unreadable. Apply
does not ask, and the Controller reads the Pause as it did.

This is the second half of pull request 728, split to stay under the Factory's review budget. The first half gave
the port's parts.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ry Builder's ruling)

The rulesets record of the switch is ready first and takes 0191.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…the-pause

# Conflicts:
#	adapters/pause.py
#	tools/mutants.py
@don-petry
don-petry requested a review from a team as a code owner November 11, 2026 03:59
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Pre-merge checks: Passed 1 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Passed Passed checks: 1 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codeant-ai

codeant-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #38a25 Reviewed your PR 554f3e6 Nov 11, 2026 · 03:59 04:03

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-11T03:59:38.819548Z
We couldn’t complete this review. Comment @codex review to try again.
554f3e6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codeant-ai

codeant-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@codeant-ai codeant-ai Bot added the size:L This PR changes 100-499 lines, ignoring generated files label Nov 11, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

@codeant-ai

codeant-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: 554f3e6a4c14

A review comment: the Status gave the number before the title, where docs/AGENTS.md asks for the title first.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants