Skip to content

The Maintainer's continue or stop is recorded in a file, and a decision counts only in his name (#198's ruling 7, record 0194) - #739

Merged
don-petry merged 8 commits into
mainfrom
claude/decision-points
Nov 11, 2026
Merged

don-petry merged 8 commits into
mainfrom
claude/decision-points

Conversation

@don-petry

@don-petry don-petry commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

User description

This records the design's first decision point as a file, with what the Maintainer is shown before he decides. It is working ruling 7 on "The ruleset switch: main requires the machine user's approval of the most recent commit, and slice 1's event is recorded" (#198). Part of #198; it does not close it.

Model-Lens inputs touched: none. config/hooks.json is read, not changed.

Size. 48,096 characters and 725 lines by git diff; 52,705 characters as the Kernel counts a diff, with its lines numbered, against a budget of 60,000. Ruling 5's part, the skill's "When the Factory cannot approve", was split off to keep this under it and follows as its own pull request with a record of its own.

What changes

  • release/decision-points.json, of the new schema decision-points/1: one entry, first_release_on_next. Its Release is factory/v0.1.6, the one that reviewed slice 1's event. decided, day and by are null: they are the Maintainer's to write.

    Shown to him Figure
    Pull requests merged into main before the event merged, 2026-11-11T03:57:41Z 387
    Of them, his own 387
    Of them, changed a protected path of config/hooks.json 165
    The design's starting figure 40
  • tools/check_release.py holds what the schema cannot say:

    • a point is recorded once;
    • decided, day and by are written together or not at all;
    • a decision counts only where by is the login config/hooks.json names the Maintainer by, in any case; where that file names nobody, nobody's counts;
    • the decision's day is the day the counts were read, or later;
    • the counts are read on the event's day or after;
    • each day written is a day of the calendar;
    • no share is greater than the count it is of.
  • tools/check_examples.py holds the file to its schema, and sends a counter-example the schema takes to that rule.

  • Two counter-examples: a decision in another login's name, and a point with no count.

  • Record 0194 says the form, who decides, and what is not held.

What is not held, and the record says so

  • Whose hand wrote a decision. The check holds the name written. Every commit names the Maintainer, so nothing in the repo tells his edit from a session's, and the file is not a path a person must approve. Four readers raised this. Making it one is a change to config/hooks.json, a model Lens's input, so it is not in this pull request; it is put to the Factory Builder as its own small one.
  • The counts. They were read once and no check reads them again, since verify reads the commit alone:
    • GitHub's search, through the Maintainer's login: is:pr is:merged base:main merged:<2026-11-11T03:57:41Z gives 387, and 387 with author:don-petry.
    • The repo's history: 390 commits on main's first-parent line before the event's, 387 of them a pull request's squash and three the first commits. 165 of the 387 change a path the protected list of config/hooks.json names, as it stood at 687db79.

What it does not do

  • It does not decide. decided is null until the Maintainer writes it.
  • It adds no row to release/AGENTS.md, which is at its 40-line limit. The record's boundaries carry the rules.
  • A count beyond the figure stops nothing, by the design.

Checks

Check Result
make checks OK
tests.test_release, tests.test_evals OK, 114 tests
tests.test_tools, the tests of schemas, examples, envelopes, skills and decisions OK, 28 tests, at the first head
Mutants of the seven touched files, run alone on an export 102 of 102 killed, at 5b9d98e
Full make verify Not run locally, by the Maintainer's standing change of 2026-11-09; CI's verify is the answer
Reviewer Head Unread parts Blocking Major Minor Info
agy (Carbon) 1bf54b3 none of 8 0 7 6 0
muse 1bf54b3 none 1 1 0 0
claude-review 1bf54b3 none 0 0 3 1
claude-security 1bf54b3 none 0 1 0 0
astra 5f50124 none 0 2 0 0

The four first readers read 1bf54b3, which still held the skill's part. Astra read 5f50124, after their findings were fixed and the skill's part had left. The head adds Astra's two fixes, names four test tuples once in tools/mutants.py, and mends one finding of a review thread: two points that name none are no longer read as one recorded twice (5b9d98e). After that it merges main and renumbers the record from 0193 to 0194 (880c1b1), since "A run record says when its Run began, read from its jobs under P-64's rule (#724, record 0193)" (#751) merged first; nothing decided changes. By the lane's rule a gap in a test needs no read again, so no reader read again.

Finding What Disposition
muse #1 The record, then numbered 0193, left a gap: 0192 was not on main fixed by the merge of #731, which main now holds
security #1, muse #2, claude-review #2, agy #1 "Only the Maintainer writes it" is held as a string any session can type fixed in the record: "Who decides" and the boundary say what the check holds, the name; "What is not held" says the hand is not. Protecting the path is put to the Factory Builder
claude-review #1, agy #8 The hand approval is allowed only when no Release can serve, though a change the Factory may not approve also needs it moved with the skill's part to the next pull request, which adds that case
claude-review #3, agy #5 Type guards of the rule survive removal fixed: each odd part alone, and a mutant for each guard
claude-review #4 "A Pause stops the Factory's writes" moved with the skill's part, and reworded there to the design's I-7
agy #2 The schema lets one of the three be written without the others the check refuses it, as it did; the schema's title now says the check holds it
agy #9 The counts' day is not held to the event's fixed: a rule, its boundary and four mutants
agy #10 Days are not said to be UTC fixed in the schema and the record
agy #3 No Maintainer login in another case is tried fixed, with a mutant
agy #4 Two points of two names are never shown to pass fixed, with a mutant
agy #11 A half-written decision never names another fixed
agy #12 The no-count example is not held to the live shares fixed
agy #6, #7, #13 The skill's test: the machine user, other code blocks, other steps moved with the skill's part, and fixed there
astra #1 A 31st of November passes as a day fixed: each day is held to the calendar, with four mutants
astra #2 Nothing takes a stop through the schema fixed: both decisions through the schema and the check, with three mutants

🤖 Generated with Claude Code


CodeAnt-AI Description

Record and validate the Maintainer’s first release decision

What Changed

  • Records the first release decision point with the context shown to the Maintainer: 387 merged pull requests, all 387 authored by him, 165 touching protected paths, compared with the design’s starting figure of 40. The decision fields remain empty until he records a choice.
  • Accepts a decision only when all decision fields are completed together and the recorded login matches the Maintainer named in the hooks configuration.
  • Rejects duplicate decision points, invalid dates, counts read before the event, decisions made before the counts were read, and shares larger than the total.

Impact

✅ First release decision has its counts and context in one record
✅ Partial or non-Maintainer decisions are rejected
✅ Decision dates cannot predate the counts shown

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

don-petry and others added 5 commits November 11, 2026 06:49
… skill says what to do when the Factory cannot approve (#198's rulings 5 and 7, record 0193)

release/decision-points.json, of schema decision-points/1, records the design's first
decision point: the Release that reviewed slice 1's event, and what the Maintainer is
shown before he decides. 387 pull requests merged into main before the event, all of
them his, and 165 of them changed a protected path, against the design's figure of 40.
decided, day and by are left null: they are his to write.

tools/check_release.py holds what the schema cannot: a point is recorded once; what he
writes is written whole or not at all, by the login config/hooks.json names him by, on
or after the day the counts were read; and no share is greater than the count it is of.
Two counter-examples, four tests and 29 mutants hold it.

The cut-a-release skill gains "When the Factory cannot approve": the Pause, then a
rollback of next, and only when no Release can serve, the Maintainer's approval by hand
as the machine user. A session stops before it and approves nothing.

Record 0193 says both, and what is not held: the counts are read once, and nothing yet
raises a hand approval.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…uest

The record no longer says the check holds whose hand wrote a decision: it holds the name
written, and "What is not held" says a session leaves the three fields empty by that row
alone. The counts are now read on the event's day or after, a day being a day in UTC.
Each guard of the rule is held alone by an input and a mutant; a login is matched in any
case on both sides; two points of two names are two points.

The skill's "When the Factory cannot approve", its test and its mutants leave this branch
for a pull request of their own, with their own record, so this one stays under the
review budget and names one decision.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… continue or stop and nothing else

Astra's two findings. The schema's pattern lets a 31st of November through, so the check
holds each day written, the read's, the event's and the decision's, to the calendar. The
test now takes both decisions through the schema and the check, and three mutants of the
schema's enum are killed by it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 11, 2026 13:56
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Pre-merge checks: Passed 1 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Passed Passed checks: 1 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-11T13:56:35.828285Z
We couldn’t complete this review. Comment @codex review to try again.
a91d964 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@codeant-ai

codeant-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #bc17a Incremental review completed 880c1b1 Nov 11, 2026 · 22:36 22:36
✅  #2d64e Reviewed your PR a91d964 Nov 11, 2026 · 13:57 14:02

@codeant-ai

codeant-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:XL This PR changes 500-999 lines, ignoring generated files label Nov 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements decision point recording and validation (decision 0193), where the Maintainer's continue or stop decisions are tracked in a JSON file. It introduces a JSON schema, example invalid files, validation logic in tools/check_release.py, and comprehensive unit tests in tests/test_release.py. A review comment suggests improving the duplicate check in point_problems to avoid false duplicate errors when multiple points are missing the point key.

Comment thread tools/check_release.py Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread tools/check_release.py Resolved
Comment thread schemas/decision-points.schema.json Resolved
@codeant-ai

codeant-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: 880c1b1324f4

A review thread's finding: a point with no `point` was kept as None and the next such
point read as a duplicate of it. Only a name is held to once; what names none is the
schema's to refuse.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
don-petry and others added 2 commits November 11, 2026 16:35
Renumbered on the Factory Builder's word, after "A run record says when its Run began,
read from its jobs under P-64's rule (#724, record 0193)" merged first. The file, its
title and the three lines that name it; nothing decided changes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry don-petry changed the title The Maintainer's continue or stop is recorded in a file, and a decision counts only in his name (#198's ruling 7, record 0193) The Maintainer's continue or stop is recorded in a file, and a decision counts only in his name (#198's ruling 7, record 0194) Nov 11, 2026
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 8d9ee9e Nov 11, 2026
33 checks passed
@don-petry
don-petry deleted the claude/decision-points branch November 11, 2026 23:14
don-petry added a commit that referenced this pull request Nov 11, 2026
#739's 0194

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants