Repository navigation
The Maintainer's continue or stop is recorded in a file, and a decision counts only in his name (#198's ruling 7, record 0194) - #739
Conversation
… skill says what to do when the Factory cannot approve (#198's rulings 5 and 7, record 0193) release/decision-points.json, of schema decision-points/1, records the design's first decision point: the Release that reviewed slice 1's event, and what the Maintainer is shown before he decides. 387 pull requests merged into main before the event, all of them his, and 165 of them changed a protected path, against the design's figure of 40. decided, day and by are left null: they are his to write. tools/check_release.py holds what the schema cannot: a point is recorded once; what he writes is written whole or not at all, by the login config/hooks.json names him by, on or after the day the counts were read; and no share is greater than the count it is of. Two counter-examples, four tests and 29 mutants hold it. The cut-a-release skill gains "When the Factory cannot approve": the Pause, then a rollback of next, and only when no Release can serve, the Maintainer's approval by hand as the machine user. A session stops before it and approves nothing. Record 0193 says both, and what is not held: the counts are read once, and nothing yet raises a hand approval. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…uest The record no longer says the check holds whose hand wrote a decision: it holds the name written, and "What is not held" says a session leaves the three fields empty by that row alone. The counts are now read on the event's day or after, a day being a day in UTC. Each guard of the rule is held alone by an input and a mutant; a login is matched in any case on both sides; two points of two names are two points. The skill's "When the Factory cannot approve", its test and its mutants leave this branch for a pull request of their own, with their own record, so this one stays under the review budget and names one decision. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… continue or stop and nothing else Astra's two findings. The schema's pattern lets a 31st of November through, so the check holds each day written, the read's, the event's and the decision's, to the calendar. The test now takes both decisions through the schema and the check, and three mutants of the schema's enum are killed by it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pre-merge checks:
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
Code Review
This pull request implements decision point recording and validation (decision 0193), where the Maintainer's continue or stop decisions are tracked in a JSON file. It introduces a JSON schema, example invalid files, validation logic in tools/check_release.py, and comprehensive unit tests in tests/test_release.py. A review comment suggests improving the duplicate check in point_problems to avoid false duplicate errors when multiple points are missing the point key.
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
A review thread's finding: a point with no `point` was kept as None and the next such point read as a duplicate of it. Only a name is held to once; what names none is the schema's to refuse. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Renumbered on the Factory Builder's word, after "A run record says when its Run began, read from its jobs under P-64's rule (#724, record 0193)" merged first. The file, its title and the three lines that name it; nothing decided changes. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
#739's 0194 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>



User description
This records the design's first decision point as a file, with what the Maintainer is shown before he decides. It is working ruling 7 on "The ruleset switch: main requires the machine user's approval of the most recent commit, and slice 1's event is recorded" (#198). Part of #198; it does not close it.
Model-Lens inputs touched: none.
config/hooks.jsonis read, not changed.Size. 48,096 characters and 725 lines by
git diff; 52,705 characters as the Kernel counts a diff, with its lines numbered, against a budget of 60,000. Ruling 5's part, the skill's "When the Factory cannot approve", was split off to keep this under it and follows as its own pull request with a record of its own.What changes
release/decision-points.json, of the new schemadecision-points/1: one entry,first_release_on_next. Its Release is factory/v0.1.6, the one that reviewed slice 1's event.decided,dayandbyare null: they are the Maintainer's to write.mainbefore the event merged, 2026-11-11T03:57:41Zconfig/hooks.jsontools/check_release.pyholds what the schema cannot say:decided,dayandbyare written together or not at all;byis the loginconfig/hooks.jsonnames the Maintainer by, in any case; where that file names nobody, nobody's counts;tools/check_examples.pyholds the file to its schema, and sends a counter-example the schema takes to that rule.Two counter-examples: a decision in another login's name, and a point with no count.
Record 0194 says the form, who decides, and what is not held.
What is not held, and the record says so
config/hooks.json, a model Lens's input, so it is not in this pull request; it is put to the Factory Builder as its own small one.verifyreads the commit alone:is:pr is:merged base:main merged:<2026-11-11T03:57:41Zgives 387, and 387 withauthor:don-petry.main's first-parent line before the event's, 387 of them a pull request's squash and three the first commits. 165 of the 387 change a path theprotectedlist ofconfig/hooks.jsonnames, as it stood at 687db79.What it does not do
decidedis null until the Maintainer writes it.release/AGENTS.md, which is at its 40-line limit. The record's boundaries carry the rules.Checks
make checkstests.test_release,tests.test_evalstests.test_tools, the tests of schemas, examples, envelopes, skills and decisions5b9d98emake verifyverifyis the answer1bf54b31bf54b31bf54b31bf54b35f50124The four first readers read
1bf54b3, which still held the skill's part. Astra read5f50124, after their findings were fixed and the skill's part had left. The head adds Astra's two fixes, names four test tuples once intools/mutants.py, and mends one finding of a review thread: two points that name none are no longer read as one recorded twice (5b9d98e). After that it merges main and renumbers the record from 0193 to 0194 (880c1b1), since "A run record says when its Run began, read from its jobs under P-64's rule (#724, record 0193)" (#751) merged first; nothing decided changes. By the lane's rule a gap in a test needs no read again, so no reader read again.🤖 Generated with Claude Code
CodeAnt-AI Description
Record and validate the Maintainer’s first release decision
What Changed
Impact
✅ First release decision has its counts and context in one record✅ Partial or non-Maintainer decisions are rejected✅ Decision dates cannot predate the counts shown💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.