Skip to content

An act's read again of its item asks when that item's Runs began, all of them past the cap (#724, record 0199) - #760

Merged
don-petry merged 33 commits into
mainfrom
harness/runs-ask-their-items-jobs-724
Nov 12, 2026
Merged

don-petry merged 33 commits into
mainfrom
harness/runs-ask-their-items-jobs-724

Conversation

@don-petry

@don-petry don-petry commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

Part 3 of 4 for #724. It does not close the issue. Part 1 merged as #751 and part 2 as #759; the bound on the pass's asking merged as #771 (record 0196).

It changes harness/reread.py. Whether that is a person's to approve is the Factory's rule to say, not this body's.

What changes

The read again before an act now asks when its item's Runs began, as the pass will, so that both readings carry began_at before the Kernel reads it in part 4.

  • harness/reread.py: hands the records port began={} and on, the item its Run is on. Nothing is kept: a Run keeps nothing from one read to the next.
  • harness/read.py is not changed: the read that builds a Task hands the Kernel no run record, so it asks no job. A test and a mutant hold that. An earlier head of this pull request had it ask too; that bought nothing and could refuse a Task over jobs nothing there reads.
  • The port's on: a read of one item asks that item's Runs alone. Another item's Runs are not asked, say nothing of a beginning, and do not make the read less than whole.
  • Past the cap: a read of one item asks all of that item's Runs, however many. Under the cap of 50, an item with more Runs than that would never be read whole by an act again.
  • It fails closed: a Run of the item whose jobs cannot be read still leaves the read not whole, and the act defers.

A record of its own

The uncapped read of one item contradicts record 0193's row "The cap", and 0193 foretold that both of the Harness's reads would ask. A Boundaries row decides nothing, so this part adds a record that amends those two rows. It is record 0199, the number the Factory Builder gave on 2026-11-12; main ends at 0198.

The exception to the cap, and leaving harness/read.py out, were my design, made to answer reviewers' findings. Neither was part of the Factory Builder's ruling of 2026-11-11, which named both reads and put them in a pull request of their own.

Said plainly

  • The bound on one read: one request for each Run of the item that the list gives, at most the 1,000 GitHub serves of a workflow's runs.
  • The type is not held apart: the test tells one item from another by its repo and by its number. An issue and a pull request share no number.
  • Beside the pass's bound: main's of (record 0196) bounds the pass's asking to the open pull requests' Runs. on is a read of one item and is handed without of; the port keeps both.

Checks

  • make checks: OK at d487f87e, which holds main at e0ac3ffb.
  • tests.test_adapters, tests.test_steps, tests.test_controller: OK at d487f87e (240 tests). No other module was run at the desk: CI's verify is the answer.
  • This part's mutants, filtered: 17 of 17 killed at d487f87e. No mutant is stale.
  • gitleaks: no leaks.
  • Size as the Kernel counts a diff: 22,415 characters, 225 lines.

Reviews

Carbon, Muse, Astra, the Claude review and the security pass, each of this part alone against main. Every finding is fixed or answered.

Reviewer Head Unread parts Blocking Major Minor Info
agy 5f33725 none 0 0 0 0
muse 5f33725 none 0 1 0 0
astra d7992a9 none 0 1 0 0
claude-review d7992a9 none 0 0 2 2
claude-security d7992a9 none 0 0 1 2
Finding Severity Criterion Where What Disposition
muse#1 major PR-3 tests/test_adapters.py:1415 An on-read whose own item's jobs cannot be read is not held to leave the read not whole fixed in 7271fb1: the item's third Run's jobs answer 404, past the cap, and the read is not whole, with the mutant "a read of one item is whole whatever jobs of its Runs cannot be read" and a row in the record
astra#1 major PR-5 tests/test_adapters.py:1424 The uncapped-item boundary test does not cover completed Runs fixed in 5f33725: the test feeds the item's Runs in progress and completed, with the mutant "one item's completed Runs are asked no further than the cap"
claude-review#1 minor none docs/decisions/0193-when-a-run-began-is-read-from-its-jobs-trusted-only-once-a-job-is-in-progress-or-ran-and-kept-by-the-pass-records.md:29 The record's Decision still says no more than 50 Runs are asked in one read; the code now asks one item's without a cap, and only a Boundaries row says so fixed in 5f33725: the exception has its own record, which amends 0193's row on the cap for a read of one item; this change no longer touches 0193
claude-review#2 minor PR-3 tests/test_adapters.py:1424 That one item's Runs are all asked past the cap is held only for Runs in progress: a mutant that counts the item's completed Runs toward the cap survives fixed in 5f33725, as astra#1; another repo's Run in progress is fed too, with the mutant "another item's Run in progress leaves a read of one item not whole"
claude-review#3 info none the change Reviewer's note, no defect of the change: this read first unpacked the head over an older scratch folder named copy, before moving to a folder of its own no defect of the change: three of the four Claude reads shared one scratch folder for about two minutes; each redid its results in a folder of its own, and no worktree was written
claude-review#4 info PR-3 adapters/records.py:341 That item's alone is held by its number only: a mutant that compares the number and not the repo or the type survives fixed in 5f33725 for the repo and the number, each with a mutant; the type is not held apart, since an issue and a pull request share no number, and the record's row says repo and number
claude-security#1 minor PR-5 adapters/records.py:352 "All of them, past the cap" is held for one item's Runs in progress only: counting its completed Runs toward the cap survives fixed in 5f33725, as astra#1
claude-security#2 info none the change Not a defect of the change: this reader overwrote the shared scratchpad directory copy at about 16:40-16:41 CST; results taken from it then should be re-taken no defect of the change: the shared scratch folder, as claude-review#3
claude-security#3 info PR-5 adapters/records.py:341 "That item's alone" is held by number only: an on matched by number, whatever the repo or type, survives fixed in 5f33725, as claude-review#4

Carbon and Muse read 5f337256, which holds the fixes for Astra's and the Claude reads' findings. No reader of mine has read 68149089, which holds the fix for Muse's finding and takes the reader's asking out, nor d487f87e, which merges main (the port now keeps main's of beside on) and renumbers the record.

On GitHub, at 7271fb1a:

Reviewer Where What Disposition
cubic, P2 harness/read.py:149 The reader's new read can come back not whole while the snapshot is told the records were whole answered in 68149089: the reader no longer asks a job, so this pull request adds no way for its list to be not whole. The literal is main's, from before this change; a list read short already holds the Task to nothing recorded, by what the Lenses' records port is handed
cubic, P2 adapters/records.py:341 on scopes the jobs alone; another item's unreadable outcome can still leave the read not whole declined: that is main's reading of outcomes, which this pull request does not change, and it fails closed. Scoping outcomes to one item is its own change
cubic, P3 the record, line 3 The Status points at a pull request it does not name fixed in 68149089: the Status names the issue alone
Gemini, medium adapters/records.py:352 asked += 0 if on is not None else 1 should be an if declined: equivalent, and three mutants are written on that line
CodeAnt, nitpick adapters/records.py:352 With on, every Run of the item is asked in turn, and a long history could pass the step's time limit no change: true, and the record's row "What bounds it" says the bound is the list. A step that times out makes no act, so it fails closed. The most Runs any open pull request had on 2026-11-11 was 12

Codex found nothing. CodeRabbit: skipped, auto reviews are off on this repo.

🤖 Generated with Claude Code

don-petry and others added 26 commits November 11, 2026 07:12
… progress or ran, and kept by the pass records (#724, record 0193)

The records port gains began_at, read from the jobs API under P-64's rule, kept by the pass records and capped at 50 Runs a read. started_at keeps its meaning. No rule of the Kernel reads the field yet.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…d the readers' findings are held (#724)

Muse, the Claude review and the security pass on e63649f: the form of a time, a job's own attempt, a runner named on a job that waits, a key the later record lists, the second read's rows, and a re-run's carried-over jobs, said as they are.

Co-Authored-By: Claude <noreply@anthropic.com>
…thing to work it off (#724)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…running still (#724)

Co-Authored-By: Claude <noreply@anthropic.com>
…t, and the prose is cut to the review budget (#724)

Co-Authored-By: Claude <noreply@anthropic.com>
…724)

Split for the review budget: this part holds the field and the port's read; begun and the Controller's hand-over follow.

Co-Authored-By: Claude <noreply@anthropic.com>
harness/read.py and harness/reread.py hand the records port began={} and their own item. The port's on asks one item's Runs alone, and all of them, past the cap, since a Run keeps nothing to work a cap off.

Co-Authored-By: Claude <noreply@anthropic.com>
…ted run, is no read of its jobs (#724)

Astra on d0ef97f.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…o queued Run, and the record says who asks when (#724)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
… the port's cap lines stand as they are (#724)

Co-Authored-By: Claude <noreply@anthropic.com>
…than their count, and a list that stays not whole (#724)

Co-Authored-By: Claude <noreply@anthropic.com>
…be asked past the cap (#724)

Astra on d6ce6c0.

Co-Authored-By: Claude <noreply@anthropic.com>
…and a null beginning are held (#724)

Co-Authored-By: Claude <noreply@anthropic.com>
…art is held to be a time (#724)

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…one is no read, and a short list stays not whole (#724)

Co-Authored-By: Claude <noreply@anthropic.com>
…issue by title first (#724)

cubic on #751: thirty to a page, a run with more jobs would never be read whole.

Co-Authored-By: Claude <noreply@anthropic.com>
…s-jobs-724

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…d the test holds it for completed Runs and for another repo's

Record 0194 (provisional) amends 0193's row on the cap for a read of one item; the row this branch had added to 0193 moves there.
The port's test feeds the item's Runs in progress and completed, and another repo's Run of the same number, in progress.

Co-Authored-By: Claude <noreply@anthropic.com>
…not whole

Co-Authored-By: Claude <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 11, 2026 23:12
@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
Pre-merge checks: Passed 1 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Passed Passed checks: 1 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codeant-ai

codeant-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #2004d Incremental review completed d487f87 Nov 12, 2026 · 13:15 13:16
✅  #1313d Reviewed your PR 7271fb1 Nov 11, 2026 · 23:12 23:19

@codeant-ai

codeant-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T13:23:44.260744Z d487f87 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codeant-ai codeant-ai Bot added the size:L This PR changes 100-499 lines, ignoring generated files label Nov 11, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements decision 0194, allowing a Run's read of its own item to query when all of that item's Runs began, bypassing the usual cap. This is achieved by adding an on parameter to records.runs() to filter runs for a specific item and conditionally avoiding incrementing the asked job counter. The harness's read and reread steps are updated to pass this parameter, and corresponding tests and documentation are added. A review comment suggests simplifying the conditional increment of asked to avoid redundant addition of zero when on is specified.

Comment thread adapters/records.py Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 7 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread harness/read.py Resolved
Comment thread adapters/records.py Resolved
@codeant-ai

codeant-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt Nitpicks

1 code suggestion

1. With on set, this counter stays at zero, so every matching Run triggers a sequential jobs request; a large or slow history can exceed the reader’s three-minute timeout.

Performance · adapters/records.py:352

@codeant-ai

codeant-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: d487f87e4eea

don-petry and others added 3 commits November 11, 2026 17:20
…ecord

Only the read again before an act decides from the run records, so only it asks when its item's Runs began.
The record says which read asks and which does not, and amends 0193's two rows by name.

Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
@don-petry don-petry changed the title A Run's reads of its item ask when that item's Runs began, all of them past the cap (#724) An act's read again of its item asks when that item's Runs began, all of them past the cap (#724) Nov 11, 2026

@combsmith-sf-pr-review combsmith-sf-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings.

…jobs-724

The asking loop keeps both: the pass's items (of), bounded by the cap, and an act's one item (on), not.

Co-Authored-By: Claude <noreply@anthropic.com>
@don-petry don-petry changed the title An act's read again of its item asks when that item's Runs began, all of them past the cap (#724) An act's read again of its item asks when that item's Runs began, all of them past the cap (#724, record 0199) Nov 12, 2026
@sonarqubecloud

Copy link
Copy Markdown

@combsmith-sf-pr-review combsmith-sf-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants