Repository navigation
An act's read again of its item asks when that item's Runs began, all of them past the cap (#724, record 0199) - #760
Conversation
… progress or ran, and kept by the pass records (#724, record 0193) The records port gains began_at, read from the jobs API under P-64's rule, kept by the pass records and capped at 50 Runs a read. started_at keeps its meaning. No rule of the Kernel reads the field yet. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…d the readers' findings are held (#724) Muse, the Claude review and the security pass on e63649f: the form of a time, a job's own attempt, a runner named on a job that waits, a key the later record lists, the second read's rows, and a re-run's carried-over jobs, said as they are. Co-Authored-By: Claude <noreply@anthropic.com>
…thing to work it off (#724) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…running still (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…t, and the prose is cut to the review budget (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…724) Split for the review budget: this part holds the field and the port's read; begun and the Controller's hand-over follow. Co-Authored-By: Claude <noreply@anthropic.com>
harness/read.py and harness/reread.py hand the records port began={} and their own item. The port's on asks one item's Runs alone, and all of them, past the cap, since a Run keeps nothing to work a cap off.
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…o queued Run, and the record says who asks when (#724) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
… the port's cap lines stand as they are (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…than their count, and a list that stays not whole (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…and a null beginning are held (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…art is held to be a time (#724) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…one is no read, and a short list stays not whole (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…s-jobs-724 Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…d the test holds it for completed Runs and for another repo's Record 0194 (provisional) amends 0193's row on the cap for a read of one item; the row this branch had added to 0193 moves there. The port's test feeds the item's Runs in progress and completed, and another repo's Run of the same number, in progress. Co-Authored-By: Claude <noreply@anthropic.com>
…not whole Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request implements decision 0194, allowing a Run's read of its own item to query when all of that item's Runs began, bypassing the usual cap. This is achieved by adding an on parameter to records.runs() to filter runs for a specific item and conditionally avoiding incrementing the asked job counter. The harness's read and reread steps are updated to pass this parameter, and corresponding tests and documentation are added. A review comment suggests simplifying the conditional increment of asked to avoid redundant addition of zero when on is specified.
There was a problem hiding this comment.
All reported issues were addressed across 7 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
…ecord Only the read again before an act decides from the run records, so only it asks when its item's Runs began. The record says which read asks and which does not, and amends 0193's two rows by name. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…jobs-724 The asking loop keeps both: the pass's items (of), bounded by the cap, and an act's one item (on), not. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
|



Part 3 of 4 for #724. It does not close the issue. Part 1 merged as #751 and part 2 as #759; the bound on the pass's asking merged as #771 (record 0196).
It changes
harness/reread.py. Whether that is a person's to approve is the Factory's rule to say, not this body's.What changes
The read again before an act now asks when its item's Runs began, as the pass will, so that both readings carry
began_atbefore the Kernel reads it in part 4.harness/reread.py: hands the records portbegan={}andon, the item its Run is on. Nothing is kept: a Run keeps nothing from one read to the next.harness/read.pyis not changed: the read that builds a Task hands the Kernel no run record, so it asks no job. A test and a mutant hold that. An earlier head of this pull request had it ask too; that bought nothing and could refuse a Task over jobs nothing there reads.on: a read of one item asks that item's Runs alone. Another item's Runs are not asked, say nothing of a beginning, and do not make the read less than whole.A record of its own
The uncapped read of one item contradicts record 0193's row "The cap", and 0193 foretold that both of the Harness's reads would ask. A Boundaries row decides nothing, so this part adds a record that amends those two rows. It is record 0199, the number the Factory Builder gave on 2026-11-12; main ends at 0198.
The exception to the cap, and leaving
harness/read.pyout, were my design, made to answer reviewers' findings. Neither was part of the Factory Builder's ruling of 2026-11-11, which named both reads and put them in a pull request of their own.Said plainly
of(record 0196) bounds the pass's asking to the open pull requests' Runs.onis a read of one item and is handed withoutof; the port keeps both.Checks
make checks: OK atd487f87e, which holds main ate0ac3ffb.tests.test_adapters,tests.test_steps,tests.test_controller: OK atd487f87e(240 tests). No other module was run at the desk: CI's verify is the answer.d487f87e. No mutant is stale.Reviews
Carbon, Muse, Astra, the Claude review and the security pass, each of this part alone against main. Every finding is fixed or answered.
5f337255f33725d7992a9d7992a9d7992a9tests/test_adapters.py:1415tests/test_adapters.py:1424docs/decisions/0193-when-a-run-began-is-read-from-its-jobs-trusted-only-once-a-job-is-in-progress-or-ran-and-kept-by-the-pass-records.md:29tests/test_adapters.py:1424adapters/records.py:341adapters/records.py:352copyat about 16:40-16:41 CST; results taken from it then should be re-takenadapters/records.py:341onmatched by number, whatever the repo or type, survivesCarbon and Muse read
5f337256, which holds the fixes for Astra's and the Claude reads' findings. No reader of mine has read68149089, which holds the fix for Muse's finding and takes the reader's asking out, nord487f87e, which merges main (the port now keeps main'sofbesideon) and renumbers the record.On GitHub, at
7271fb1a:harness/read.py:14968149089: the reader no longer asks a job, so this pull request adds no way for its list to be not whole. The literal is main's, from before this change; a list read short already holds the Task to nothing recorded, by what the Lenses' records port is handedadapters/records.py:341onscopes the jobs alone; another item's unreadable outcome can still leave the read not whole68149089: the Status names the issue aloneadapters/records.py:352asked += 0 if on is not None else 1should be anifadapters/records.py:352on, every Run of the item is asked in turn, and a long history could pass the step's time limitCodex found nothing. CodeRabbit: skipped, auto reviews are off on this repo.
🤖 Generated with Claude Code