Repository navigation
The pass keeps when its Runs began, and asks a Run's jobs once (#724, record 0193) - #759
Conversation
… progress or ran, and kept by the pass records (#724, record 0193) The records port gains began_at, read from the jobs API under P-64's rule, kept by the pass records and capped at 50 Runs a read. started_at keeps its meaning. No rule of the Kernel reads the field yet. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…d the readers' findings are held (#724) Muse, the Claude review and the security pass on e63649f: the form of a time, a job's own attempt, a runner named on a job that waits, a key the later record lists, the second read's rows, and a re-run's carried-over jobs, said as they are. Co-Authored-By: Claude <noreply@anthropic.com>
…thing to work it off (#724) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…running still (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…t, and the prose is cut to the review budget (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…724) Split for the review budget: this part holds the field and the port's read; begun and the Controller's hand-over follow. Co-Authored-By: Claude <noreply@anthropic.com>
…724) begun reads the last two pass records, and the Controller's read hands the port what they kept, so a Run's jobs are asked only until it has begun. The second part of the port's change, split for the review budget; it adds its rows to record 0193's Boundaries. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…o queued Run, and the record says who asks when (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…ort's (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…than their count, and a list that stays not whole (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…and a null beginning are held (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…art is held to be a time (#724) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…one is no read, and a short list stays not whole (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…runs-began-724 Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…at a pass with nothing kept still asks The records before now differ: the last one's word, and the one before's for a Run the last does not list. A record that is no pass record, one not from before the pass, and none at all each hand the port nothing kept. A null kept for a queued Run is tried too. Co-Authored-By: Claude <noreply@anthropic.com>
… kept of a beginning Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request implements the extraction and retention of Run start times ('began_at') from previous pass records, as outlined in decision 0193. It introduces the begun function in adapters/records.py to parse the last two pass records and track when each Run began. The controller is updated to pass these historical start times to the runs adapter, preventing redundant job reads. Corresponding unit tests and decision documentation have been added to verify and document this behavior. There are no review comments, and I have no additional feedback to provide.
|



User description
Part 2 of 4 for #724. It does not close the issue. Part 1 merged as #751.
What changes
The pass now asks when its Runs began, and keeps what it read, so a Run's jobs are asked once.
records.begun: reads the last two pass records. A time is kept for any Run, null for a completed one alone, by Run id and when the attempt started. The earlier record's word stands only for a Run the later does not list. A key listed twice is kept from neither listing.controller/__main__.pyhands the records portbegan=records.begun(earlier), frompass/1records each from before the pass. With none, or one that is neither, the port is still asked, with nothing kept.No rule of the Kernel reads
began_atyet. That is part 4.The cold start
Record 0193 says the Factory's repo held 27 Runs on 2026-11-11. That count was mine and it was wrong.
run.yml78,approve.yml16), since 2026-11-09, about 40 more a day, kept 90 days.Checks
make checks: OK at32c5bfcf, which holds main at07410345.tests.test_adapters,tests.test_controller,tests.test_token_needs,tests.test_steps,tests.test_reconcile: OK atb7093cbd(268 tests); the Controller's again at32c5bfcf, whose one change is a docstring. Eleven quick modules ran OK at6e4adf5a(428 tests). The simulators, the hooks' and the tools' modules were not run at the desk: CI's verify is the answer.adapters/records.pyand of the entry's hand-over, filtered: 133 of 133 killed atb7093cbd. No mutant is stale at32c5bfcf.Reviews
Carbon, Muse, Astra, the Claude review and the security pass, each of this part alone against main. Every finding is fixed or answered. Carbon's first run, on
6e4adf5a, ended with no read at its 15-minute limit; it read32c5bfcfwhole.32c5bfc6e4adf56e4adf56e4adf56e4adf5tests/test_controller.py:1158controller/__main__.py:158tests/test_adapters.py:1526in_progressonly: a null kept for a queued Run survivestests/test_controller.py:1183begunis handed the records placed before the pass and held to pass/1:began=records.begun(previous)survivescopythat another read was using, for about two minutescontroller/__main__.py:10records.begunknownis main's and is lefttests/test_controller.py:1168begunis handed: the hold to pass/1 and to beforenowhas no test, and three mutants of the hand-over survivetests/test_adapters.py:1526in_progressonly: a null kept for a record's queued Run survivesAstra has not read the head that holds the fix for its finding. This part's code was also read inside part 1's first reads, before the split.
🤖 Generated with Claude Code
CodeAnt-AI Description
Reuse recorded workflow run start times across passes
What Changed
Impact
✅ Fewer repeated job lookups for known runs✅ Fresh start times for rerun attempts✅ No reuse of ambiguous run records💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.