Repository navigation
A run record says when its Run began, read from its jobs under P-64's rule (#724, record 0193) - #751
Conversation
… progress or ran, and kept by the pass records (#724, record 0193) The records port gains began_at, read from the jobs API under P-64's rule, kept by the pass records and capped at 50 Runs a read. started_at keeps its meaning. No rule of the Kernel reads the field yet. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…d the readers' findings are held (#724) Muse, the Claude review and the security pass on e63649f: the form of a time, a job's own attempt, a runner named on a job that waits, a key the later record lists, the second read's rows, and a re-run's carried-over jobs, said as they are. Co-Authored-By: Claude <noreply@anthropic.com>
…thing to work it off (#724) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…running still (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…t, and the prose is cut to the review budget (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…724) Split for the review budget: this part holds the field and the port's read; begun and the Controller's hand-over follow. Co-Authored-By: Claude <noreply@anthropic.com>
…o queued Run, and the record says who asks when (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…than their count, and a list that stays not whole (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…and a null beginning are held (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…art is held to be a time (#724) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Pre-merge checks:
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request implements decision 0193, which introduces the tracking of when a Run actually began (began_at) by reading its jobs from the GitHub API. It adds the _began helper function in adapters/records.py to fetch and parse job start times, ensuring that only jobs in progress or completed with a runner are considered. The runs function is updated to support this tracking with a cap of 50 runs per read to avoid exceeding limits. Additionally, the run record schema is updated to include the optional began_at field, a new decision document is added, and comprehensive unit tests are introduced to validate the new behavior. I have no feedback to provide as there are no review comments.
There was a problem hiding this comment.
All reported issues were addressed across 8 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…one is no read, and a short list stays not whole (#724) Co-Authored-By: Claude <noreply@anthropic.com>
|
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
#739's 0194 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>



Part 1 of 4 for #724. It does not close the issue.
What changes
A run record can now say when its Run began, read from its jobs under the rule
trials/P-64.jsonshowed. No caller asks for it yet, so nothing changes in a pass or a Run until the parts that follow.began_at, optional on a run record.started_atkeeps its meaning, the run'srun_started_at.started_atamong the latest attempt's jobs that arein_progress, orcompletedwith a runner named. Null for a completed Run none of whose jobs began. Absent where it has not begun, or was not read.GET /repos/{repo}/actions/runs/{id}/jobs, as P-64 asked it but a hundred to a page, uncached, for each Run in progress or completed, and only for a caller that handsbegan.JOBS). A Run past the cap, or whose jobs cannot be read, has nobegan_atand leaves the list not whole.Why not
started_atitselfThe issue asks that a record's
started_atbecome its job's start, with a Run that has not begun read as starting now. Two readers ofstarted_atrule that out, and the Factory Builder ruled for a field of its own on 2026-11-11:controller/pass_.py's_streakreads a completed record'sstarted_atinside a window. A Run that never began would be recent at every pass, and an automatic pause it held would never lapse.adapters/records.py'sknownkeys a kept outcome by(run, started_at). A start that moves at every pass is never kept.The four parts, and their order
The whole change measured 63,442 characters as the Kernel counts a diff, over the review budget of 60,000, so it is split. This part is 58,432.
begunreads the pass records before, and the Controller's read hands the port what they kept.harness/read.py,harness/reread.py) for its own item's Runs. A model Lens's input, so a person's to approve.approval_anchor's browser fallback takes a record as old as the approval bybegan_at. That closes the residual decision 0168 names.The order matters: a Run reads its item as the pass does, so both must hand the Kernel the field before the Kernel reads it.
Said plainly
began_atcan be earlier thanstarted_at. Seen on runs of this repo, in no trial. It is kept: a real start of the same run.Checks
make checks: OK at6286861f, which holds main merged at05177d55.e7a1a563; the adapters', the Controller's and the token needs' again at6286861f.tests.test_tools: OK atcb01adbe. A later run of it at the desk failed one test,test_every_check_has_a_test_in_which_it_fails, while I was editing the worktree under it; that test passes alone at6286861f, and CI's verify is the answer.adapters/records.py, filtered: 117 of 117 killed at6286861f. Every mutant's text was checked against its file: none stale.Reviews
Carbon, Muse, Astra, the Claude review and the security pass. Muse and the two Claude reads read
e63649f0, before the split, when this part still held parts 2 and 3; Carbon and Astra readd0ef97f3, after it. Every finding below is fixed or answered.d0ef97fe63649fd0ef97fe63649fe63649fadapters/records.py:226adapters/records.py:342pass/1's enum and the Controller's check of it. An answer older than the list now reads as unread or not begun, never as a wrong time; offered to the Builder as a follow-updocs/decisions/0193-when-a-run-began-is-read-from-its-jobs-trusted-only-once-a-job-is-in-progress-or-ran-and-kept-by-the-pass-records.md:10started_at(cb01adb)docs/decisions/0193-when-a-run-began-is-read-from-its-jobs-trusted-only-once-a-job-is-in-progress-or-ran-and-kept-by-the-pass-records.md:18tests/test_adapters.py:1369tests/test_adapters.py:1453tests/test_adapters.py:1462tools/mutants.py:4346tools/mutants.py:4374tools/mutants.py:4409deland one for the kept time of a Run in progressadapters/records.py:222docs/decisions/0193-when-a-run-began-is-read-from-its-jobs-trusted-only-once-a-job-is-in-progress-or-ran-and-kept-by-the-pass-records.md:15tests/test_adapters.py:1424tools/mutants.py:4418adapters/records.py:201adapters/records.py:220adapters/records.py:226adapters/records.py:228adapters/records.py:368_began, classedactions: readintests/test_token_needs.pyadapters/records.py:227started_at(cb01adb)adapters/records.py:201adapters/records.py:346adapters/records.py:201adapters/records.py:223adapters/records.py:227started_at(cb01adb)adapters/records.py:248begunis in the pull request that follows; fixed there, the earlier record's word standing only for a Run the later does not listadapters/records.py:220adapters/records.py:230adapters/records.py:368pass/1's enum and the Controller's check of it. An answer older than the list now reads as unread or not begun, never as a wrong time; offered to the Builder as a follow-upAstra read four more times, each on the head its last findings were fixed in. Its findings after the first read:
a630661a630661a630661b73c482b73c482b73c482e7a1a56e7a1a5666ff40b66ff40bAstra has not read
c37e2f8a, which holds its last two fixes. Five reads each found two or three test gaps or malformed answers; I stopped there, near the budget's 60,000. Carbon's first run, one63649f0, timed out on two of ten parts and was stopped; its run ond0ef97f3read all nine parts.cubic, on
66ff40be:adapters/records.py:217schemas/run-record.schema.json:75_timeand the Kernel'sis_timehold the calendarCodeAnt, on
6286861f, one finding, major: a jobs request that raisesUnansweredescapes the read. Declined: a request GitHub does not answer refuses the whole read in this port already, for the list and for an outcome alike, and the pass then reads the records as unread and defers.cubic again, on
6286861f, two findings, both declined: P1, the same as CodeAnt's, for the same reason; P2, that the record's Decision rows were edited, which holds for a record on main, and this pull request adds 0193.Codex found nothing on
66ff40be. CodeRabbit: skipped, auto reviews are off on this repo.🤖 Generated with Claude Code