Skip to content

Record 0195: bubblewrap is fetched over HTTPS from a mirror outside ubuntu.com, by a list of the block's own (amends 0106; #743's follow-on) - #765

Merged
don-petry merged 6 commits into
mainfrom
claude/apt-0106-record-main
Nov 12, 2026
Merged

don-petry merged 6 commits into
mainfrom
claude/apt-0106-record-main

Conversation

@don-petry

@don-petry don-petry commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

User description

Follow-on to "The CLI's install fetches bubblewrap by a source list of its own from a mirror the runners resolve, not the image's mirror list" (#748), for "A Run's CLI install fails whole when the runner's Ubuntu mirror cannot be resolved" (#743).

Record 0195, the number the Factory Builder gave it, after #751's 0193 and #739's 0194. It reopens "Record 0193: bubblewrap is fetched over HTTPS from a mirror outside ubuntu.com, by a list of the block's own (amends 0106; #743's follow-on)" (#753), unchanged but for the number, since that pull request's description changed after its first approval.

What changes

Part Change
docs/decisions/0195-…md Amends decision 0106's rows "The fix", "The exception to 'nothing is installed'" and "Its limits", where they name the source; the rest of each row stands. It records: the fault (no ubuntu.com name resolved on the runners, the first failed Run 43033731331); the fix and its proof (canary-repo trial runs 43047814971, 43048275193 and 43101071038); that Ubuntu's signature still holds the package; and the residuals: no Valid-Until, a lookup that never resolves is ended by the step's own timeout, and a pinned third-party mirror
tests/test_tools.py cubic's two P2 points on #748, deferred here by the Factory Builder: the source pattern names mirrors.edge.kernel.org literally, and the first source line must use > while the others use >>. The block's first five lines are pinned too
tools/mutants.py Three mutants: another mirror, the list added to rather than started, and a later line starting it again. All 14 that name the test are killed

No protected path is touched; no model Lens input. The Factory approves.

Verify

make checks passes; the test and its 14 mutants pass. Full verify is CI's.

Reviews

Read Head State
Carbon (gemini-4-carbon-high) 2a6c28d8 A clean read
Muse (Wonder Full) 2a6c28d8 A clean read
Claude + security 2a6c28d8 Nothing blocking. Seven small points, all fixed in 4ebb6300 (085b87f after the rebase onto main): the trial run read as it ran (without the install's retries, about 5 s), 0106's "Its limits" amended and the rest of each row kept, 13:56Z cited to its run, the trial workflows told from the canary check, the block's first five lines pinned, and "the others adding to it"
Astra (gpt-6-astra) 4ebb6300 A clean read

🤖 Generated with Claude Code

View guided diff Turn on auto-fix


CodeAnt-AI Description

Document and verify the CLI's dedicated HTTPS package mirror

What Changed

  • Records that bubblewrap is fetched from a pinned Ubuntu mirror over HTTPS, avoiding reliance on the runner's unresolved Ubuntu mirrors.
  • Verifies the package sources use Ubuntu's signing key, the first source starts a dedicated list, and later sources add to it.

Impact

✅ CLI installs avoid unresolved runner Ubuntu mirrors
✅ Bubblewrap downloads use signed HTTPS sources
✅ Stale apt sources are excluded from installation

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

don-petry and others added 6 commits November 11, 2026 16:09
… from a mirror outside ubuntu.com, amending 0106; the source pattern names the mirror and the first line starts the list (cubic, on #748)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…6's limits amended and the rest of each row kept, the block's first five lines pinned

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…no files of the repo

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
#739's 0194

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 12, 2026 00:14
@coderabbitai

coderabbitai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codeant-ai

codeant-ai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #634c8 Reviewed your PR a69080d Nov 12, 2026 · 00:14 00:17

@codeant-ai

codeant-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T00:17:49.867255Z a69080d PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codeant-ai codeant-ai Bot added the size:M This PR changes 30-99 lines, ignoring generated files label Nov 12, 2026
@sonarqubecloud

Copy link
Copy Markdown

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@codeant-ai

codeant-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: a69080d5b72d

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new architectural decision document (0195) detailing a change to fetch the bubblewrap package over HTTPS from a kernel.org Ubuntu mirror. This change addresses DNS resolution issues with ubuntu.com on GitHub runners that previously caused workflow timeouts. There are no review comments, and I have no feedback to provide.

@combsmith-sf-pr-review combsmith-sf-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings.

@don-petry
don-petry added this pull request to the merge queue Nov 12, 2026
Merged via the queue into main with commit 1b0ae81 Nov 12, 2026
59 checks passed
@don-petry
don-petry deleted the claude/apt-0106-record-main branch November 12, 2026 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants