Repository navigation
The pass asks when a Run began only of the open pull requests' Runs (#724, record 0196) - #771
Conversation
… progress or ran, and kept by the pass records (#724, record 0193) The records port gains began_at, read from the jobs API under P-64's rule, kept by the pass records and capped at 50 Runs a read. started_at keeps its meaning. No rule of the Kernel reads the field yet. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…d the readers' findings are held (#724) Muse, the Claude review and the security pass on e63649f: the form of a time, a job's own attempt, a runner named on a job that waits, a key the later record lists, the second read's rows, and a re-run's carried-over jobs, said as they are. Co-Authored-By: Claude <noreply@anthropic.com>
…thing to work it off (#724) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…running still (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…t, and the prose is cut to the review budget (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…724) Split for the review budget: this part holds the field and the port's read; begun and the Controller's hand-over follow. Co-Authored-By: Claude <noreply@anthropic.com>
…724) begun reads the last two pass records, and the Controller's read hands the port what they kept, so a Run's jobs are asked only until it has begun. The second part of the port's change, split for the review budget; it adds its rows to record 0193's Boundaries. Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…o queued Run, and the record says who asks when (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…ort's (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…than their count, and a list that stays not whole (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…and a null beginning are held (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…art is held to be a time (#724) Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…one is no read, and a short list stays not whole (#724) Co-Authored-By: Claude <noreply@anthropic.com>
…runs-began-724 Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…at a pass with nothing kept still asks The records before now differ: the last one's word, and the one before's for a Run the last does not list. A record that is no pass record, one not from before the pass, and none at all each hand the port nothing kept. A null kept for a queued Run is tried too. Co-Authored-By: Claude <noreply@anthropic.com>
… kept of a beginning Co-Authored-By: Claude <noreply@anthropic.com>
…which it lists first Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
… open pull requests' Runs, and 0193's count is corrected The read order is held: a list of open pull requests not read whole stops the pass before the run records are read. Co-Authored-By: Claude <noreply@anthropic.com>
…n-pull-requests-724 Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…, which asks every Run Co-Authored-By: Claude <noreply@anthropic.com>
Co-Authored-By: Claude <noreply@anthropic.com>
…ich now holds 0195 Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Code Review
This pull request implements decision 0196, which optimizes the process of determining when workflow runs began by restricting the query exclusively to open pull requests. In adapters/records.py, the runs function is updated to accept an optional of parameter to filter runs. In controller/__main__.py, the execution order is adjusted to fetch open pull requests first, passing them to the run records query. A new decision document is added, and corresponding unit tests are introduced in tests/test_adapters.py and tests/test_controller.py to validate this behavior. There are no review comments, so I have no feedback to provide.
|
There was a problem hiding this comment.
1 issue found across 6 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="tests/test_controller.py">
<violation number="1" location="tests/test_controller.py:1479">
P2: This assertion does not prove that Run records were skipped: it ignores the approval and optional queue workflow endpoints. Match every workflow-run path (for example, `/actions/workflows/` together with `/runs`) so the test fails if any Run listing occurs.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic



User description
A follow-on to #724 (record 0196), ruled by the Factory Builder on 2026-11-11 when part 2 (#759) landed. It does not close the issue.
What changes
The pass asks when a Run began only of the open pull requests' Runs. Until now it asked every Run GitHub lists, 50 a pass.
of:records.runstakes a list of items. A Run of any other item is not asked, says what the records before kept of it and no more, and leaves the list whole. The cap of 50 holds among the items given. With none said, every Run is asked, as before.controller/__main__.pyhands the port the open pull requests of the home repo. To do that it lists them before it reads the run records; the order was the other way round. A list of open pull requests not read whole still stops the pass, now before the run records are read.Why
Record 0193 reasoned from 27 Runs. That count was mine and it was wrong.
Said plainly
tests/test_controller.pyholds the new one.adapters/issues.py.on, for one item without a cap. Whichever merges second takes main in first; the two do not overlap in what they decide.Checks
make checks: OK at77d1f32b, which holds main at1b0ae816.be91bc25and again with main merged in, one commit before77d1f32b(429 tests); the Controller's at77d1f32b. The simulators, the hooks' and the tools' modules were not run at the desk: CI's verify is the answer.adapters/records.pyand of the entry's hand-over, filtered: 145 of 145 killed with main merged in, one commit before77d1f32b, which then changed one comment's number. No mutant is stale.Reviews
Carbon, Muse, Astra, the Claude review and the security pass, each at
be91bc25. Four of the five findings are one gap, and every finding is fixed.be91bc2be91bc2be91bc2be91bc2be91bc2tests/test_adapters.py:1415tests/test_adapters.py:1415docs/decisions/0195-the-pass-asks-when-a-run-began-only-of-the-open-pull-requests-runs.md:15adapters/issues.py, which the context check fails once that file existsadapters/records.py:376adapters/records.py:376No reader of mine has read
45d49dc9, which holds those fixes: one test case, one mutant and two record rows.On GitHub, at
45d49dc9:e980ba60: a list with no item in it asks no Run, and no list asks every Run, said so in both rowstests/test_adapters.py:1427deftests/test_controller.pybuilds the same item soadapters/records.py:376Codex found nothing. CodeRabbit: skipped, auto reviews are off on this repo.
🤖 Generated with Claude Code
CodeAnt-AI Description
Request start times only for runs from open pull requests
What Changed
Impact
✅ Fewer job requests for runs from closed pull requests✅ Fewer passes to collect start times for open pull requests✅ No run-record reads after an incomplete pull request list💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.