Repository navigation
The eleventh cut and the move of next, read after the first rollback: release/fixtures/cut.v0-1-10.json (#197's ruling 9′, second of three) - #788
Conversation
…release/fixtures/rollback.v0-1-10.json (#197's ruling 9', first of two) Release run 43317751252 rolled next back from factory/v0.1.10 to factory/v0.1.9 on 2026-11-12, in 16 seconds from its dispatch; run 43317854989, asked 39 seconds after the rollback was, moved it forward again on the eval run the cut had passed. Both ran while the repo's Pause stood. The fixture holds each run, its one job and the job's log at the step, the Deployment each recorded, the newest four Deployments of factory-next, the eval run and its one run on the commit, every factory/ tag as the step's port lists them, and the repo's FACTORY_PAUSED. Every read was made after both runs. The test that holds it whole, and its mutants, follow in a pull request of their own, so each stays under the review budget. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Release run 43270689165 cut factory/v0.1.10 at e719181, #760's merge, on eval run 43267765670. The same reads as cut.v0-1-9.json's, trimmed and redacted the same way, but made after the first rollback and the move forward again: their two Deployments stand above the cut's own, which reads inactive above its success. test_the_next_cut_moved_next_on is told of a rollback and a move made after a cut, by their fixture, and reads this one; twelve mutants of the new fixture are killed by it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, and each cut carries the Deployments recorded after it Muse and the Claude review: the rollback fixture's list of Deployments was read with no check of its status. The helper now places a rollback's two Deployments above the cut they followed wherever that cut stands in a later cut's list, so the eleventh cut joins the loop. Two mutants of the rollback fixture, killed by the cut test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request adds a new release fixture cut.v0-1-10.json and updates the release tests in tests/test_release.py to support testing of an eleventh cut. The test updates include adding ELEVENTH_CUT and FIRST_ROLLBACK fixtures, implementing a new deployments_after helper method to track deployments after a cut, and updating assertions to handle rollbacks and subsequent forward moves. There are no review comments, and I have no feedback to provide.
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
cubic's thread on pull request 788. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|



This records the v0.1.10 cut as
release/fixtures/cut.v0-1-10.json, and tells the cut test of a rollback made after a cut. It is the second of three for ruling 9′ on "Release: cut an immutable tag, move next, and roll back in one action" (#197); the first, "The first rollback and the move forward after it, the fixture alone: release/fixtures/rollback.v0-1-10.json (#197's ruling 9′, first of three)" (#785), has merged. Part of #197; it does not close it.Model-Lens inputs touched: none. The change is the fixture,
tests/test_release.pyandtools/mutants.py. It carries no record.Size. 45,154 characters and 923 lines by
git diff; 52,142 characters as the Kernel counts a diff, with its lines numbered, against a budget of 60,000.What GitHub answered
release.yml, success) cut factory/v0.1.10 at e719181, the merge of "An act's read again of its item asks when that item's Runs began, all of them past the cap (A record's start is read from its job's started_at, trusted only once the job is in progress or ran (P-64) #724, record 0199)" (An act's read again of its item asks when that item's Runs began, all of them past the cap (#724, record 0199) #760). It movedfactory/v0-nextthere and recorded Deployment 7744818544. The fixture holds the run, its one job, and the job's log at the step.eval.yml,workflow_dispatch, success) ran on e719181. It ended at 17:32:49Z, before the cut was asked at 17:33:27Z, and the eval workflow lists it as its only run on that commit.nextboth name e719181:nextis on it again.nexthas thirteen Deployments, newest first: the move forward's, the rollback's, then v0.1.10's own down to v0.1.0's.inactiveabove itssuccess:nextmoved off it at the rollback. v0.1.9's reads the same, as each earlier Release's has at the next cut.The reads went through the Maintainer's login and were trimmed to
cut.v0-1-9.json's fields and headers, read for read.tools/redact_trial.pyredacted them outside the repo, and only the clean output was read. It took out the names of steps[1] and steps[6], the token's mint and its post step, as for v0.1.9.removedsays what was taken.What the cut test learns
tests/test_release.py::test_the_next_cut_moved_next_onreads each cut after the first; v0.1.10 joins its list. One helper is new,deployments_after: the Deployments recorded after a cut by steps that were no cut, read from the fixture of those steps. Today that is one entry, the eleventh cut's, from #785's fixture.printed.deploymentsof both itemsinactiveabovesuccesswhere steps followed it;successalone otherwisenextmoved off at the cutinactiveabovesuccessThe next cut's fixture cannot carry the whole list. It grows by one Deployment a cut, and by two for a rollback and a move: this fixture is 52,142 of 60,000 with thirteen. The fixture of v0.1.11 will page the list, and the helper's expected list will be cut to the page. That is the next cut's pull request, not this one.
Checks it adds
release/AGENTS.md's cut row already names the test, and is unchanged.Checks
make checks872c9c6, main merged in once #785 had merged as a184082tests.test_releasec40a2a2make verifyverifyis the answerc0c923bc0c923bc0c923bc0c923bc40a2a2Astra read the head after the fixes. The others' findings were gaps in the test, so none read again.
c40a2a2: asserted, with a mutant of #785's fixturec40a2a2: the two mutants abovenextmoved offc40a2a2:deployments_after, and the Deployment moved off is the entry below the cut's ownReview threads, three, all resolved
removedsays the run's head commit is taken, yethead_shais therehead_commitobject, and the file holds none;head_shais kept and the test reads it. The words are those ofcut.v0-1-8.json,cut.v0-1-9.jsonandrollback.refused.jsonfa834e7🤖 Generated with Claude Code