Skip to content

The eleventh cut and the move of next, read after the first rollback: release/fixtures/cut.v0-1-10.json (#197's ruling 9′, second of three) - #788

Merged
don-petry merged 5 commits into
mainfrom
claude/cut-v0-1-10-fixture
Nov 13, 2026
Merged

don-petry merged 5 commits into
mainfrom
claude/cut-v0-1-10-fixture

Conversation

@don-petry

@don-petry don-petry commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

This records the v0.1.10 cut as release/fixtures/cut.v0-1-10.json, and tells the cut test of a rollback made after a cut. It is the second of three for ruling 9′ on "Release: cut an immutable tag, move next, and roll back in one action" (#197); the first, "The first rollback and the move forward after it, the fixture alone: release/fixtures/rollback.v0-1-10.json (#197's ruling 9′, first of three)" (#785), has merged. Part of #197; it does not close it.

Model-Lens inputs touched: none. The change is the fixture, tests/test_release.py and tools/mutants.py. It carries no record.

Size. 45,154 characters and 923 lines by git diff; 52,142 characters as the Kernel counts a diff, with its lines numbered, against a budget of 60,000.

What GitHub answered

The reads went through the Maintainer's login and were trimmed to cut.v0-1-9.json's fields and headers, read for read. tools/redact_trial.py redacted them outside the repo, and only the clean output was read. It took out the names of steps[1] and steps[6], the token's mint and its post step, as for v0.1.9. removed says what was taken.

What the cut test learns

tests/test_release.py::test_the_next_cut_moved_next_on reads each cut after the first; v0.1.10 joins its list. One helper is new, deployments_after: the Deployments recorded after a cut by steps that were no cut, read from the fixture of those steps. Today that is one entry, the eleventh cut's, from #785's fixture.

Held How
The read of the Deployments after the cut was answered 200 asserted before its body is taken
Those two Deployments are the move's and the rollback's, by the ids each run printed against printed.deployments of both items
The steps were of this cut's Release and came back to its commit the rollback fixture's version and its newest Deployment's commit, against the cut's
The whole list, newest first for the cut and for every cut below it: the Deployments after it, then its own. So a later cut's list places the rollback's two between its own and v0.1.10's with no further change
The cut's own Deployment inactive above success where steps followed it; success alone otherwise
The Deployment next moved off at the cut the entry right below the cut's own, inactive above success

The next cut's fixture cannot carry the whole list. It grows by one Deployment a cut, and by two for a rollback and a move: this fixture is 52,142 of 60,000 with thirteen. The fixture of v0.1.11 will page the list, and the helper's expected list will be cut to the page. That is the next cut's pull request, not this one.

Checks it adds

  • Twelve mutants of the new fixture, each killed by the cut test: another eval workflow, run or commit; an eval that ended after the cut; another run listed on the commit; v0.1.9 moved; the cut's Deployment not v0.1.10's; its status not success; the cut's Deployment still active after the rollback; v0.1.9's Deployment still reading only success; the Deployment above the cut's not the rollback's; the newest not the move's.
  • Two mutants of The first rollback and the move forward after it, the fixture alone: release/fixtures/rollback.v0-1-10.json (#197's ruling 9′, first of three) #785's fixture, each killed by the cut test: the read of the Deployments answered 500, and the fixture another Release's.
  • release/AGENTS.md's cut row already names the test, and is unchanged.

Checks

Check Result
make checks OK, at 872c9c6, main merged in once #785 had merged as a184082
tests.test_release OK, 34 tests
Mutants of the cuts' fixtures and of #785's, run alone on an export 104 of 104 killed, at c40a2a2
gitleaks on the fixture No leaks
Full make verify Not run locally, by the Maintainer's standing change of 2026-11-09; CI's verify is the answer
Reviewer Head Unread parts Blocking Major Minor Info
agy (Carbon) c0c923b part 2 of 2 not run (quota), owed 0 0 0 0
muse c0c923b none 0 1 0 0
claude-review c0c923b none 0 0 2 1
claude-security c0c923b none 0 0 0 0
astra c40a2a2 none 0 0 0 0

Astra read the head after the fixes. The others' findings were gaps in the test, so none read again.

Finding What Disposition
muse #1, claude-review #1 The Deployments after the cut were read from an answer the test did not hold to 200 fixed in c40a2a2: asserted, with a mutant of #785's fixture
claude-review #2 No listed mutant needed the two assertions on #785's fixture fixed in c40a2a2: the two mutants above
claude-review #3 (info) The helper could not read the next cut's fixture, and would have read the wrong Deployment as the one next moved off fixed in c40a2a2: deployments_after, and the Deployment moved off is the entry below the cut's own

Review threads, three, all resolved

Thread Disposition
cubic: removed says the run's head commit is taken, yet head_sha is there not changed: what is taken is the run's head_commit object, and the file holds none; head_sha is kept and the test reads it. The words are those of cut.v0-1-8.json, cut.v0-1-9.json and rollback.refused.json
cubic: the helper's docstring says None where it returns an empty list fixed in fa834e7
codeant: the rollback's Deployment is checked by its id alone not changed: the helper returns it whole and the cut test compares commit and Release against the cut fixture's list; that it is of the Release the rules plan the rollback to is the rollback's own test's to hold, in the third pull request, with its mutant

🤖 Generated with Claude Code

don-petry and others added 4 commits November 12, 2026 16:38
…release/fixtures/rollback.v0-1-10.json (#197's ruling 9', first of two)

Release run 43317751252 rolled next back from factory/v0.1.10 to factory/v0.1.9 on
2026-11-12, in 16 seconds from its dispatch; run 43317854989, asked 39 seconds after the
rollback was, moved it forward again on the eval run the cut had passed. Both ran while
the repo's Pause stood. The fixture holds each run, its one job and the job's log at the
step, the Deployment each recorded, the newest four Deployments of factory-next, the eval
run and its one run on the commit, every factory/ tag as the step's port lists them, and
the repo's FACTORY_PAUSED. Every read was made after both runs. The test that holds it
whole, and its mutants, follow in a pull request of their own, so each stays under the
review budget.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Release run 43270689165 cut factory/v0.1.10 at e719181, #760's merge, on eval run 43267765670. The same reads as
cut.v0-1-9.json's, trimmed and redacted the same way, but made after the first rollback and the move forward again:
their two Deployments stand above the cut's own, which reads inactive above its success. test_the_next_cut_moved_next_on
is told of a rollback and a move made after a cut, by their fixture, and reads this one; twelve mutants of the new
fixture are killed by it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, and each cut carries the Deployments recorded after it

Muse and the Claude review: the rollback fixture's list of Deployments was read with no check of its status.
The helper now places a rollback's two Deployments above the cut they followed wherever that cut stands in a
later cut's list, so the eleventh cut joins the loop. Two mutants of the rollback fixture, killed by the cut test.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 12, 2026 23:37
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codeant-ai

codeant-ai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #d9dd0 Reviewed your PR 872c9c6 Nov 12, 2026 · 23:37 23:43

@codeant-ai

codeant-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-12T23:43:31.891918Z fa834e7 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new release fixture cut.v0-1-10.json and updates the release tests in tests/test_release.py to support testing of an eleventh cut. The test updates include adding ELEVENTH_CUT and FIRST_ROLLBACK fixtures, implementing a new deployments_after helper method to track deployments after a cut, and updating assertions to handle rollbacks and subsequent forward moves. There are no review comments, and I have no feedback to provide.

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread release/fixtures/cut.v0-1-10.json Resolved
Comment thread tests/test_release.py Resolved
cubic's thread on pull request 788.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

Comment thread tests/test_release.py Resolved
@codeant-ai

codeant-ai Bot commented Nov 12, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt Nitpicks

1 code suggestion

1. The status checks cover the cut Deployment and an older one, but not the rollback or forward-move Deployments, so incorrect follow-on states pass.

Incomplete implementation · tests/test_release.py:474-475

@codeant-ai

codeant-ai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟡  Medium Risk

  • The PR needs attention before merging; the rollback Deployment’s SHA and release are not asserted against the rollback target, so a wrong rollback can pass.

Assessed commit: fa834e7178d6

@combsmith-sf-pr-review combsmith-sf-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No problems found in the v0.1.10 cut fixture, its test or its mutants.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants