You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
A cut's fixture carries every Deployment of next, one more a cut: page the list before GitHub's page of 30 or the review budget is reached #792
Each cut's fixture, release/fixtures/cut.vX-Y-Z.json, holds the whole list of factory-next's Deployments, and tests/test_release.py::test_the_next_cut_moved_next_on compares that whole list against every earlier cut's own Deployment. The list grows by one a cut, and by two more for a rollback and the move forward after it. Two limits lie ahead; neither is at the next cut.
Limit
Where it bites
When, as things stand
GitHub's default page of 30
GET /repos/{repo}/deployments?environment=factory-next is asked with no per_page, so the 31st Deployment drops the oldest from the answer, and the test's whole-list comparison fails
13 Deployments after factory/v0.1.10: 17 more cuts, fewer with rollbacks
The review budget, 60,000 characters as the Kernel counts a diff
A plain cut's pull request (fixture, one entry in the test's list, nine mutants)
About 600 characters a Deployment. "The tenth cut and the move of next: release/fixtures/cut.v0-1-9.json" (#777) was 42,190 with ten; that leaves room for about 27 more
"The eleventh cut and the move of next, read after the first rollback: release/fixtures/cut.v0-1-10.json (#197's ruling 9′, second of three)" (#788) was 52,142, but most of that was the helper deployments_after and fourteen mutants, not the list: its fixture is 31,728 characters against v0.1.9's 29,788.
What to change, before either limit
The cut's fixture asks a page, per_page=K, as release/fixtures/rollback.v0-1-10.json already does with per_page=4. K covers the cut's own Deployment, the one next moved off, and whatever the test must place between them.
a_later_cut_moved_next_on compares the page against the first K of the list it expects, and still builds that list from the cuts' fixtures and deployments_after.
The fixtures already merged keep their whole lists; the helper takes the page's length from the fixture it reads.
The test's own list of cuts in test_the_next_cut_moved_next_on grows by a line a cut too. Reading the cuts from release/fixtures/cut.v*.json in version order, as the rollback's test does, would stop that; each cut's eval run id would then come from its fixture.
The builder outside the repo that makes the raw capture asks the same page.
Done when
A cut's pull request is the same size whatever the number of Deployments, the test still holds the cut's own Deployment, the one moved off and their order, and a mutant shows the page's order is held.
Not urgent. Found while landing #788; part of "Release: cut an immutable tag, move next, and roll back in one action" (#197)'s fixtures, and it does not block that story.
Activity