Skip to content

A cut's fixture reads a page of next's Deployments, held to its order, and every cut after factory/v0.1.11 must (#792) - #813

Merged
don-petry merged 5 commits into
mainfrom
claude/cut-fixture-pages-792
Nov 13, 2026
Merged

don-petry merged 5 commits into
mainfrom
claude/cut-fixture-pages-792

Conversation

@don-petry

@don-petry don-petry commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Fixes #792

A cut's fixture now reads a page of next's Deployments. The pull request for a cut is then the same size however many Deployments there are, and GitHub's default page of 30 never cuts the list short. The cuts are read from release/fixtures/cut.v*.json in version order, so a new cut adds no line to the test. Every cut after factory/v0.1.11, the last cut that read the whole list, must read a page. No record: the change states no new rule of the Factory, only of a test.

What

tests/test_release.py:

  • deployments_read reads next's Deployments in one of two forms, and the path must match one of them exactly:

    • the whole list, which every cut through v0.1.11 asked for;
    • a first page of per_page=1..9, which every cut from issue 792 on asks for.

    A later page (&page=2), any other query, or a page of 10 or more is refused.

  • a_later_cut_moved_next_on, for a page: the page must hold what stands above the cut's own Deployment, that Deployment, and the one next moved off. They must be in order, and they must be the first entries of the list the earlier cuts build. A page too short for them, in another order, or not the first page is refused.

  • cuts() / each_cut_moved_next_on():

    • every cut fixture is read in version order, and each cut's eval run comes from its own fixture;
    • test_the_next_cut_moved_next_on pins the twelve cuts on main by name, plus v0.1.1's eval run (42694638100).
  • WHOLE_LIST = TWELFTH_CUT: each cut after it must read a page. That is checked before anything else about the cut, so a whole-list read is refused for that reason alone.

  • deployments_after reads LATER, the cuts a rollback and a move forward followed, by the fixture's name.

  • paged(): factory/v0.1.10's fixture, asked again as a page. Two tests use it.

.claude/skills/cut-a-release/SKILL.md: one line on asking a page of 4 at capture, and on the page rule.

The capture copy: the builder that makes the raw capture lives outside the repo. Lane e owns build_cut2.py, and I did not edit it. My copy with &per_page=4 on both Deployments reads is at /Users/rachelpetry/Library/Application Support/Claude/side-session-notes/local_c510c58f-f558-40e3-9448-76cbe305ed2b/lane-552-792/build_cut_paged.py. It compiles, but it has not run against GitHub. The next cut is its first real run.

Held by

  • tests/test_release.py::test_a_cut_that_reads_a_page_of_next_s_deployments_is_held_to_its_order: v0.1.10 asked as a page of 4 passes. A page of 3, a page with two entries swapped, a short page, &page=2 and a page of 10 are each refused.
  • tests/test_release.py::test_a_cut_added_later_is_held_as_every_cut_is: a cut added after the last, at the next version, is read in its place.
    • Asked for the whole list, it is refused by the page rule, under the default WHOLE_LIST.
    • Asked for a page, it is refused for what the page holds.
  • tests/test_release.py::test_a_cut_after_the_last_that_read_the_whole_list_reads_a_page:
    • with v0.1.10 as the last whole-list cut, v0.1.11, the cut right after it, is refused for reading the whole list;
    • with v0.1.9 as the last, v0.1.10 asked as a page of 4 is held.
  • Mutants: 12 new, each killed by the test it names. Mutants of tests/test_release.py: 12 of 12 killed. Mutants of the release fixtures: 184 of 184 killed.
  • make checks: green.

Diff: about 24,000 characters, 279 lines.

Second readers

Reader Head Result
Carbon (Gemini 4 Carbon) 7de0cd2a (before the rebase) no findings
Carbon 58ca879 not run (quota), owed
Muse — not run (it hung on the first read), owed
Astra (gpt-6-astra) before the rebase 1 major, fixed: nothing showed a cut added later is held. 1 minor, fixed: the page parser took any query after per_page
Astra 58ca879 2 majors, both fixed in 90ddc87: the synthetic later cut stopped being later at v0.2.0, so it now takes the next version after the last cut; under the default WHOLE_LIST, nothing refused a later whole-list cut for the page rule (test and mutant added)
Claude + security before the rebase no blocker. Minors left as they are: (1) the eval run id of each cut after v0.1.1 is held only by its fixture; (2) LATER needs a code line for the next rollback; (3) the old comment's per-cut history is gone, though it is still in git
Claude + security 58ca879 no security finding. 1 major, fixed in 90ddc87: the bound could shift by one unseen, so the refusal is now shown on the cut right after the last. 2 minors, fixed: the last whole-list cut must be among those read; a page is at most 9

The fixes in 90ddc87 came after the readers; none of them re-read that head.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

don-petry and others added 4 commits November 12, 2026 23:23
…, and the cuts are read in version order (#792)

So a cut's pull request is the same size however many Deployments there are, and adds no line to the test's list of cuts; each cut's eval run is read from its fixture.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… page is read only as the first, and LATER is read by a fixture's name

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…f Deployments, reads a page (#792)

WHOLE_LIST names the twelfth cut; each cut after it in release/fixtures/ must read a page. Shown with
factory/v0.1.9 as the last: the two cuts after it that read the whole list are refused, and factory/v0.1.10
asked as a page of four is held. Three mutants; the page helper is lifted so both tests use it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… cut is refused, under the default too (#792)

The Claude review: the refusal is shown on the cut right after the last that read the whole list, so the bound
cannot shift by one; that cut must be read with the rest; a page is at most 9. Astra: the cut added later takes
the next version after the last, so a v0.2.0 cut does not break the test; under the default, a whole-list later
cut is refused for the page rule, a paged one for what its page holds. Three mutants.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 13, 2026 05:32
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T05:57:04.482504Z a2b1df3 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codeant-ai

codeant-ai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #3d6a8 Reviewed your PR 90ddc87 Nov 13, 2026 · 05:32 05:38

@codeant-ai

codeant-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the release-cutting skill documentation and refactors the release tests in tests/test_release.py to support paged deployment reads (addressing issue 792). It introduces new test cases to verify that cuts after a certain version read a page of deployments rather than the whole list, and adds helper methods like deployments_read and eval_run. The review feedback suggests optimizing the lookup in deployments_after to avoid rebuilding a dictionary on every call, and adding type safety checks in eval_run to prevent potential runtime errors when parsing non-dictionary response bodies.

Comment thread tests/test_release.py Resolved
Comment thread tests/test_release.py Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 3 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread tests/test_release.py Resolved
Comment thread .claude/skills/cut-a-release/SKILL.md Resolved
@codeant-ai

codeant-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt Nitpicks

3 code suggestions

1. Because only the URL token is matched, a POST to this endpoint with a 200 response is accepted as the required Deployments read.

Api mismatch · tests/test_release.py:447-448


2. Cuts before WHOLE_LIST are never required to use the whole list, so changing an earlier fixture to a valid page passes this walk.

Logic error · tests/test_release.py:540-541


3. This changes only the fixture version; its item's asked.version stays v0.1.10, so the page case fails on version mismatch before testing page contents.

Logic error · tests/test_release.py:588

@codeant-ai

codeant-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: 90ddc878eaa0

@combsmith-sf-pr-review combsmith-sf-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No gating findings.

… it, and the skill says 4 is asked, 1 to 9 accepted

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A cut's fixture carries every Deployment of next, one more a cut: page the list before GitHub's page of 30 or the review budget is reached

2 participants