Repository navigation
A cut's fixture reads a page of next's Deployments, held to its order, and every cut after factory/v0.1.11 must (#792) - #813
Conversation
…, and the cuts are read in version order (#792) So a cut's pull request is the same size however many Deployments there are, and adds no line to the test's list of cuts; each cut's eval run is read from its fixture. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… page is read only as the first, and LATER is read by a fixture's name Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…f Deployments, reads a page (#792) WHOLE_LIST names the twelfth cut; each cut after it in release/fixtures/ must read a page. Shown with factory/v0.1.9 as the last: the two cuts after it that read the whole list are refused, and factory/v0.1.10 asked as a page of four is held. Three mutants; the page helper is lifted so both tests use it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… cut is refused, under the default too (#792) The Claude review: the refusal is shown on the cut right after the last that read the whole list, so the bound cannot shift by one; that cut must be read with the rest; a page is at most 9. Astra: the cut added later takes the next version after the last, so a v0.2.0 cut does not break the test; under the default, a whole-list later cut is refused for the page rule, a paged one for what its page holds. Three mutants. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
Code Review
This pull request updates the release-cutting skill documentation and refactors the release tests in tests/test_release.py to support paged deployment reads (addressing issue 792). It introduces new test cases to verify that cuts after a certain version read a page of deployments rather than the whole list, and adds helper methods like deployments_read and eval_run. The review feedback suggests optimizing the lookup in deployments_after to avoid rebuilding a dictionary on every call, and adding type safety checks in eval_run to prevent potential runtime errors when parsing non-dictionary response bodies.
There was a problem hiding this comment.
All reported issues were addressed across 3 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
… it, and the skill says 4 is asked, 1 to 9 accepted Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|



Fixes #792
A cut's fixture now reads a page of
next's Deployments. The pull request for a cut is then the same size however many Deployments there are, and GitHub's default page of 30 never cuts the list short. The cuts are read fromrelease/fixtures/cut.v*.jsonin version order, so a new cut adds no line to the test. Every cut after factory/v0.1.11, the last cut that read the whole list, must read a page. No record: the change states no new rule of the Factory, only of a test.What
tests/test_release.py:deployments_readreads next's Deployments in one of two forms, and the path must match one of them exactly:per_page=1..9, which every cut from issue 792 on asks for.A later page (
&page=2), any other query, or a page of 10 or more is refused.a_later_cut_moved_next_on, for a page: the page must hold what stands above the cut's own Deployment, that Deployment, and the onenextmoved off. They must be in order, and they must be the first entries of the list the earlier cuts build. A page too short for them, in another order, or not the first page is refused.cuts()/each_cut_moved_next_on():test_the_next_cut_moved_next_onpins the twelve cuts on main by name, plus v0.1.1's eval run (42694638100).WHOLE_LIST = TWELFTH_CUT: each cut after it must read a page. That is checked before anything else about the cut, so a whole-list read is refused for that reason alone.deployments_afterreadsLATER, the cuts a rollback and a move forward followed, by the fixture's name.paged(): factory/v0.1.10's fixture, asked again as a page. Two tests use it..claude/skills/cut-a-release/SKILL.md: one line on asking a page of 4 at capture, and on the page rule.The capture copy: the builder that makes the raw capture lives outside the repo. Lane e owns
build_cut2.py, and I did not edit it. My copy with&per_page=4on both Deployments reads is at/Users/rachelpetry/Library/Application Support/Claude/side-session-notes/local_c510c58f-f558-40e3-9448-76cbe305ed2b/lane-552-792/build_cut_paged.py. It compiles, but it has not run against GitHub. The next cut is its first real run.Held by
tests/test_release.py::test_a_cut_that_reads_a_page_of_next_s_deployments_is_held_to_its_order: v0.1.10 asked as a page of 4 passes. A page of 3, a page with two entries swapped, a short page,&page=2and a page of 10 are each refused.tests/test_release.py::test_a_cut_added_later_is_held_as_every_cut_is: a cut added after the last, at the next version, is read in its place.WHOLE_LIST.tests/test_release.py::test_a_cut_after_the_last_that_read_the_whole_list_reads_a_page:tests/test_release.py: 12 of 12 killed. Mutants of the release fixtures: 184 of 184 killed.make checks: green.Diff: about 24,000 characters, 279 lines.
Second readers
per_pageWHOLE_LIST, nothing refused a later whole-list cut for the page rule (test and mutant added)LATERneeds a code line for the next rollback; (3) the old comment's per-cut history is gone, though it is still in gitThe fixes in 90ddc87 came after the readers; none of them re-read that head.
🤖 Generated with Claude Code