Skip to content

Slice 1's event is held whole by its test and its mutants (#198's ruling 6, second of two) - #732

Merged
don-petry merged 7 commits into
mainfrom
claude/slice-1-event-fixture
Nov 11, 2026
Merged

don-petry merged 7 commits into
mainfrom
claude/slice-1-event-fixture

Conversation

@don-petry

@don-petry don-petry commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

User description

This holds slice 1's event whole: the test of release/fixtures/event.slice-1.json and its mutants, as ruling 6 of "The ruleset switch: main requires the machine user's approval of the most recent commit, and slice 1's event is recorded" (#198) asks. It is the second of two; the fixture itself merged alone as 2054a9d in "Slice 1's event, the fixture alone: release/fixtures/event.slice-1.json (#198's ruling 6, first of two)" (#733). Part of #198; it does not close it.

Model-Lens inputs touched: none. The change is tests/test_release.py and tools/mutants.py.

Size. 25,659 characters and 284 lines by gh pr diff; 28,473 characters as the Kernel counts a diff, with its lines numbered, against a budget of 60,000. This pull request first held the fixture too and was held too_large at 67,308 by that count, so it was closed, the fixture went first, and it is reopened with the test alone.

The event

"Rulesets: main counts the machine user's approval, as the switch of 2026-11-11 left it (#198, record 0191)" (#730), on 2026-11-11:

When What By
02:18:03Z main last changed: it counts one approval The switch
03:13:04Z The pull request opened don-petry
03:26:49Z Pass p_KQ88EB3ZFFWPE132C4EK: verifying, awaiting_checks factory/v0.1.6
03:38:29Z Pass p_NANTVRFXGVRZ0YMK958X: verifying, awaiting_review, admits the review Run factory/v0.1.6
03:38:33Z to 03:40:46Z Review Run 42954100593, success; the Role's review of the head at 03:40:33Z combsmith-sf-pr-review
03:42:19Z Pass p_3RBP88Z3BEKDSTMRXSDX: converged, approval_due, acts issue_approval factory/v0.1.6
03:42:56Z Review 5853546913: APPROVED at 8fc5492 donpetry-bot
03:43:04Z Added to the merge queue don-petry
03:45:08Z Pass p_11GYAWVG130RGYV4Y1X1: queued, in_merge_queue factory/v0.1.6
03:57:41Z Merged as d9eeb54 The queue

factory/v0.1.6 was cut at 23:45Z on 2026-11-10, before the pull request's first commit at 02:24Z.

What the fixture holds, now on main

  • Twenty-two reads made afterwards through the Maintainer's login, each trimmed to the fields kept and passed through tools/redact_trial.py outside the repo; only the clean output was read. They are the ruleset, the repository, the pull request, its commits and reviews, the queue and merge events, next and the Release's tag and commit, each step's poller run and its artifacts, the review Run and the approving act with theirs, and the status on the item.
  • steps: the four passes whose Decision on the merged head differed from the pass before's, each with the head it read and its pass record's artifact id and digest.
  • event: the summary the test holds to the reads, with each Run's own outcome/1.
  • No pass record, applied, result or verdict file is kept. removed says what was taken.

Where it departs from ruling 6, for a ruling

Checks it adds

tests/test_release.py::test_the_slice_1_event_is_whole holds, against the fixture's own reads and the configuration:

  • the ruleset counts one approval by all five fields, as config/rulesets.json records, covers the default branch, which is the pull request's base, and last changed before the pull request opened;
  • the author is the Maintainer; the one approval is the approver's, a user's, of the head, of the last push, and the last review made, with no request for changes;
  • the Maintainer's login enqueued it after the approval, and the merge is the pull request's own, into main;
  • every step and both Runs name one Release, the one next and its tag name, cut before the first commit, by the cut's own fixture;
  • each step is a distinct pass in strict order, of the head that merged, its poller run on main, its record the artifact GitHub lists;
  • the review Run and the approving act carry the item, the Intent, the Role, the one content and the Run's id in their names, ran on main and succeeded; the Role's own review is of the head, within its Run;
  • the status on the item is the controller's, and is word for word what the effects port writes for the last step's Decision.

Thirty-two mutants of the fixture are killed by it. release/AGENTS.md gains no row: it is at its 40-line limit.

No record is needed: no rule changes.

Checks

Check Result
make checks OK
tests.test_release OK, 29 tests, on the head with main merged in
Mutants of the fixture, run alone on an export 32 of 32 killed, at fe634c3
gitleaks on the fixture No leaks
Full make verify Not run locally, by the Maintainer's standing change of 2026-11-09; CI's verify is the answer
Reviewer Head Unread parts Blocking Major Minor Info
agy (Carbon) a27c4da none 0 2 3 0
muse a27c4da none 0 3 1 0
astra a7da8b5 none 0 2 0 0
astra 793a27e none 0 1 0 0
astra 11e82af none 0 2 0 0
claude-review a27c4da none 0 1 4 2
claude-security a27c4da none 0 0 8 1

The readers read fb3d5ce and before; the head is fe634c3, which adds only the merge of main, where the same fixture now is. Every finding was a claim the test did not hold, or a read the fixture did not keep; none found the fixture wrong, and the Claude review checked the four steps against the pass records live. Astra's last two majors, at 11e82af, are of that kind and are fixed at the head; by the lane's rule a gap in a test needs no read again, so no reader read again after them.

Finding What Disposition
muse #1, security #5, #6, astra@a7da8b5 #1, astra@793a27e #1 A read was trusted by its path; the repo, each run's id, each tag's ref, the query's variables, the ruleset's branch and the default branch were unread fixed: each is held; the fixture keeps the ruleset's conditions and the repository's read
muse #2, claude-review #1, security #4 Nothing held the event to after the switch fixed: the ruleset's own read, last changed before the pull request opened
muse #2, security #9, agy #1, astra@11e82af #2 The approval was not held to the last push, nor a step to the head that merged fixed: the last commit is the head; the approval is the last review; each step keeps the head its pass read
muse #3, claude-review #2, security #1, #2, agy #3, #4 The review Run was not tied to the approved content, nor either Run to main fixed: each name is compared whole; both ran on main; the Role's own review is of the head
muse #4, security #3, #7, agy #5, astra@a7da8b5 #2 The status was held by its title, pass and Release alone fixed: its App, and its whole output as the effects port writes it
claude-review #5 Each Run's own outcome was dropped fixed: kept with its artifact and digest, and held to the event's Release and no fault
claude-review #6, security #8, agy #1 FR-50 compared the commit's date, not the cut's fixed: the cut's own fixture is read
agy #2 Steps could repeat a pass fixed: distinct pass, run, artifact and digest, in strict order
astra@11e82af #1 The ruleset's fields were compared by whichever the fixture kept fixed: all five are named
claude-review #3 Three pass ids are held by nothing no change to the test: removed says each step's id, State and codes are transcribed and rest on its record's digest
claude-review #4 By ruling 6's words the event is #726 the fixture's read, the test and this description say so; the ruling is the Factory Builder's to amend
claude-review #7 release/AGENTS.md has no row for the test no change: the file is at its 40-line limit

🤖 Generated with Claude Code


CodeAnt-AI Description

Verify the recorded approval and merge history for slice 1

What Changed

  • Add checks that the pull request was approved by the configured approver on its latest commit, after the approval requirement took effect.
  • Verify that the merge, release, review, and recorded workflow steps all match the same event and occur in the expected order.
  • Catch altered event records, including mismatched approvals, release details, workflow results, and status checks.

Impact

✅ Catches approvals on the wrong commit
✅ Detects mismatched release and merge records
✅ Flags incomplete event histories

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

don-petry and others added 6 commits November 10, 2026 23:02
…e-1.json (#198's ruling 6)

Pull request 730, the record of the ruleset switch, is the event: opened after main began to count an approval,
reviewed by factory/v0.1.6 on next, approved at its head by the Factory's approving act as the machine user, and
merged through the queue as d9eeb54. The fixture holds twenty reads made afterwards, trimmed and redacted, and the
four passes whose Decision on the merged head differed from the pass before's, each by its record's artifact and
digest. The Maintainer's login enqueued it; no enqueue by the Factory's queue step is claimed.

test_the_slice_1_event_is_whole holds the fixture's claims to its own exchanges and to the configuration, and
fifteen mutants of the fixture are killed by it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…t each read says of itself

Muse, the security pass and the Claude review found the test trusting reads by their path, and holding neither the
switch before the event, the last push, the content the review was of, the Runs' own Release nor the status's lines.
The fixture gains the ruleset's read and each Run's outcome/1, and says that pull requests 726 and 729 merged on the
approval before this one. The test holds each of these, and nineteen more mutants are killed by it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… and the status says each line once

Carbon found the steps held only to a non-decreasing order and distinct ids, and the status's lines read into a
dictionary that hides a line said twice. The test holds each.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…d as the port writes it

Astra found that a ruleset named main need not cover main, and that the status's next actor was compared with
itself. The fixture keeps the ruleset's conditions, and the test rebuilds the status with the effects port's own
function from the last step. Two mutants hold these, and two the whole comparison made redundant are dropped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ruleset covers and the pull request's base is

Astra found that covering the default branch does not show the ruleset covers main unless main is the default.
The fixture keeps the repository's own read, and the test holds its default branch to the pull request's base.
One mutant holds it, and three that repeat another's assertion are dropped to stay under the review budget.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… fields are held by name

Astra found the ruleset's fields compared by whichever the fixture kept, and a commit's date standing for the
push. The test names the five fields, each step keeps the head its pass read, and the test holds it to the head
that merged. Two mutants hold these, and two that repeat another's assertion are dropped.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 11, 2026 05:40
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-11T05:40:42.493700Z
We couldn’t complete this review. Comment @codex review to try again.
fb3d5ce PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Pre-merge checks: Passed 1 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Passed Passed checks: 1 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@codeant-ai

codeant-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #914de Incremental review completed fe634c3 Nov 11, 2026 · 06:56 06:57
✅  #971dc Reviewed your PR fb3d5ce Nov 11, 2026 · 05:40 05:48

@codeant-ai

codeant-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:XXL This PR changes 1000+ lines, ignoring generated files label Nov 11, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@codeant-ai

codeant-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt Nitpicks

1 code suggestion

1. asked verifies only GraphQL variables, while answered() matches only method and path; a different query can pass without establishing that the response contains the queue and merge events.

Api mismatch · tests/test_release.py:520-521

@codeant-ai

codeant-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: fe634c34dc2d

@don-petry

Copy link
Copy Markdown
Contributor Author

Closed for now, to take it off the Factory's held list: the Factory held it too_large. The Kernel counts a diff as the Task carries it, with each line numbered, and by that count this was 67,308 characters against 60,000, though gh pr diff gives 57,570. The fixture goes first, alone, as #733. This pull request reopens once #733 has merged and this branch has taken main in; it then holds the test and its mutants only, 28,473 characters by the Kernel's count.

@don-petry don-petry closed this Nov 11, 2026
@don-petry don-petry reopened this Nov 11, 2026
@don-petry don-petry changed the title Slice 1's event, as GitHub answers of it: release/fixtures/event.slice-1.json (#198's ruling 6) Slice 1's event is held whole by its test and its mutants (#198's ruling 6, second of two) Nov 11, 2026
@codeant-ai codeant-ai Bot added size:L This PR changes 100-499 lines, ignoring generated files and removed size:XXL This PR changes 1000+ lines, ignoring generated files labels Nov 11, 2026
@sonarqubecloud

Copy link
Copy Markdown

@combsmith-sf-pr-review combsmith-sf-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No gating findings.

@don-petry
don-petry added this pull request to the merge queue Nov 11, 2026
Merged via the queue into main with commit 687db79 Nov 11, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L This PR changes 100-499 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants