Skip to content

P-58's deleted revision: GitHub still lists it, with its time, and a deletion moves nothing (#549) - #726

Merged
don-petry merged 5 commits into
mainfrom
trials/p58-deleted-revision-549
Nov 11, 2026
Merged

don-petry merged 5 commits into
mainfrom
trials/p58-deleted-revision-549

Conversation

@don-petry

@don-petry don-petry commented Nov 10, 2026 •

Copy link
Copy Markdown
Contributor

Closes #549.

The trial

P-58's leg that decision 0140 assumed and no trial had recorded: what GitHub answers for a description edit whose revision a person deleted from the history. Verdict: pass, on the condition written first. A second leg, on the newest revision, neither passed nor failed.

  • Where: canary pull request 101, opened and its description edited twice by the Maintainer's login. The Maintainer then deleted the revision of 20:47:01Z in the browser, by hand, at 23:02:37Z.
  • What was read: the query the facts port sends, adapters/edits.py's QUERY word for word, as the Maintainer's login: after the opening, after the two edits, before the deletion and after it. Each was answered 200 with no errors.
  • What GitHub said after the deletion: the deleted revision's node is still listed, in its place, with its editedAt, createdAt and editor as before, and its deletedAt set. Every other node is as it was. totalCount stayed 5, and lastEditedAt and editor did not move.
  • What that shows, and what it does not: the port is answered a deleted middle revision in the shape it reads, and refuses nothing. It reads 2026-11-10T20:48:14Z before the deletion and after it. But the revision deleted was a middle one with two later edits above it, so the port's time could not have moved back whatever GitHub did. Muse and the security pass both said so.
  • The newest revision's leg: its condition was written at 23:13:41Z, before it ran. The Maintainer's login edited the description once more, at 23:13:57Z, and a fifth read shows that edit as the newest. The Maintainer then looked for the deletion of that newest revision in the browser's history: GitHub offered none. That is recorded on his word; no exchange shows it.
  • What stands: seen, one middle revision deleted and still listed with its time; reported, no deletion offered for the newest. No rule of when GitHub lets a revision be deleted is drawn from the two. Nothing in the port changes.
  • Not asked: whether anything but the browser deletes a revision, the newest among them. The read through the reader App's token was not repeated: its key is the Maintainer's, and trials/P-58.reader.json found the reader answered as the Maintainer's login is.

What this holds

  • trials/P-58.deleted.json: the five exchanges, redacted.
  • sim/grounding.py: the two rules of the fake that P-58 asks name the new fixture beside the other two. The fake has no rule about a deletion, and none is added.
  • tests/test_adapters.py: one test feeds the reads before the deletion, after it and after the later edit to the port. The contract's two readings of those rules replay the new fixture and show each rule from it.
  • tools/mutants.py: one mutant, a revision deleted from the history is passed over, killed by the test decision 0140's row names.
  • The design's P-58 row and adapters/edits.py's docstring say what the leg showed, worded to a middle revision. No code changes.

No decision record: the issue asks for a rule only if a deleted node's editedAt were null, and it is not.

Removed, and undone

  • Removed from the fixture: the authorization header gh sent, on each of the five requests. The redaction also dropped 11 response headers a fixture may not keep from each capture.
  • The pass condition's wording: it was written at 2026-11-10T20:45:57Z, before anything ran. One phrase of its last sentence, "found that token answered", read to the redaction as the shape of a credential and was reworded to "found the reader answered" after the run. The condition itself is unchanged.
  • Undone in the canary: pull request 101 is closed and its branch, trial/p58-deleted-revision-549, deleted. Nothing else was made: no token, secret, label, workflow or environment.

Checks

  • python3 -m tools.check_trials: ok, before the fixture was added to git.
  • make checks: OK at d05f30c5, which is 59ab504f with main merged at 7f968f09 and the rewordings cubic asked for.
  • tests.test_adapters, 168 tests, and the fixture and grounding tests of tests.test_tools, 27 tests: OK.
  • Mutants, filtered to the edits port and the grounding: 20 of 20 killed.
  • CI at c31568e0 failed checks (0): naming the new fixture in the grounding left Contract.test_the_port_reads_each_grounded_rule_as_the_fake_assumes_it behind. Fixed in 59ab504f.

Reviews

Carbon, Muse and Astra, the Claude review and the security pass. Carbon, Muse and the two Claude reads read c31568e0; all their findings are fixed in 59ab504f. Astra read 59ab504f, after those fixes, and found nothing. Newer than Astra's read: the merge of main, and fb65053c and d05f30c5, which change words only, in the fixture's account, the design's row, a docstring and a comment. Codex: not run (quota). CodeRabbit: skipped, auto reviews are off on this repo.

cubic and CodeAnt, on 6bc4d7c4, and cubic again on fb65053c:

Finding Where What Disposition
cubic, P2 trials/P-58.deleted.json "A deletion is itself no edit" generalizes from a middle revision's deletion fixed in fb65053: the account, the design's row and the test's comment say a middle revision's deletion moved no time, and nothing of the newest's
cubic, P3 adapters/edits.py:10 The browser's offering no deletion of the newest is given as seen, and is the Maintainer's word fixed in fb65053: the docstring and the design's row say he reported it, and that no exchange shows it
cubic, P2, second read trials/P-58.deleted.json:5 The closing sentence gave a rule of when the browser deletes a revision, from one deletion and a report fixed in d05f30c: it says what was seen, what was reported with no exchange showing it, and that no rule is drawn from the two
CodeAnt, nitpick trials/P-58.deleted.json:5 The pass condition accepts any time that is no earlier, so a time moved forward by the deletion would pass declined: the condition was written before the run and is not rewritten after it. That lastEditedAt did not move is what the reads before and after recorded, which the condition lists as recorded, deciding nothing. CodeAnt's own verdict is low risk
Reviewer Head Unread parts Blocking Major Minor Info
agy c31568e none 0 0 0 0
muse c31568e none 1 1 0 0
astra 59ab504 none 0 0 0 0
claude-review c31568e none 1 0 0 1
claude-security c31568e none 0 0 1 1
Finding Severity Criterion Where What Disposition
muse#1 blocking PR-3 sim/grounding.py:26 Grounding tuples name P-58.deleted but the contract read does not, breaking test_adapters fixed in 59ab504: both readings replay P-58.deleted and show their rule from it
muse#2 major PR-1 adapters/edits.py:9 Deleted-revision trial deletes only a middle revision, leaving the post-approval newest-delete case ungrounded fixed in 59ab504: the fixture, the design's row and the docstring say a middle revision was deleted and the time could not have moved back; a second leg, its condition written first, records that the browser offered no deletion of the newest; a new mutant holds that a deleted node counts
claude-review#1 blocking PR-3 sim/grounding.py:26 The grounding names P-58.deleted for two rules, but the test that holds each grounded rule to its fixtures was not changed, and fails at this head fixed in 59ab504: both readings replay P-58.deleted and show their rule from it
claude-review#2 info none trials/P-58.deleted.json:5 The fixture's account times the read after the deletion at 23:02:55Z, and the exchange it records is dated 23:02:56 fixed in 59ab504: the read is timed by its answer's date, 23:02:56Z
claude-security#1 minor none trials/P-58.deleted.json:5 The trial deleted a middle revision, so its 'time no earlier' leg could not fail, and the one deletion the hold of 0140 depends on, the newest edit's, is not recorded fixed in 59ab504: the fixture, the design's row and the docstring say a middle revision was deleted and the time could not have moved back; a second leg, its condition written first, records that the browser offered no deletion of the newest; a new mutant holds that a deleted node counts
claude-security#2 info none trials/P-58.deleted.json:5 The pass text times the read after the deletion at 23:02:55Z, and the exchange it describes is dated 23:02:56 fixed in 59ab504: the read is timed by its answer's date, 23:02:56Z

🤖 Generated with Claude Code

…deletion moves nothing (#549)

The leg of P-58 that decision 0140 assumed: on canary pull request 101 the Maintainer deleted one revision from the description's history. The port's query, read before and after as the Maintainer's login, was answered 200 both times: the deleted revision's node stays, with its editedAt and editor and a deletedAt, and lastEditedAt, editor and the count did not move. The port reads the same time before and after, which a test now holds on the fixture. The fixture grounds the two rules of the fake that P-58 asks.

Co-Authored-By: Claude <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 10, 2026 23:10
@don-petry don-petry added the factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) label Nov 10, 2026
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown
Pre-merge checks: Passed 1 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Passed Passed checks: 1 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-10T23:10:50.529338Z
We couldn’t complete this review. Comment @codex review to try again.
c31568e PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@don-petry don-petry removed the factory:hands-off A person's mark: the Factory writes nothing on this pull request (kernel/terms.py LABEL_HANDS_OFF) label Nov 11, 2026
…eads the fixture, and the claim is worded to a middle revision (#549)

The reads of #726 found three things. The contract test that holds each grounded rule to its fixtures was left behind and failed: its two readings now replay the new fixture and show their rule from it. The trial deleted a middle revision, so the port's time could not have moved back whatever GitHub did: the fixture, the design's row and the port's docstring now say so, and a second leg, its condition written first, records that the browser offered the Maintainer no deletion of the newest revision, with the read of the edit made for it. A mutant that passes over a deleted revision is added, killed by the test decision 0140's row names. The read after the deletion is timed by its answer's date.

Co-Authored-By: Claude <noreply@anthropic.com>
@codeant-ai

codeant-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #a1825 Reviewed your PR 59ab504 Nov 11, 2026 · 02:30 02:35

@codeant-ai

codeant-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:XL This PR changes 500-999 lines, ignoring generated files label Nov 11, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread trials/P-58.deleted.json Resolved
Comment thread adapters/edits.py Resolved
@codeant-ai

codeant-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt Nitpicks

1 code suggestion

1. The pass condition accepts any non-earlier post-deletion time, so an increase caused solely by deletion still passes despite claiming deletion moves nothing.

Logic error · trials/P-58.deleted.json:5

@codeant-ai

codeant-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: 6bc4d7c4448c

…dle revision's deletion and the Maintainer's report (#549)

cubic's read of #726: the fixture said a deletion is itself no edit, which one middle revision's deletion does not show, and the docstring gave as seen what the Maintainer reported of the newest revision. The fixture's account, the design's row, the port's docstring and the test's comment now say a middle revision's deletion moved no time, and that the browser's offering no deletion of the newest is his report, which no exchange shows.

Co-Authored-By: Claude <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files (changes from recent commits).

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread trials/P-58.deleted.json Resolved
…and what was reported, and draws no rule (#549)

cubic's second read of #726: the closing sentence gave a rule of when the browser deletes a revision, from one middle revision's deletion and the Maintainer's report. It now says what was seen, what was reported with no exchange showing it, and that no rule is drawn from the two.

Co-Authored-By: Claude <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XL This PR changes 500-999 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

P-58: record what a deleted description revision returns

2 participants