Repository navigation
P-58's deleted revision: GitHub still lists it, with its time, and a deletion moves nothing (#549) - #726
Conversation
…deletion moves nothing (#549) The leg of P-58 that decision 0140 assumed: on canary pull request 101 the Maintainer deleted one revision from the description's history. The port's query, read before and after as the Maintainer's login, was answered 200 both times: the deleted revision's node stays, with its editedAt and editor and a deletedAt, and lastEditedAt, editor and the count did not move. The port reads the same time before and after, which a test now holds on the fixture. The fixture grounds the two rules of the fake that P-58 asks. Co-Authored-By: Claude <noreply@anthropic.com>
Pre-merge checks:
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…eads the fixture, and the claim is worded to a middle revision (#549) The reads of #726 found three things. The contract test that holds each grounded rule to its fixtures was left behind and failed: its two readings now replay the new fixture and show their rule from it. The trial deleted a middle revision, so the port's time could not have moved back whatever GitHub did: the fixture, the design's row and the port's docstring now say so, and a second leg, its condition written first, records that the browser offered the Maintainer no deletion of the newest revision, with the read of the edit made for it. A mutant that passes over a deleted revision is added, killed by the test decision 0140's row names. The read after the deletion is timed by its answer's date. Co-Authored-By: Claude <noreply@anthropic.com>
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
All reported issues were addressed
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
…dle revision's deletion and the Maintainer's report (#549) cubic's read of #726: the fixture said a deletion is itself no edit, which one middle revision's deletion does not show, and the docstring gave as seen what the Maintainer reported of the newest revision. The fixture's account, the design's row, the port's docstring and the test's comment now say a middle revision's deletion moved no time, and that the browser's offering no deletion of the newest is his report, which no exchange shows. Co-Authored-By: Claude <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 4 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…and what was reported, and draws no rule (#549) cubic's second read of #726: the closing sentence gave a rule of when the browser deletes a revision, from one middle revision's deletion and the Maintainer's report. It now says what was seen, what was reported with no exchange showing it, and that no rule is drawn from the two. Co-Authored-By: Claude <noreply@anthropic.com>
|



Closes #549.
The trial
P-58's leg that decision 0140 assumed and no trial had recorded: what GitHub answers for a description edit whose revision a person deleted from the history. Verdict: pass, on the condition written first. A second leg, on the newest revision, neither passed nor failed.
adapters/edits.py'sQUERYword for word, as the Maintainer's login: after the opening, after the two edits, before the deletion and after it. Each was answered 200 with no errors.editedAt,createdAtand editor as before, and itsdeletedAtset. Every other node is as it was.totalCountstayed 5, andlastEditedAtandeditordid not move.2026-11-10T20:48:14Zbefore the deletion and after it. But the revision deleted was a middle one with two later edits above it, so the port's time could not have moved back whatever GitHub did. Muse and the security pass both said so.trials/P-58.reader.jsonfound the reader answered as the Maintainer's login is.What this holds
trials/P-58.deleted.json: the five exchanges, redacted.sim/grounding.py: the two rules of the fake that P-58 asks name the new fixture beside the other two. The fake has no rule about a deletion, and none is added.tests/test_adapters.py: one test feeds the reads before the deletion, after it and after the later edit to the port. The contract's two readings of those rules replay the new fixture and show each rule from it.tools/mutants.py: one mutant, a revision deleted from the history is passed over, killed by the test decision 0140's row names.adapters/edits.py's docstring say what the leg showed, worded to a middle revision. No code changes.No decision record: the issue asks for a rule only if a deleted node's
editedAtwere null, and it is not.Removed, and undone
authorizationheaderghsent, on each of the five requests. The redaction also dropped 11 response headers a fixture may not keep from each capture.trial/p58-deleted-revision-549, deleted. Nothing else was made: no token, secret, label, workflow or environment.Checks
python3 -m tools.check_trials: ok, before the fixture was added to git.make checks: OK atd05f30c5, which is59ab504fwith main merged at7f968f09and the rewordings cubic asked for.tests.test_adapters, 168 tests, and the fixture and grounding tests oftests.test_tools, 27 tests: OK.c31568e0failedchecks (0): naming the new fixture in the grounding leftContract.test_the_port_reads_each_grounded_rule_as_the_fake_assumes_itbehind. Fixed in59ab504f.Reviews
Carbon, Muse and Astra, the Claude review and the security pass. Carbon, Muse and the two Claude reads read
c31568e0; all their findings are fixed in59ab504f. Astra read59ab504f, after those fixes, and found nothing. Newer than Astra's read: the merge of main, andfb65053candd05f30c5, which change words only, in the fixture's account, the design's row, a docstring and a comment. Codex: not run (quota). CodeRabbit: skipped, auto reviews are off on this repo.cubic and CodeAnt, on
6bc4d7c4, and cubic again onfb65053c:trials/P-58.deleted.jsonadapters/edits.py:10trials/P-58.deleted.json:5trials/P-58.deleted.json:5lastEditedAtdid not move is what the reads before and after recorded, which the condition lists as recorded, deciding nothing. CodeAnt's own verdict is low riskc31568ec31568e59ab504c31568ec31568esim/grounding.py:26adapters/edits.py:9sim/grounding.py:26trials/P-58.deleted.json:5trials/P-58.deleted.json:5trials/P-58.deleted.json:5🤖 Generated with Claude Code