Skip to content

Rulesets: main counts the machine user's approval, as the switch of 2026-11-11 left it (#198, record 0191) - #730

Merged
don-petry merged 4 commits into
mainfrom
claude/rulesets-record-the-switch
Nov 11, 2026
Merged

don-petry merged 4 commits into
mainfrom
claude/rulesets-record-the-switch

Conversation

@don-petry

@don-petry don-petry commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

This brings config/rulesets.json to the live main ruleset after the switch of "The ruleset switch: main requires the machine user's approval of the most recent commit, and slice 1's event is recorded" (#198), and records the switch as decision 0191. Part of #198; it does not close it.

What GitHub holds

On the Maintainer's choice, "Switch; Factory approves", as the Factory Builder relayed it, the Factory Builder changed ruleset 24886320 through the Maintainer's login at 02:18:03Z on 2026-11-11. Four fields changed and no other:

Field Before After
required_approving_review_count 0 1
require_code_owner_review false true
require_last_push_approval false true
dismiss_stale_reviews_on_push false true

bypass_actors stays []. I read the live ruleset after the switch: updated_at is 2026-11-10T20:18:03-06:00 and the four fields read as above. sh tools/rulesets_drift.sh reported those four fields before this change and reports no drift after it.

What was shown before the switch

"AGENTS.md: say what is built; drop the model claim no check holds" (#688), as GitHub records it on 2026-11-11:

When Event Actor
00:25:08Z Approved at head 2a60aef, by the Factory's approving act donpetry-bot
01:07:14Z Added to the merge queue don-petry
01:21:38Z Merged don-petry

The Factory's queue step did not enqueue it: the queue workflow has no run on this repo. So the Factory's review and approval are shown, and its own enqueue is not. The record says so.

What changes

  • config/rulesets.json: the four fields, and read_on 2026-11-11.
  • tests/test_tools.py:
    • test_main_counts_the_machine_users_approval_as_the_switch_left_it holds the committed record to the switch: the four fields, no required reviewer, no bypass, the ruleset's id, and a read date of the switch day or after. tools/check_rulesets.py holds how an approval is counted, and still lets through a main that counts none, so without this test the record could go back with nothing failing.
    • The Rulesets tests' run_on now carries the repo's own .github/CODEOWNERS. The check reads the code owners once main counts an approval, and test_this_repos_rulesets_agree_with_its_lenses failed without them.
  • tools/mutants.py: six mutants of config/rulesets.json, each killed by the new test: each field back, the four together, and the read date back.
  • Record 0191: the switch, what a merge now needs, what is not shown yet, what it overtakes in records 0018, 0020, 0022, 0026 and 0087, and the undo.

What it does not do

  • tools/check_rulesets.py is unchanged: it does not refuse a main that counts no approval. A check that refused it would refuse the undo's record too.
  • config/AGENTS.md is unchanged: its row on how main counts an approval already reads in the present, and the file is at its 40-line limit.
  • A comment in sim/world.py still speaks of the switch as to come. That file is protected, so it is left for a ruling.
  • The diff is 12,384 characters and 131 lines, under the Factory's review budget.
  • How a fix merges while the Release on next is broken (The ruleset switch: main requires the machine user's approval of the most recent commit, and slice 1's event is recorded #198's third box) is not shown, and the record says so.

Checks

Check Result
make checks OK
tests.test_tools.Rulesets, RulesetsDrift OK, 25 tests
Mutants of config/rulesets.json, tools/check_rulesets.py and tools/rulesets_drift.py, run alone on an export 56 of 56 killed, at 924fb48; the head differs from it in the record's words alone
sh tools/rulesets_drift.sh no drift
Full make verify Not run locally, by the Maintainer's standing change of 2026-11-09; CI's verify is the answer
Reviewer Head Unread parts Blocking Major Minor Info
agy (Carbon) d207d86 none 0 0 0 0
muse d207d86 none 1 0 0 0
astra a04c419 none 0 0 0 0
claude-review d207d86 none 0 1 1 2
claude-security d207d86 none 0 1 0 0

The head is 8fc5492. It differs from a04c419, which Astra read clean, in the record alone: its number, and the three rows a review comment on this pull request led to (below). a04c419 differs from d207d86 in the record's words, the test's read-date case and one mutant.

Finding What Disposition
muse@d207d86 #1 (blocking) The record was numbered one past a number main did not hold, so make checks failed fixed: the record is 0191. The Factory Builder ruled that numbers go in order of readiness; the Pause record, whose pull request was split, takes the next
claude-security@d207d86 #1 (major), claude-review@d207d86 #1 (major) The record said the Factory's queue step enqueued #688 with no person's act between; GitHub names don-petry as the enqueuer, and the queue workflow has never run fixed: the row says who enqueued and that the Factory's enqueue is not shown
claude-review@d207d86 #2 (minor) Records 0018, 0020, 0022, 0026 and 0087 still say main requires no review, and 0191 named only 0092 fixed: the row "What it overtakes"
claude-review@d207d86 #3 (info) Nothing held read_on fixed: the test holds it, with a mutant
cubic on 924fb48, three threads The record said every merge needs the machine user's approval, where the ruleset asks for a code owner's; the Decision table told the dry run's history; and numbers were said to need spelling out the first two fixed at 8fc5492: the row names a code owner's approval and when it is the machine user's, and the history is in the Why. The third is no change: the rule is the title and then the number after the word
claude-review@d207d86 #4 (info) The reviewer did not read the live ruleset or the time of the switch answered above: I read both

🤖 Generated with Claude Code

don-petry and others added 3 commits November 10, 2026 20:24
…026-11-11 left it (#198, record 0192)

The Factory Builder made issue 198's switch through the Maintainer's login at 02:18Z on 2026-11-11, on the
Maintainer's choice, after pull request 688 merged through the queue on the machine user's approval. Four fields of
ruleset 24886320 changed: one approval, a code owner's, of the last push, a stale one dismissed. config/rulesets.json
records GitHub's answer after it, and tools/rulesets_drift.sh, which read those four fields as drift, reads none.

A test holds the record to the switch, since tools/check_rulesets.py lets through a main that counts no approval.
The record's number is the Factory Builder's to confirm at enqueue; it follows 0191, which is pull request 728's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, and the day it was read

The security pass and the Claude review each found that the record said the Factory's queue step enqueued pull
request 688. GitHub names the Maintainer's login as the enqueuer, and the queue workflow has never run. The row now
says so, and that the Factory's own enqueue is not shown. The record names the earlier records whose words on main
it leaves behind, and the test holds the day the record was read, with a mutant.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ctory Builder's ruling)

Pull request 728, which held 0191, was split under the Factory's review budget and its record now lands last, as
0192. This record is ready first and takes 0191, so the records are numbered with no gap (Muse's read).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 11, 2026 03:13
@gemini-code-assist

Copy link
Copy Markdown

Warning

You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again!

@coderabbitai

coderabbitai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown
Pre-merge checks: Passed 1 · Inconclusive 1

Failed Failed checks: 1 inconclusive

Check name Status Explanation Resolution
Title check Pending This assessment has not completed. The check will be retried on the next pre-merge check run.
Passed Passed checks: 1 passed

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-11T03:13:08.512401Z
We couldn’t complete this review. Comment @codex review to try again.
924fb48 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codeant-ai

codeant-ai Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #eb8df Reviewed your PR 924fb48 Nov 11, 2026 · 03:13 03:16

@codeant-ai

codeant-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@codeant-ai codeant-ai Bot added the size:M This PR changes 30-99 lines, ignoring generated files label Nov 11, 2026
@codeant-ai

codeant-ai Bot commented Nov 11, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: 924fb48674af

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 4 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

…he Maintainer's pull requests

A review comment found the record said every merge needs the machine user's approval. The ruleset asks for a code
owner's, and the code owners' team holds the machine user and the Maintainer; the machine user's is the one that
counts where the Maintainer is the author, which today is every pull request. The dry run's history moves from the
Decision to the Why, and what is not shown yet is a row of its own.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@combsmith-sf-pr-review combsmith-sf-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings: the ruleset record, decision 0191, its test and mutants agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:M This PR changes 30-99 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants