Repository navigation
Rulesets: main counts the machine user's approval, as the switch of 2026-11-11 left it (#198, record 0191) - #730
Conversation
…026-11-11 left it (#198, record 0192) The Factory Builder made issue 198's switch through the Maintainer's login at 02:18Z on 2026-11-11, on the Maintainer's choice, after pull request 688 merged through the queue on the machine user's approval. Four fields of ruleset 24886320 changed: one approval, a code owner's, of the last push, a stale one dismissed. config/rulesets.json records GitHub's answer after it, and tools/rulesets_drift.sh, which read those four fields as drift, reads none. A test holds the record to the switch, since tools/check_rulesets.py lets through a main that counts no approval. The record's number is the Factory Builder's to confirm at enqueue; it follows 0191, which is pull request 728's. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…, and the day it was read The security pass and the Claude review each found that the record said the Factory's queue step enqueued pull request 688. GitHub names the Maintainer's login as the enqueuer, and the queue workflow has never run. The row now says so, and that the Factory's own enqueue is not shown. The record names the earlier records whose words on main it leaves behind, and the test holds the day the record was read, with a mutant. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ctory Builder's ruling) Pull request 728, which held 0191, was split under the Factory's review budget and its record now lands last, as 0192. This record is ready first and takes 0191, so the records are numbered with no gap (Muse's read). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Pre-merge checks:
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…he Maintainer's pull requests A review comment found the record said every merge needs the machine user's approval. The ruleset asks for a code owner's, and the code owners' team holds the machine user and the Maintainer; the machine user's is the one that counts where the Maintainer is the author, which today is every pull request. The dry run's history moves from the Decision to the Why, and what is not shown yet is a row of its own. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|



This brings
config/rulesets.jsonto the livemainruleset after the switch of "The ruleset switch: main requires the machine user's approval of the most recent commit, and slice 1's event is recorded" (#198), and records the switch as decision 0191. Part of #198; it does not close it.What GitHub holds
On the Maintainer's choice, "Switch; Factory approves", as the Factory Builder relayed it, the Factory Builder changed ruleset 24886320 through the Maintainer's login at 02:18:03Z on 2026-11-11. Four fields changed and no other:
required_approving_review_countrequire_code_owner_reviewrequire_last_push_approvaldismiss_stale_reviews_on_pushbypass_actorsstays[]. I read the live ruleset after the switch:updated_atis 2026-11-10T20:18:03-06:00 and the four fields read as above.sh tools/rulesets_drift.shreported those four fields before this change and reportsno driftafter it.What was shown before the switch
"AGENTS.md: say what is built; drop the model claim no check holds" (#688), as GitHub records it on 2026-11-11:
The Factory's queue step did not enqueue it: the queue workflow has no run on this repo. So the Factory's review and approval are shown, and its own enqueue is not. The record says so.
What changes
config/rulesets.json: the four fields, andread_on2026-11-11.tests/test_tools.py:test_main_counts_the_machine_users_approval_as_the_switch_left_itholds the committed record to the switch: the four fields, no required reviewer, no bypass, the ruleset's id, and a read date of the switch day or after.tools/check_rulesets.pyholds how an approval is counted, and still lets through amainthat counts none, so without this test the record could go back with nothing failing.run_onnow carries the repo's own.github/CODEOWNERS. The check reads the code owners oncemaincounts an approval, andtest_this_repos_rulesets_agree_with_its_lensesfailed without them.tools/mutants.py: six mutants ofconfig/rulesets.json, each killed by the new test: each field back, the four together, and the read date back.What it does not do
tools/check_rulesets.pyis unchanged: it does not refuse amainthat counts no approval. A check that refused it would refuse the undo's record too.config/AGENTS.mdis unchanged: its row on howmaincounts an approval already reads in the present, and the file is at its 40-line limit.sim/world.pystill speaks of the switch as to come. That file is protected, so it is left for a ruling.nextis broken (The ruleset switch: main requires the machine user's approval of the most recent commit, and slice 1's event is recorded #198's third box) is not shown, and the record says so.Checks
make checkstests.test_tools.Rulesets,RulesetsDriftconfig/rulesets.json,tools/check_rulesets.pyandtools/rulesets_drift.py, run alone on an export924fb48; the head differs from it in the record's words alonesh tools/rulesets_drift.shno driftmake verifyverifyis the answerd207d86d207d86a04c419d207d86d207d86The head is
8fc5492. It differs froma04c419, which Astra read clean, in the record alone: its number, and the three rows a review comment on this pull request led to (below).a04c419differs fromd207d86in the record's words, the test's read-date case and one mutant.make checksfailedmainrequires no review, and 0191 named only 0092read_on924fb48, three threads8fc5492: the row names a code owner's approval and when it is the machine user's, and the history is in the Why. The third is no change: the rule is the title and then the number after the word🤖 Generated with Claude Code