Repository navigation
The facts name the issue the Factory opened a pull request for, a fact the schema does not require (#823, first of two) - #826
Conversation
… first of two) A pull request's facts held no branch and no opener, so the Kernel could not tell a pull request the Factory opened from anyone else's. facts/1 gains opened_for: the issue adapters/acceptance.py's bound gives, or null. adapters/facts.py puts it in every snapshot. It is the one fact the schema does not require: a fact newly required needs a row in the Harness for the held-out set (decision 0105), and facts made before it are read as they stand. Nothing reads the fact yet. The second change has kernel/decide.py admit the author Role's fix only where it names an issue. sim/world.py gives every simulated pull request an issue, so that change leaves the simulator as it is; #824 has it model an item that waits for its author. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nothing here reads opened_for, so no test could hold them in this half: both Claude readers found a mutant that drops them would survive. The second pull request has kernel/decide.py read the fact, and takes the simulator's lines with their mutant. The schema's description no longer says how an absent fact is read, which is that change's to say. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every case gave issue 36, so a port that gave 36, or 1, for any pull request the Factory opened would have passed. A second branch, of another issue, and two mutants. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request introduces the opened_for field to track the issue number for which a pull request was opened by the Factory. This field is integrated into the facts snapshot, schema, examples, and tests. One piece of feedback suggests refactoring the type check in adapters/acceptance.py to use isinstance() instead of direct type comparison with is to adhere to PEP 8 guidelines.
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…he opening Runs agree (#823) cubic's read: "a person's or a builder's session's" did not parse, and "or twice" did not say that two opening Runs naming one pull request leave it untold. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|



A pull request's facts now say which issue the Factory opened it for, or that it opened it for none. Nothing reads the fact yet. First of two for "The author Role's fix is admitted only on a pull request the Factory opened: the reach of fix-findings (slice 2, S9b)" (#823); it does not close it.
Why two. The whole change came to 63,281 characters as the Kernel counts a diff, over the review budget of 60,000, so it is split as the Factory Builder ruled on 2026-11-13: the fact first, with no record, then the Kernel's rule under record 0216.
Model-Lens inputs touched: none. Protected paths touched: none. The change goes by the Factory's route.
Size. 18,192 characters and 312 lines by
git diff; 20,190 characters as the Kernel counts a diff, with its lines numbered.What changes
schemas/facts.schema.jsonopened_for: the number of the issue the Factory opened the pull request for, a whole number from 1, or nulladapters/acceptance.pyopened_forgives whatboundgives: the issue the branchfactory-work/issue-N-Knames, only where the App of the Role that opens pull requests authored the pull request on a branch of that shape in the repo itself, and every opening Run was read and none names it for another issue, or twice. Anything else is null, and whatboundcannot tell is null too, never itsFalseadapters/facts.pyexamples/tests/support.pyThe fact is the one the schema does not require. A fact newly required needs a row in
harness/eval/__init__.pyfor the held-out set, which predates it (decision 0105), and that file is a model Lens's input, approved only by a person's hand. Left optional, facts made before it are read as they stand, and the port's test holds that every snapshot gives it. The Factory Builder ruled it so; requiring it later is mechanical.Where the binding cannot tell,
complete.acceptanceis already false from the same read, so the Kernel defers.Today no Role opens pull requests, so the fact is null in every snapshot.
What is not held here
boundtakes the branch alone where no opening Run names the pull request. Decision 0097 tightens that with the writer.Checks it adds
tests/test_adapters.py::test_the_facts_name_the_issue_the_factory_opened_a_pull_request_for: the issue the branch names, of two branches, with a Run naming it or none yet; none for another account's pull request or while no Role opens; none, and neverFalse, for each thing the binding cannot tell.tests/test_adapters.py, two snapshot tests: every snapshot holds the fact, asked of the pull request as first read with the opener and the opening Runs' records.tests/test_tools.py::test_the_issue_a_pull_request_was_opened_for_is_a_number_from_1_or_null_or_left_out: what the schema takes and refuses.Checks
make checksf54932btests.test_adapters,tests.test_tools.Examples,tests.test_decide,tests.test_transitions,tests.test_controller,tests.test_evalskernel/decide.py, run alone on an exportd13a973, the first eight new ones among them; the two added since were applied by hand atf54932b, and each is killedmake verifyverifyis the answerd13a973d13a973d13a973d13a973ba78a0dAstra read the head after the others' fixes. Its finding was a gap in a test, so no one read again. Before the split, Muse, the Claude review and the security pass also read this content as part of the whole change, at
c21829fon the second pull request's branch; what they found there is in that pull request's body.ba78a0d. They are the second pull request's, with their mutant; that the simulator's worlds are all the Factory's until #824 is the Factory Builder's rulingf54932b: a second branch, of another issue, and two mutants🤖 Generated with Claude Code