Skip to content

The facts name the issue the Factory opened a pull request for, a fact the schema does not require (#823, first of two) - #826

Merged
don-petry merged 4 commits into
mainfrom
claude/opened-for-fact
Nov 13, 2026
Merged

don-petry merged 4 commits into
mainfrom
claude/opened-for-fact

Conversation

@don-petry

@don-petry don-petry commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

A pull request's facts now say which issue the Factory opened it for, or that it opened it for none. Nothing reads the fact yet. First of two for "The author Role's fix is admitted only on a pull request the Factory opened: the reach of fix-findings (slice 2, S9b)" (#823); it does not close it.

Why two. The whole change came to 63,281 characters as the Kernel counts a diff, over the review budget of 60,000, so it is split as the Factory Builder ruled on 2026-11-13: the fact first, with no record, then the Kernel's rule under record 0216.

Model-Lens inputs touched: none. Protected paths touched: none. The change goes by the Factory's route.

Size. 18,192 characters and 312 lines by git diff; 20,190 characters as the Kernel counts a diff, with its lines numbered.

What changes

Where What
schemas/facts.schema.json opened_for: the number of the issue the Factory opened the pull request for, a whole number from 1, or null
adapters/acceptance.py opened_for gives what bound gives: the issue the branch factory-work/issue-N-K names, only where the App of the Role that opens pull requests authored the pull request on a branch of that shape in the repo itself, and every opening Run was read and none names it for another issue, or twice. Anything else is null, and what bound cannot tell is null too, never its False
adapters/facts.py Every snapshot holds the fact
examples/ The example holds it; the counter-example is issue 0
tests/support.py The tests' pull request is opened for no issue

The fact is the one the schema does not require. A fact newly required needs a row in harness/eval/__init__.py for the held-out set, which predates it (decision 0105), and that file is a model Lens's input, approved only by a person's hand. Left optional, facts made before it are read as they stand, and the port's test holds that every snapshot gives it. The Factory Builder ruled it so; requiring it later is mechanical.

Where the binding cannot tell, complete.acceptance is already false from the same read, so the Kernel defers.

Today no Role opens pull requests, so the fact is null in every snapshot.

What is not held here

Checks it adds

  • tests/test_adapters.py::test_the_facts_name_the_issue_the_factory_opened_a_pull_request_for: the issue the branch names, of two branches, with a Run naming it or none yet; none for another account's pull request or while no Role opens; none, and never False, for each thing the binding cannot tell.
  • tests/test_adapters.py, two snapshot tests: every snapshot holds the fact, asked of the pull request as first read with the opener and the opening Runs' records.
  • tests/test_tools.py::test_the_issue_a_pull_request_was_opened_for_is_a_number_from_1_or_null_or_left_out: what the schema takes and refuses.
  • Ten mutants, each killed by the test it names.

Checks

Check Result
make checks OK at f54932b
tests.test_adapters, tests.test_tools.Examples, tests.test_decide, tests.test_transitions, tests.test_controller, tests.test_evals OK
Mutants of every file the change touches, and of kernel/decide.py, run alone on an export 310 of 310 killed at d13a973, the first eight new ones among them; the two added since were applied by hand at f54932b, and each is killed
Full make verify Not run locally, by the Maintainer's standing change of 2026-11-09; CI's verify is the answer
Reviewer Head Unread parts Blocking Major Minor Info
agy (Carbon) d13a973 not run (quota), owed – – – –
muse d13a973 none 0 1 0 0
claude-review d13a973 none 0 0 1 2
claude-security d13a973 none 0 0 0 1
astra ba78a0d none 0 1 0 0

Astra read the head after the others' fixes. Its finding was a gap in a test, so no one read again. Before the split, Muse, the Claude review and the security pass also read this content as part of the whole change, at c21829f on the second pull request's branch; what they found there is in that pull request's body.

Finding What Disposition
muse #1 (major), claude-review #1 (minor), security #1 (info) The simulator gave every pull request an issue, the Maintainer's and the dependency bot's among them, and nothing in this half read the fact, so no test held the two lines fixed here by taking them out: ba78a0d. They are the second pull request's, with their mutant; that the simulator's worlds are all the Factory's until #824 is the Factory Builder's ruling
claude-review #2 (info) The simulator's comment claimed more than its worlds hold, and named this issue where #824 mends it gone from this half with the lines; the second pull request's comment says they stand in until #824
claude-review #3 (info) The schema's description said an absent fact is read as null, which nothing here does fixed: the sentence is gone; the second pull request's record says how the Kernel reads absence
astra #1 (major) Every case gave issue 36, so a port that gave one number for every pull request the Factory opened would pass fixed in f54932b: a second branch, of another issue, and two mutants

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

don-petry and others added 3 commits November 13, 2026 01:46
… first of two)

A pull request's facts held no branch and no opener, so the Kernel
could not tell a pull request the Factory opened from anyone else's.
facts/1 gains opened_for: the issue adapters/acceptance.py's bound
gives, or null. adapters/facts.py puts it in every snapshot.

It is the one fact the schema does not require: a fact newly required
needs a row in the Harness for the held-out set (decision 0105), and
facts made before it are read as they stand.

Nothing reads the fact yet. The second change has kernel/decide.py
admit the author Role's fix only where it names an issue. sim/world.py
gives every simulated pull request an issue, so that change leaves the
simulator as it is; #824 has it model an item that waits for its
author.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Nothing here reads opened_for, so no test could hold them in this half:
both Claude readers found a mutant that drops them would survive. The
second pull request has kernel/decide.py read the fact, and takes the
simulator's lines with their mutant. The schema's description no longer
says how an absent fact is read, which is that change's to say.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Every case gave issue 36, so a port that gave 36, or 1, for any pull
request the Factory opened would have passed. A second branch, of
another issue, and two mutants.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 13, 2026 08:07
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codeant-ai

codeant-ai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #751cf Reviewed your PR f54932b Nov 13, 2026 · 08:07 08:10

@codeant-ai

codeant-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T08:22:44.030733Z e55bac8 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the opened_for field to track the issue number for which a pull request was opened by the Factory. This field is integrated into the facts snapshot, schema, examples, and tests. One piece of feedback suggests refactoring the type check in adapters/acceptance.py to use isinstance() instead of direct type comparison with is to adhere to PEP 8 guidelines.

Comment thread adapters/acceptance.py Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread schemas/facts.schema.json Resolved
@codeant-ai

codeant-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: f54932b7b35b

…he opening Runs agree (#823)

cubic's read: "a person's or a builder's session's" did not parse, and
"or twice" did not say that two opening Runs naming one pull request
leave it untold.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@don-petry
don-petry added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 00260a3 Nov 13, 2026
33 checks passed
@don-petry
don-petry deleted the claude/opened-for-fact branch November 13, 2026 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants