Repository navigation
A change that touches only paths a person decides waits under its own code, path_needs_person (#746, record 0207) - #797
Conversation
… code, path_needs_person (#746) The Kernel is given the person-only paths as a list of their own beside model_lens_inputs, and names the wait by it: path_needs_person where such paths are all the change touches of either list, and model_lens_input_needs_person wherever it touches a model Lens's input. A list that is not there or is misshapen is protected_paths_unreadable. The feed asks a person under the path's own question. The record follows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…alone, and record 0207 (#746) The Factory Builder's ruling: a path on both lists waits as model_lens_input_needs_person, the stricter name. One function, controller/configuration.py::person_only, builds the list for the Controller, the simulator and the tests, leaving off any path a model Lens reads. Record 0207 says what is decided and names each boundary's test and mutants. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…iven apart, and a rename out of a person-only path has its mutant (#746) The security pass and the Claude review: no test gave a model Lens's input beside a person-only path that model_lens_inputs leaves off, so three mutants of the line that joins the two survived. One case and four mutants. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rn, and the rename mutant is valid Python (#746) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
Code Review
This pull request implements Decision 0207, introducing a distinct 'path_needs_person' wait reason for changes that only touch paths decided by a person and not read by any model Lens. The changes span configuration loading, kernel derivation logic, feed definitions, and extensive test updates. The feedback suggests a minor improvement in kernel/derive.py to use parentheses for line continuation instead of a backslash, aligning with PEP 8 guidelines.
… Lens's input from being named a person's path (#746) The Factory Builder's ruling: accepted as built, the residual named in the record, the change not widened. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
3 issues found and verified against the latest diff
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="controller/configuration.py">
<violation number="1" location="controller/configuration.py:46">
P3: `person_only` re-implements the person-only filter that `protected.model_inputs_of` already applies. Expose the persons half from `tools/hooks/protected.py` and call it from here, so a later change to one cannot leave the other behind.</violation>
</file>
<file name="docs/decisions/0207-a-change-that-touches-only-paths-a-person-decides-waits-under-its-own-code.md">
<violation number="1" location="docs/decisions/0207-a-change-that-touches-only-paths-a-person-decides-waits-under-its-own-code.md:12">
P2: The Controller reads `config/hooks.json` separately for each derived list, despite this decision requiring one consistent read. Load the hooks once and derive `protected_paths`, `model_lens_inputs`, and `person_only_paths` from that object.</violation>
<violation number="2" location="docs/decisions/0207-a-change-that-touches-only-paths-a-person-decides-waits-under-its-own-code.md:12">
P2: `person_only_paths` is filtered by exact pattern strings, so overlapping patterns can leave a model-Lens-readable file classified as person-only. Filter person-only entries using the same pattern-overlap semantics as `kernel/derive.matches`, not only string equality.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fce2ce7932
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…g patterns are held to the Lens's code (#746) cubic's threads on pull request 797: config/hooks.json was read once for each list; it is read once. And a person-only path inside a model Lens's input, or around one, was said to be masked: the Kernel matches the change against both lists, so it is not, and a test now shows both ways. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
1 issue found and verified against the latest diff
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="docs/decisions/0207-a-change-that-touches-only-paths-a-person-decides-waits-under-its-own-code.md">
<violation number="1" location="docs/decisions/0207-a-change-that-touches-only-paths-a-person-decides-waits-under-its-own-code.md:13">
P2: This row documents the wrong precedence for overlapping lists: it says `person_only_paths` wins, while the decision and implementation contract require `model_lens_input_needs_person` to win whenever both lists contain the path. State the overlap rule explicitly and reserve `path_needs_person` for person-only matches that are not Lens inputs.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…/hooks.json (#746) cubic's thread on pull request 797: the row read as if the person-only list won where a path is on both. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
|
Mutants of every file this change touches, run alone on an export of |



A change that touches only paths a person decides now waits under its own code,
path_needs_person, and the feed asks a person under the path's own question. Until now it waited asmodel_lens_input_needs_person, though no Lens reads such a path: record 0200 said so and left the name for a change of its own. Closes #746.Model-Lens inputs touched: none.
tools/hooks/protected.pyandconfig/hooks.jsonare as they were, so the change goes by the Factory's route.Protected edits, pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder (2026-11-13):
config/feed.json: one row, the question asked for the new reason.sim/world.py: the simulator's Kernel is given the list. The Builder approved one line; it is three, an import, the list and a word in the comment above it, because the list is now built by one function shared with the Controller (below).Size. 52,711 characters and 616 lines by
git diff; 56,629 characters as the Kernel counts a diff, with its lines numbered, against a budget of 60,000.The record is 0207, the number the Factory Builder gave. Records 0203 to 0206 are on
mainsince 2026-11-13, andmainis merged in at7fdf73b, so the numbers have no gap andmake checkspasses.What changes
kernel/derive.pyperson_only_paths. A change whose every touched path, of the two lists, is on it waits aspath_needs_person; one that touches a model Lens's input as well keepsmodel_lens_input_needs_person. The evidence names every touched path of either list, the Lenses' inputs first, each once. A list that is not there, or is misshapen, isprotected_paths_unreadable; one that names none is readkernel/decide.pypath_needs_personneeds a person's eyescontroller/configuration.pyconfig/hooks.jsononce for its three lists, andperson_onlybuilds the new one from that reading: each person-only path that no model Lens reads, once. The Controller, the simulator and the tests' Kernel all take it from thereconfig/feed.jsona_path_needs_you, choices approve or closeexamples/decision.path-needs-person.jsondocs/decisions/0207-…Who ends the wait is unchanged: a person with write access other than the author and the last pusher, as 0052 and 0200 have it. In the merge queue without one the change is taken out.
A path on both lists. None is today. Were a path listed both as a model Lens's input and as a person's, it is left off
person_only_paths, so its change waits as a Lens's input does. That is the Factory Builder's ruling: a model Lens's input is the stricter name and is never masked.From when. From the first Release cut after this merges; until then the Release on
nextnames the wait as 0200 has it.What is not held, and what is left alone
controller/configuration.py, its test and its mutants. The file is neither a protected path nor a model Lens's input, so a later change to it alone needs no person's approval. Only the name and the question asked could be lost that way, never the wait or who ends it. The Factory Builder accepted it as built on 2026-11-13; whether the file should be one a person must approve is a separate decision, and the record's row "What is still not held" names it. (The security pass's note.).claude/skills/cut-a-release/SKILL.mdnamesmodel_lens_input_needs_personfor a change to a model Lens's input, which is still true; it says nothing of a person-only path. Its section is held word for word by a digest.Checks it adds
tests/test_decide.py: the person-only wait under its own code, of any class and the Maintainer's own, in the queue, by a rename, by a pattern; the mixed change; the two lists given apart; a list that cannot be read; the feed's row and the example.tests/test_controller.py: the Controller gives the list of the checkout it runs from; a path a model Lens reads is never given as a person's alone.tests/test_tools.py: the tests' Kernel and the simulator's are given the same list.tests/test_transitions.py: facts for the new reason.Checks
make checks7fdf73b,mainmerged intests.test_decide,tests.test_controller.Feed,tests.test_tools.TheList,tests.test_tools.Examples,tests.test_transitionsd752db8; the one was the rename mutant's own syntax, fixed since. The person-only, Lens's-input and Controller mutants again at3a2d100, after the last change to code: 102 of 102. At7fdf73b, after the merge ofmain, they run again; the result is a comment heremake verifyverifyis the answer91733ca91733ca91733ca91733cad752db8Astra read the head after the others' fixes. Every finding acted on was a gap in a test or a mutant, so none read again.
make checksfailsmainis merged inmodel_lens_inputsleaves off; three mutants of the line that joins the two survived, one of them masking the Lens's inputp == pathsurvivedReview threads, six, all resolved
kernel/derive.pycontinues a long condition this way three times on mainconfig/hooks.jsononce for each list3a2d100: one reading for all three3a2d100: the Kernel matches a change against both lists, and a test holds a person-only path inside a Lens's input, and around onetools/hooks/protected.py93f63f8: the rule was right; the row now says which pair of lists it speaks of🤖 Generated with Claude Code