Skip to content

A change that touches only paths a person decides waits under its own code, path_needs_person (#746, record 0207) - #797

Merged
don-petry merged 11 commits into
mainfrom
claude/person-only-reason
Nov 13, 2026
Merged

don-petry merged 11 commits into
mainfrom
claude/person-only-reason

Conversation

@don-petry

@don-petry don-petry commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

A change that touches only paths a person decides now waits under its own code, path_needs_person, and the feed asks a person under the path's own question. Until now it waited as model_lens_input_needs_person, though no Lens reads such a path: record 0200 said so and left the name for a change of its own. Closes #746.

Model-Lens inputs touched: none. tools/hooks/protected.py and config/hooks.json are as they were, so the change goes by the Factory's route.

Protected edits, pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder (2026-11-13):

  • config/feed.json: one row, the question asked for the new reason.
  • sim/world.py: the simulator's Kernel is given the list. The Builder approved one line; it is three, an import, the list and a word in the comment above it, because the list is now built by one function shared with the Controller (below).

Size. 52,711 characters and 616 lines by git diff; 56,629 characters as the Kernel counts a diff, with its lines numbered, against a budget of 60,000.

The record is 0207, the number the Factory Builder gave. Records 0203 to 0206 are on main since 2026-11-13, and main is merged in at 7fdf73b, so the numbers have no gap and make checks passes.

What changes

Where What
kernel/derive.py The Kernel reads a second list, person_only_paths. A change whose every touched path, of the two lists, is on it waits as path_needs_person; one that touches a model Lens's input as well keeps model_lens_input_needs_person. The evidence names every touched path of either list, the Lenses' inputs first, each once. A list that is not there, or is misshapen, is protected_paths_unreadable; one that names none is read
kernel/decide.py path_needs_person needs a person's eyes
controller/configuration.py The Controller reads config/hooks.json once for its three lists, and person_only builds the new one from that reading: each person-only path that no model Lens reads, once. The Controller, the simulator and the tests' Kernel all take it from there
config/feed.json The row for the new reason: question a_path_needs_you, choices approve or close
examples/decision.path-needs-person.json The Decision's example, which a test holds to the Kernel's own answer
docs/decisions/0207-… What is decided, and each boundary's test and mutants

Who ends the wait is unchanged: a person with write access other than the author and the last pusher, as 0052 and 0200 have it. In the merge queue without one the change is taken out.

A path on both lists. None is today. Were a path listed both as a model Lens's input and as a person's, it is left off person_only_paths, so its change waits as a Lens's input does. That is the Factory Builder's ruling: a model Lens's input is the stricter name and is never masked.

From when. From the first Release cut after this merges; until then the Release on next names the wait as 0200 has it.

What is not held, and what is left alone

  • What keeps a model Lens's input from being named a person's path is controller/configuration.py, its test and its mutants. The file is neither a protected path nor a model Lens's input, so a later change to it alone needs no person's approval. Only the name and the question asked could be lost that way, never the wait or who ends it. The Factory Builder accepted it as built on 2026-11-13; whether the file should be one a person must approve is a separate decision, and the record's row "What is still not held" names it. (The security pass's note.)
  • The skill is not changed. .claude/skills/cut-a-release/SKILL.md names model_lens_input_needs_person for a change to a model Lens's input, which is still true; it says nothing of a person-only path. Its section is held word for word by a digest.

Checks it adds

  • tests/test_decide.py: the person-only wait under its own code, of any class and the Maintainer's own, in the queue, by a rename, by a pattern; the mixed change; the two lists given apart; a list that cannot be read; the feed's row and the example.
  • tests/test_controller.py: the Controller gives the list of the checkout it runs from; a path a model Lens reads is never given as a person's alone.
  • tests/test_tools.py: the tests' Kernel and the simulator's are given the same list.
  • tests/test_transitions.py: facts for the new reason.
  • 28 mutants, each named in the record's boundary rows.

Checks

Check Result
make checks OK at 7fdf73b, main merged in
tests.test_decide, tests.test_controller.Feed, tests.test_tools.TheList, tests.test_tools.Examples, tests.test_transitions OK
Mutants of every file the change touches, run alone on an export 689 of 690 killed at d752db8; the one was the rename mutant's own syntax, fixed since. The person-only, Lens's-input and Controller mutants again at 3a2d100, after the last change to code: 102 of 102. At 7fdf73b, after the merge of main, they run again; the result is a comment here
Full make verify Not run locally, by the Maintainer's standing change of 2026-11-09; CI's verify is the answer
Reviewer Head Unread parts Blocking Major Minor Info
agy (Carbon) 91733ca not run (quota), owed – – – –
muse 91733ca none 1 0 0 0
claude-review 91733ca none 0 0 1 1
claude-security 91733ca none 0 0 1 1
astra d752db8 none 0 1 1 0

Astra read the head after the others' fixes. Every finding acted on was a gap in a test or a mutant, so none read again.

Finding What Disposition
muse #1 (blocking) Record 0207 leaves a gap in the numbers, and make checks fails gone: the four before it merged, and main is merged in
security #1, claude-review #1 No test gave a model Lens's input beside a person-only path that model_lens_inputs leaves off; three mutants of the line that joins the two survived, one of them masking the Lens's input fixed: one case with the lists given apart, and the three mutants
claude-review #2 (info) A rename out of a person-only path had a test and no mutant fixed: the mutant
security #2 (info) The rule that a Lens's input is never masked rests on a file no person need approve accepted as built by the Factory Builder; named in the record's row "What is still not held"
astra #1 (major) No test held that a person-only path is matched as a pattern: p == path survived fixed: a directory, a star and their other sides, with the list given apart, and the mutant
astra #2 (minor) The rename mutant lacked its newline, and was a syntax error rather than a change of behaviour fixed

Review threads, six, all resolved

Thread Disposition
gemini: wrap the condition in parentheses, not with a backslash not changed: kernel/derive.py continues a long condition this way three times on main
cubic: the Controller reads config/hooks.json once for each list fixed in 3a2d100: one reading for all three
cubic: overlapping patterns could leave a model Lens's file a person's not so, and shown in 3a2d100: the Kernel matches a change against both lists, and a test holds a person-only path inside a Lens's input, and around one
cubic: expose the person-only half from tools/hooks/protected.py not changed, by the Factory Builder's ruling: that file is a model Lens's input
codex: the record leaves a gap in the numbers gone, as said at the top
cubic: the record's row gave the wrong precedence where a path is on both lists reworded in 93f63f8: the rule was right; the row now says which pair of lists it speaks of

🤖 Generated with Claude Code

don-petry and others added 7 commits November 12, 2026 19:23
… code, path_needs_person (#746)

The Kernel is given the person-only paths as a list of their own beside model_lens_inputs, and names the wait
by it: path_needs_person where such paths are all the change touches of either list, and
model_lens_input_needs_person wherever it touches a model Lens's input. A list that is not there or is misshapen
is protected_paths_unreadable. The feed asks a person under the path's own question. The record follows.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…alone, and record 0207 (#746)

The Factory Builder's ruling: a path on both lists waits as model_lens_input_needs_person, the stricter name.
One function, controller/configuration.py::person_only, builds the list for the Controller, the simulator and
the tests, leaving off any path a model Lens reads. Record 0207 says what is decided and names each boundary's
test and mutants.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…iven apart, and a rename out of a person-only path has its mutant (#746)

The security pass and the Claude review: no test gave a model Lens's input beside a person-only path that
model_lens_inputs leaves off, so three mutants of the line that joins the two survived. One case and four mutants.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…rn, and the rename mutant is valid Python (#746)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 13, 2026 02:17
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codeant-ai

codeant-ai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #24199 Incremental review completed 7fdf73b Nov 13, 2026 · 12:57 12:57
✅  #1f079 Reviewed your PR fce2ce7 Nov 13, 2026 · 02:17 02:24

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 13, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-13T13:02:45.764029Z 7fdf73b New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codeant-ai

codeant-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements Decision 0207, introducing a distinct 'path_needs_person' wait reason for changes that only touch paths decided by a person and not read by any model Lens. The changes span configuration loading, kernel derivation logic, feed definitions, and extensive test updates. The feedback suggests a minor improvement in kernel/derive.py to use parentheses for line continuation instead of a backslash, aligning with PEP 8 guidelines.

Comment thread kernel/derive.py Resolved
… Lens's input from being named a person's path (#746)

The Factory Builder's ruling: accepted as built, the residual named in the record, the change not widened.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3 issues found and verified against the latest diff

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="controller/configuration.py">

<violation number="1" location="controller/configuration.py:46">
P3: `person_only` re-implements the person-only filter that `protected.model_inputs_of` already applies. Expose the persons half from `tools/hooks/protected.py` and call it from here, so a later change to one cannot leave the other behind.</violation>
</file>

<file name="docs/decisions/0207-a-change-that-touches-only-paths-a-person-decides-waits-under-its-own-code.md">

<violation number="1" location="docs/decisions/0207-a-change-that-touches-only-paths-a-person-decides-waits-under-its-own-code.md:12">
P2: The Controller reads `config/hooks.json` separately for each derived list, despite this decision requiring one consistent read. Load the hooks once and derive `protected_paths`, `model_lens_inputs`, and `person_only_paths` from that object.</violation>

<violation number="2" location="docs/decisions/0207-a-change-that-touches-only-paths-a-person-decides-waits-under-its-own-code.md:12">
P2: `person_only_paths` is filtered by exact pattern strings, so overlapping patterns can leave a model-Lens-readable file classified as person-only. Filter person-only entries using the same pattern-overlap semantics as `kernel/derive.matches`, not only string equality.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread controller/configuration.py Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fce2ce7932

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…g patterns are held to the Lens's code (#746)

cubic's threads on pull request 797: config/hooks.json was read once for each list; it is read once. And a
person-only path inside a model Lens's input, or around one, was said to be masked: the Kernel matches the change
against both lists, so it is not, and a test now shows both ways.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@codeant-ai

codeant-ai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: 7fdf73b7a2c9

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found and verified against the latest diff

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="docs/decisions/0207-a-change-that-touches-only-paths-a-person-decides-waits-under-its-own-code.md">

<violation number="1" location="docs/decisions/0207-a-change-that-touches-only-paths-a-person-decides-waits-under-its-own-code.md:13">
P2: This row documents the wrong precedence for overlapping lists: it says `person_only_paths` wins, while the decision and implementation contract require `model_lens_input_needs_person` to win whenever both lists contain the path. State the overlap rule explicitly and reserve `path_needs_person` for person-only matches that are not Lens inputs.</violation>
</file>

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

don-petry and others added 2 commits November 12, 2026 20:27
…/hooks.json (#746)

cubic's thread on pull request 797: the row read as if the person-only list won where a path is on both.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@sonarqubecloud

Copy link
Copy Markdown

@combsmith-sf-pr-review combsmith-sf-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No gating findings: the path_needs_person wait, its configuration list, feed row, example, tests and mutants hold.

@don-petry

Copy link
Copy Markdown
Contributor Author

Mutants of every file this change touches, run alone on an export of 7fdf73b after main was merged in: 740 of 740 killed.

@don-petry
don-petry added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 032d01c Nov 13, 2026
33 checks passed
@don-petry
don-petry deleted the claude/person-only-reason branch November 13, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The reason a person-only path waits is named for itself, not as a model Lens's input

2 participants