Repository navigation
A change that touches only paths a person decides waits under its own code, path_needs_person (#746, record 0207) #797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
c68c508
A change that touches only paths a person decides waits under its own…
don-petry 6888eae
The transition tests are given facts for path_needs_person (#746)
don-petry 7e80ccc
A path a model Lens reads is never given to the Kernel as a person's …
don-petry 91733ca
Merge remote-tracking branch 'origin/main' into claude/person-only-re…
don-petry d752db8
The readers' findings: the evidence is held where the two lists are g…
don-petry 8b7f7e6
Astra's findings: a person-only path is held to be matched as a patte…
don-petry fce2ce7
Merge remote-tracking branch 'origin/main' into claude/person-only-re…
don-petry 36b100d
Record 0207 names what is still not held: the file that keeps a model…
don-petry 3a2d100
The Controller takes its three lists from one reading, and overlappin…
don-petry 93f63f8
Record 0207 tells the Kernel's two lists from the two lists of config…
don-petry 7fdf73b
Merge remote-tracking branch 'origin/main' into claude/person-only-re…
don-petry File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
34 changes: 34 additions & 0 deletions
34
...7-a-change-that-touches-only-paths-a-person-decides-waits-under-its-own-code.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| # 0207. A change that touches only paths a person decides waits under its own code | ||
|
don-petry marked this conversation as resolved.
Resolved
|
||
|
|
||
| Status: accepted. Decided for "The reason a person-only path waits is named for itself, not as a model Lens's input" (issue 746). It amends two rows of `docs/decisions/0200-a-path-only-a-person-decides-is-listed-apart-from-a-lenss-inputs-and-a-change-to-it-needs-a-persons-approval.md`. "The code it waits in" kept `model_lens_input_needs_person` for a person-only path; for a change that touches no model Lens's input it no longer does. "How the Kernel is told" said the Kernel changes by no line; it now reads a second list. The rest of both rows stands, and so does every other row of 0200. | ||
|
|
||
| ## Decision | ||
|
|
||
| | What | Decided | Because | | ||
| |---|---|---| | ||
| | The code | A change waits in `verifying` as `path_needs_person` where every path it touches, of the two lists below, is one only a person decides. The evidence names each such path as the configuration has it, once | No Lens reads such a path, and the code a person is shown said one did. The wait and who ends it were already right | | ||
| | Beside a model Lens's input | A change that touches a model Lens's input as well keeps `model_lens_input_needs_person`. Its evidence names every path of either list that it touches, the Lenses' inputs first, each once | A Decision has one reason. Of the two, the Lens's says that what judges a change has itself changed, which is the more a person must know; the path stands beside it in the evidence | | ||
| | Who ends the wait | As 0052 and 0200 have it, for both codes: a person with write access other than the author and the last pusher approves the head. One approval ends both. In the merge queue without one the change is taken out | Only the name changes | | ||
| | How the Kernel is told | It is given a second list, `person_only_paths`: each path of `person_only` in `config/hooks.json` that no model Lens reads, once, from the one reading `tools/hooks/protected.py` makes of that file. `controller/configuration.py::person_only` builds it, for the Controller, the simulator and the tests alike, and the Controller takes all three of its lists from one reading. `model_lens_inputs` is given as 0200 has it, the person-only paths after a model Lens's own | `tools/hooks/protected.py` and `config/hooks.json` are a model Lens's inputs, and neither changes here: the reading already returns both lists. One function for the three that tell a Kernel leaves nothing to drift | | ||
| | The Kernel's two lists | The two lists the Kernel is given overlap by design: `model_lens_inputs` holds every person-only path at its end (0200), so each is on both. The Kernel therefore takes a path for a person's by `person_only_paths` alone, and for a model Lens's input where it is on `model_lens_inputs` and not on that list. A path on `person_only_paths` waits for a person even were `model_lens_inputs` given without it. What keeps a model Lens's own input off `person_only_paths` is the next row | Were the two ever given apart, the wait must not be lost with the name, and a list that leaves a path out errs to the Lens's code, the stricter | | ||
| | A path on both lists of `config/hooks.json` | No path is listed there both as a model Lens's input and as a person's today. Were one, it is left off `person_only_paths`, so a change to it waits as `model_lens_input_needs_person` | A model Lens's input is the stricter and the more specific reason (0052), and is never to be masked by the other (the Factory Builder's ruling of 2026-11-13) | | ||
| | A list that cannot be read | `person_only_paths` not there, or not a list of patterns in the shape every path has, is `protected_paths_unreadable`: the item defers for the Maintainer, and leaves the merge queue. A list that names none is read | A configuration from before 0200 names none. One that says nothing of the list could be hiding one, and a fact that cannot be read is never taken for its default (I-13) | | ||
| | What a person is asked | `config/feed.json` gains the row `path_needs_person`: the question `a_path_needs_you`, and the choices of a model Lens's input, approve or close | `tools/check_examples.py` asks a row of every reason that needs a person | | ||
| | What is still not held | That a model Lens's input is never named a person's path rests on `controller/configuration.py`, its test and its mutants. That file is neither a protected path nor a model Lens's input, so a later change to it alone is judged by the model Lens, with no person's approval. Only the name and the question asked could be lost that way, never the wait or who ends it. Whether the file is to be listed as one a person must approve is a separate decision, not made here | This repo holds a rule by its test and its mutants, and this one is held so (the Factory Builder's ruling of 2026-11-13). Listing the file is a change to `config/hooks.json`, by the Maintainer's hand | | ||
| | From when | From the first Release cut after this record merges. Until then the Release on `next` names the wait as 0200 has it | The Kernel and the Controller that tells it ride one Release | | ||
|
|
||
| ## Why | ||
|
|
||
| 0200 put the Maintainer's decision file under the rule for a model Lens's input without a new rule in the Kernel, and said plainly that the code was then narrower than what it held. The person who must act reads the code and the question it maps to, and both told him a Lens's input had changed when none had. The Kernel already matched the change against the list; it needed only to be told which of those paths are a person's. | ||
|
|
||
| ## Boundaries | ||
|
|
||
| | Boundary | Check | | ||
| |---|---| | ||
| | A change that touches only person-only paths waits for a person as `path_needs_person`, of any class and the Maintainer's own, with the path as evidence; it needs a person's eyes; in the merge queue without one it is taken out; either list alone holds the wait and the person-only list names it; the feed asks under the path's own question with the choices of a model Lens's input; and the Decision's example is the Kernel's own | `tests/test_decide.py::test_a_change_to_a_path_only_a_person_decides_waits_for_a_person`, `kernel/derive.py`, `kernel/decide.py`, `config/feed.json`, `examples/decision.path-needs-person.json`; mutant: "a change to a person-only path alone is named a model Lens's input"; mutant: "a person-only path off the model Lenses' list waits for no one"; mutant: "a rename out of a person-only path is not read"; mutant: "a person-only path is matched as a whole name, never as a pattern"; mutant: "a change to a person-only path is nobody's to see"; mutant: "the feed asks of a person-only path what it asks of a model Lens's input"; mutant: "the feed offers a person no approval of a change to a person-only path"; mutant: "the example of a person-only path's Decision is a model Lens's input's" | | ||
| | Beside a model Lens's input the change keeps `model_lens_input_needs_person`, in the queue too, with every touched path of either list as evidence, the Lenses' first and each once; one person's approval ends both waits; and a model Lens's input alone is never named a person's path, nor is a path the change leaves alone named | `tests/test_decide.py::test_the_wait_is_named_for_a_model_lenss_input_wherever_the_change_touches_one`, `tests/test_decide.py::test_a_change_to_a_model_lenss_own_input_waits_for_a_person`, `kernel/derive.py`; mutant: "a change to a model Lens's input beside a person-only path is named for the path"; mutant: "a change to a model Lens's input is named a person-only path"; mutant: "a path on both lists is named in the evidence twice"; mutant: "a model Lens's input beside a person-only path off its list is dropped, and the change named for the path"; mutant: "a person-only path is named in the evidence before a model Lens's input"; mutant: "a person-only path off the model Lenses' list is left out of the evidence beside a Lens's input"; mutant: "a person-only path named twice is in the evidence twice"; mutant: "every person-only path is taken as changed" | | ||
| | A list of person-only paths that is not there, is no list, or holds a pattern of no readable shape defers for the Maintainer as `protected_paths_unreadable` and leaves the queue; a list that names none is read | `tests/test_decide.py::test_an_unreadable_list_of_person_only_paths_defers_for_the_maintainer`, `kernel/derive.py`; mutant: "a list of person-only paths that is not there is read as none"; mutant: "a list of person-only paths that is no list is read"; mutant: "a person-only path of no readable shape is read"; mutant: "a configuration that names no person-only path cannot be read" | | ||
| | The Controller gives the Kernel the person-only paths of the checkout it runs from, each once, and none where the file has no such list | `tests/test_controller.py::test_the_kernel_is_given_the_paths_only_a_person_decides_from_the_releases_own_list`, `controller/configuration.py`; mutant: "the Controller gives the Kernel no person-only path"; mutant: "the Controller gives the Kernel the lists of the session's checkout, not the Release's"; mutant: "the Controller leaves no model Lens's input off the person-only paths" | | ||
| | A path a model Lens reads is left off the person-only paths, whoever lists it as a person's, so its change waits as a Lens's input does; a path only a deterministic Lens reads is not left off; and no path is on both lists today | `tests/test_controller.py::test_a_path_a_model_lens_reads_is_never_given_as_a_persons_alone`, `controller/configuration.py`; mutant: "a path a model Lens reads is given to the Kernel as a person's alone"; mutant: "a path any Lens reads is left off the person-only paths"; mutant: "a person-only path listed twice is given to the Kernel twice" | | ||
| | The tests' Kernel and the simulator's are given the same list, as `config/hooks.json` has it | `tests/test_tools.py::test_the_kernel_is_given_the_paths_only_a_person_decides`, `sim/world.py`; mutant: "the simulator's Kernel is given no person-only path" | | ||
| | Every reason that needs a person has its row in the feed | `tests/test_tools.py::test_every_reason_that_needs_a_person_says_what_is_asked`, `config/feed.json`; mutant: "the feed asks nothing of a change to a person-only path" | | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| "schema": "decision/1", | ||
| "item": { | ||
| "repo": "combsmith/software-factory", | ||
| "type": "pull_request", | ||
| "number": 42 | ||
| }, | ||
| "state": "verifying", | ||
| "reason": "path_needs_person", | ||
| "evidence": [ | ||
| "release/decision-points.json" | ||
| ], | ||
| "attention": "needs_you", | ||
| "outcome": "nothing" | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.