Skip to content

A push past a Lens's review asks it again while its thread gates, and a thread its later review dropped is the Kernel's to resolve (#833, record 0212) - #859

Merged
don-petry merged 8 commits into
mainfrom
kernel/lens-rereview-releases-thread-833
Nov 13, 2026
Merged

don-petry merged 8 commits into
mainfrom
kernel/lens-rereview-releases-thread-833

Conversation

@don-petry

@don-petry don-petry commented Nov 13, 2026 •

Copy link
Copy Markdown
Contributor

Closes #833.

What was wrong

Since the reviewer's account was listed as a Lens, each blocking or major Finding it posts holds its pull request until a person resolves the thread. Two things kept it there.

What this changes

  • A push that keeps the diff asks the review again. While a required model Lens's own thread gates and still stands, a push after that Lens's last review of this content began answers verifying, awaiting_review. The Run ceiling bounds it.
  • The port says which thread a later review dropped. adapters/applied.py marks a Lens's thread dropped where every Run that recorded it is one a later review of that Lens supersedes, by decision 0075's own matching: the thread's id in the Runs' records, never a comment's text. facts/1 gains the optional word.
  • The Kernel reads it only for a newer head. kernel/derive.py takes the word only where the thread opened before the last push and the run records hold a review by that Lens that succeeded on this content and began after that push. Then the thread is the Kernel's resolve_thread act, adjudicating, resolve_due, as an expired Run's thread is, and the queue App's resolution or a person's closes it.
  • What is never closed this way: a security Finding's thread, one whose category the Kernel does not know, and one its Lens last ruled rejected. The Kernel also never names a security Finding's thread in the act, whatever ruling the facts carry.
  • kernel/gate.py and harness/ are untouched. The gate already closes a Lens's thread the queue App resolved once it carries the superseded mark, which decision 0125 put there.
  • Record 0212 rules it, with the slice-1 rule for carrying the act out by hand, by the Factory Builder's ruling of 2026-11-13; L-17 and the design each gain a sentence.

What it does not do

Checked at this desk

At ae636efa, the head: tests.test_decide, tests.test_adapters, tests.test_transitions, tests.test_controller, tests.test_harness, tests.test_steps, tests.test_reconcile and tests.test_effects, 609 tests; make checks, every check ok but the record's number, which waits on record 0211; the change's mutants and the ones on the rules it touches, 34 of 34 killed; no mutant stale; gitleaks, no leaks. The simulator on 40 seeds, at f675f05a: 46 of 49 pass, and the three that fail are the seeds' coverage tests, which fail the same way on main at 40 seeds and pass here on the full set. 58,598 characters as the Kernel counts, from a local diff. CI verifies.

Reviews

Two rounds. The first read 3e9204b2; the change was reworked for it, and Kimi and Astra read the rework, f675f05a. No reader has read ae636efa, the head, which answers the second round: two Run-time guards, one more case in each test and two mutants swapped.

  • Kimi: 2 findings, 1 taken. Both on its second read; its first was clean.
  • Astra: 2 findings on each read, all four taken.
  • Claude review and Claude security read 3e9204b2. A second Claude security read, of f675f05a, had not answered when this opened: what it finds I answer in a comment.
  • Carbon: not run (quota). Owed.
  • Muse: not run (quota). Owed.

First round, of 3e9204b2

Reviewer Head Unread parts Blocking Major Minor Info
kimi 3e9204b none 0 0 0 0
astra 3e9204b none 0 2 0 0
claude-review 3e9204b none 0 1 5 2
claude-security 3e9204b none 0 1 6 0
Finding Severity Criterion Where What Disposition
astra#1 major PR-5 docs/lessons.md:104 The named check does not hold the hand-resolution security restriction fixed in f675f05: the Kernel never names a security Finding's thread in the act, whatever ruling the facts carry, and the invariant test tries security with an accepted ruling. What a hand does with the act is held by no check: issue 854, named in the record
astra#2 major PR-5 kernel/derive.py:125 The dropped-thread path lacks an unreadable-review-time boundary mutant fixed in f675f05: a review whose start is no time bears nothing out, tried in the test, with the mutant "a review at no time that can be read bears a dropped thread out"
claude-review#1 major PR-5 docs/lessons.md:104 L-17's new rule on a session's hand act names a test that holds what the Kernel names, not what the session does so: the record and L-17 now say a test holds what the act may name and no check holds the hand's part, which is issue 854
claude-review#2 minor none docs/architecture/software-factory-design.md:552 The design's new sentence says a dropped thread asks the review again; the code asks for a thread that still stands fixed in f675f05: only a category the Kernel knows, and not security, is read as dropped; resolved by the queue App, such a thread is thread_unreadable as on main, tried for a null category and an unknown word
claude-review#3 minor none docs/lessons.md:102 L-17's Rule line, and gate.py's closed() docstring, still say a Lens's thread closes only in the three older ways fixed in f675f05 for all three: a run list that is none, a record that is none and a start that is no time are each tried; the last has a mutant, the first two are held by the test alone, to keep the change inside the review budget
claude-review#4 minor PR-3 kernel/derive.py:121 A dropped thread whose category cannot be read is taken as no security Finding, so the queue App's resolution closes it not in this change: issue 855 holds the simulator, the explorer, tests/support.py and the example, and the record's row "The fake" says so. sim/world.py and tests/test_simulator.py are protected, and the change is at the review budget
claude-review#5 minor PR-3 kernel/derive.py:121 Three guards of dropped_by_review are held by no test: with each removed the Kernel raises where it now defers fixed in f675f05: the design's sentence names the thread a review of a newer head no longer records, and no longer says such a thread asks a review
claude-review#6 minor none schemas/facts.schema.json:358 Neither new rule is under the seeded simulation or the transitions explorer, and the new fact is in the schema alone fixed in f675f05 for L-17, which says the queue App's resolution also closes such a thread; kernel/gate.py's docstring is a protected file's and is left, in issue 856
claude-review#7 info none docs/decisions/0212-a-push-past-a-lenss-review-asks-it-again-while-its-thread-gates-and-a-thread-its-later-review-dropped-is-the-kernels-to-resolve.md:1 Record number 0212 is also the number on the pushed head of the open pull request 816 not this change's: _wanted_run admits the first required Lens whatever the evidence names. The two-Lens case is no longer in the test, to keep the change inside the review budget; the configuration requires one. Noted in issue 855
claude-review#8 info PR-3 tests/test_decide.py:1170 The two-Lens case asserts the evidence only: the Decision admits the other Lens, and the item runs to the Run ceiling so: the sealed ledger's record, pull request 816, moves to 0220 by the Factory Builder's ruling, renumbered on its branch and pushed after this opens
claude-security#1 major PR-5 docs/lessons.md:104 The slice-1 rule for a session resolving a thread by hand names a test that holds what the act names, not what a session does so: the record and L-17 now say no check holds the hand's part; issue 854 asks for one, and notes that the comment renews the Run ceiling
claude-security#2 minor PR-3 adapters/applied.py:194 A thread its Lens ruled rejected after the review that dropped it is still said dropped, and the Kernel resolves it fixed in f675f05: a thread is read as dropped only where it opened before the last push and the review began after that push, so a Run that failed and is tried again on the same head drops nothing. That a re-review is given none of its Lens's open Findings is issue 856, named in the record
claude-security#3 minor none docs/decisions/0212-a-push-past-a-lenss-review-asks-it-again-while-its-thread-gates-and-a-thread-its-later-review-dropped-is-the-kernels-to-resolve.md:11 A thread is closed on the silence of one more independent sample, with no push and no change: a failed Run's thread is dropped by its own retry fixed in f675f05, the safe way: a thread whose Lens's latest ruling is rejected is never read as dropped, whichever came later
claude-security#4 minor PR-5 docs/decisions/0212-a-push-past-a-lenss-review-asks-it-again-while-its-thread-gates-and-a-thread-its-later-review-dropped-is-the-kernels-to-resolve.md:30 The record's last boundary says the act names only an accepted or a dropped thread of no security Finding; it also names an expired Run's thread, whose category cannot be read fixed in f675f05: as claude-review#2
claude-security#5 minor PR-3 kernel/derive.py:121 A dropped thread whose category cannot be read is closed by the queue App's resolution, where a security Finding's is not fixed in f675f05: a push at no time that can be read asks no review and bears nothing out, tried in both rules, each with a mutant. A push dated later than every Run still asks a review a pass, to the Run ceiling
claude-security#6 minor PR-3 kernel/derive.py:162 pushed_past_review compares last_push_at without reading it as a time: one that is none raises, and one later than every Run admits a review at each pass fixed in f675f05: the record says a hand never resolves an expired Run's thread, whose category cannot be read, and the invariant test tries the expired case
claude-security#7 minor none sim/world.py:941 The simulator's world never says a thread dropped, and its own check still holds resolve_thread to an accepted ruling not in this change: issue 855, as claude-review#4

Second round, of f675f05a

Reviewer Head Unread parts Blocking Major Minor Info
kimi f675f05 none 0 2 0 0
astra f675f05 none 0 2 0 0
Finding Severity Criterion Where What Disposition
kimi#1 major PR-5 docs/decisions/0212-a-push-past-a-lenss-review-asks-it-again-while-its-thread-gates-and-a-thread-its-later-review-dropped-is-the-kernels-to-resolve.md:16 The new manual-resolve permission explicitly leaves its write preconditions unchecked so: the Factory Builder ruled the slice-1 rule and the test that holds what the act may name. The record and L-17 say no check holds the hand's part, and issue 854 asks for one. Not taken as a change here
kimi#2 major PR-3 kernel/derive.py:125 The completed-Run condition for a dropped thread has no killing test or mutant fixed in 7382891: a review still running bears nothing out, tried in the test, with the mutant "a review still running bears a dropped thread out"
astra#1 major PR-3 kernel/derive.py:165 Unreadable Run start times are compared as valid timestamps fixed in ae636ef: a Run whose start is no time answers no push, tried in the test, with the mutant "a review at no time that can be read answers the push". A start that is none is the run records', which the Kernel sorts before this, as on main
astra#2 major PR-5 tests/test_decide.py:1304 The resolve-thread oracle accepts unreadable facts on an accepted ruling fixed in ae636ef: the matrix asserts thread_unreadable for a word that is no yes or no, whatever the ruling. The mutant the finding names was run by hand and fails that test; it is not added to the list, to stay inside the review budget

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

don-petry and others added 6 commits November 13, 2026 11:46
… a thread its later review dropped is the Kernel's to resolve (#833, record 0212)

The port says which Lens thread a later review of its Lens superseded, by issue 347's
matching; the Kernel holds that word to the run records and answers resolve_due, as it
does for an expired Run's thread, never for a security Finding's. A push that leaves
the diff as it was asks the Lens's review again while its own thread gates.

Co-Authored-By: Claude <noreply@anthropic.com>
…view, and the act never names a security Finding's thread

The security read, Astra and the Claude review of 3e9204b: a Run that failed and is tried
again on the same head drops nothing; a thread of a category the Kernel does not know, or
that its Lens ruled rejected, is not closed; a push that cannot be dated asks nothing; a
word the records do not bear out gates as any thread does. The record says what no check
holds yet, and names the issues that hold it.

Co-Authored-By: Claude <noreply@anthropic.com>
…-level ones, to fit the review budget

Co-Authored-By: Claude <noreply@anthropic.com>
Kimi's read of f675f05.

Co-Authored-By: Claude <noreply@anthropic.com>
… is no yes or no is unreadable whatever the ruling

Astra's read of f675f05. The two-Lens case and its mutant go, to keep the change inside
the review budget: the configuration requires one model Lens.

Co-Authored-By: Claude <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 13, 2026 18:31
@coderabbitai

coderabbitai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-13T18:31:15.333783Z
We couldn’t complete this review. Comment @codex review to try again.
ae636ef PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codeant-ai

codeant-ai Bot commented Nov 13, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #b1c80 Reviewed your PR ae636ef Nov 13, 2026 · 18:31 18:41

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

@codeant-ai

codeant-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request implements decision 0212, which handles pushes past a Lens's review and marks threads dropped by a later review as superseded so they can be resolved by the Kernel. The changes span thread processing logic in adapters/applied.py and kernel/derive.py, schema updates, documentation, and comprehensive unit tests. The review feedback recommends improving the robustness of the dictionary parsing in kernel/derive.py by using safe .get() accessors and type checks to prevent potential KeyError or TypeError exceptions.

Comment thread kernel/derive.py Resolved
Comment thread kernel/derive.py Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment •

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 9 files

Reply with feedback, questions, or to request a fix.

View guided diff | Turn on auto-fix | Re-trigger cubic

Comment thread docs/lessons.md Resolved
don-petry and others added 2 commits November 13, 2026 12:36
…ign's sentence carries the decision's conditions

cubic's read of ae636ef.

Co-Authored-By: Claude <noreply@anthropic.com>
@don-petry

Copy link
Copy Markdown
Contributor Author

Second Claude security read, of f675f05a: 1 minor, 1 info; no blocking, no major. It checked the rework against the first read's seven findings and found each answer holds.

Finding Severity What Disposition
claude-security (2nd) #1 minor A dropped thread a hand resolved stays closed after the next push, where the queue App's resolution would stand again: after a push back to earlier content, that content is approved on the review that raised the Finding Not a change here. It is the hand's part, which no check holds: the row is added to "No check holds the hand's part of resolving a Lens's thread in slice 1: nothing notices a resolution the Kernel's act did not name" (#854), with the case as run
claude-security (2nd) #2 info The act never names a security Finding's thread now, but kernel/gate.py still closes one the queue App resolved on an accepted ruling Not this change's, and the file is protected: noted in "A re-review is given none of its Lens's open Findings, so a thread closes on the silence of one more review" (#856). The port gives a security Finding's thread no ruling, so nothing reaches it

Since opening, two pushes: 693a1c00 answers cubic's two wording points (L-17's line and the design's sentence), and cd3935cb merges main, which now holds record 0211. At cd3935cb: make checks, every check ok; tests.test_decide, tests.test_adapters, tests.test_controller and tests.test_reconcile, 495 tests; no mutant stale; gitleaks, no leaks.

🤖 Generated with Claude Code

@sonarqubecloud

Copy link
Copy Markdown

@codeant-ai

codeant-ai Bot commented Nov 13, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: cd3935cb6e58

@combsmith-sf-pr-review combsmith-sf-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings: the dropped-thread reading and the re-review after a push hold, and tests and mutants cover them.

@don-petry
don-petry added this pull request to the merge queue Nov 13, 2026
Merged via the queue into main with commit 4e58ba4 Nov 13, 2026
33 checks passed
@don-petry
don-petry deleted the kernel/lens-rereview-releases-thread-833 branch November 13, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

A gating thread the reviewer opens is closed only by a person's hand: no Role answers it, no Intent rules on it and no queue App resolves it

2 participants