Repository navigation
A push past a Lens's review asks it again while its thread gates, and a thread its later review dropped is the Kernel's to resolve (#833, record 0212) - #859
Conversation
… a thread its later review dropped is the Kernel's to resolve (#833, record 0212) The port says which Lens thread a later review of its Lens superseded, by issue 347's matching; the Kernel holds that word to the run records and answers resolve_due, as it does for an expired Run's thread, never for a security Finding's. A push that leaves the diff as it was asks the Lens's review again while its own thread gates. Co-Authored-By: Claude <noreply@anthropic.com>
…view, and the act never names a security Finding's thread The security read, Astra and the Claude review of 3e9204b: a Run that failed and is tried again on the same head drops nothing; a thread of a category the Kernel does not know, or that its Lens ruled rejected, is not closed; a push that cannot be dated asks nothing; a word the records do not bear out gates as any thread does. The record says what no check holds yet, and names the issues that hold it. Co-Authored-By: Claude <noreply@anthropic.com>
…-level ones, to fit the review budget Co-Authored-By: Claude <noreply@anthropic.com>
Kimi's read of f675f05. Co-Authored-By: Claude <noreply@anthropic.com>
… is no yes or no is unreadable whatever the ruling Astra's read of f675f05. The two-Lens case and its mutant go, to keep the change inside the review budget: the configuration requires one model Lens. Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
Code Review
This pull request implements decision 0212, which handles pushes past a Lens's review and marks threads dropped by a later review as superseded so they can be resolved by the Kernel. The changes span thread processing logic in adapters/applied.py and kernel/derive.py, schema updates, documentation, and comprehensive unit tests. The review feedback recommends improving the robustness of the dictionary parsing in kernel/derive.py by using safe .get() accessors and type checks to prevent potential KeyError or TypeError exceptions.
There was a problem hiding this comment.
All reported issues were addressed across 9 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…ign's sentence carries the decision's conditions cubic's read of ae636ef. Co-Authored-By: Claude <noreply@anthropic.com>
…releases-thread-833
|
Second Claude security read, of
Since opening, two pushes: 🤖 Generated with Claude Code |
|



Closes #833.
What was wrong
Since the reviewer's account was listed as a Lens, each blocking or major Finding it posts holds its pull request until a person resolves the thread. Two things kept it there.
main. That push left the diff as it was, so the content id did not change, the Kernel read the review as done, and the pull request stayedaddressing,findings_openfor two hours. A push that changes the diff was already reviewed again.What this changes
verifying,awaiting_review. The Run ceiling bounds it.adapters/applied.pymarks a Lens's threaddroppedwhere every Run that recorded it is one a later review of that Lens supersedes, by decision 0075's own matching: the thread's id in the Runs' records, never a comment's text.facts/1gains the optional word.kernel/derive.pytakes the word only where the thread opened before the last push and the run records hold a review by that Lens that succeeded on this content and began after that push. Then the thread is the Kernel'sresolve_threadact,adjudicating,resolve_due, as an expired Run's thread is, and the queue App's resolution or a person's closes it.kernel/gate.pyandharness/are untouched. The gate already closes a Lens's thread the queue App resolved once it carries thesupersededmark, which decision 0125 put there.What it does not do
resolve_threadis not built ("A narrow queue App, combsmith-sf-queue, enqueues and dequeues with contents and pull-request write alone (P-2)", A narrow queue App, combsmith-sf-queue, enqueues and dequeues with contents and pull-request write alone (P-2) #381), so the pass records the actnot_built. Until it exists a session may resolve the thread by hand, only where the Controller's check on the current head saysresolve_duenaming it, never a security Finding's or an expired Run's, and with a comment naming the pass.kernel/gate.py's docstring, a protected file's.sim/world.pyis protected and the change is at the review budget.Checked at this desk
At
ae636efa, the head:tests.test_decide,tests.test_adapters,tests.test_transitions,tests.test_controller,tests.test_harness,tests.test_steps,tests.test_reconcileandtests.test_effects, 609 tests;make checks, every check ok but the record's number, which waits on record 0211; the change's mutants and the ones on the rules it touches, 34 of 34 killed; no mutant stale; gitleaks, no leaks. The simulator on 40 seeds, atf675f05a: 46 of 49 pass, and the three that fail are the seeds' coverage tests, which fail the same way onmainat 40 seeds and pass here on the full set. 58,598 characters as the Kernel counts, from a local diff. CI verifies.Reviews
Two rounds. The first read
3e9204b2; the change was reworked for it, and Kimi and Astra read the rework,f675f05a. No reader has readae636efa, the head, which answers the second round: two Run-time guards, one more case in each test and two mutants swapped.3e9204b2. A second Claude security read, off675f05a, had not answered when this opened: what it finds I answer in a comment.First round, of
3e9204b23e9204b3e9204b3e9204b3e9204bdocs/lessons.md:104kernel/derive.py:125docs/lessons.md:104docs/architecture/software-factory-design.md:552docs/lessons.md:102kernel/derive.py:121kernel/derive.py:121schemas/facts.schema.json:358docs/decisions/0212-a-push-past-a-lenss-review-asks-it-again-while-its-thread-gates-and-a-thread-its-later-review-dropped-is-the-kernels-to-resolve.md:1_wanted_runadmits the first required Lens whatever the evidence names. The two-Lens case is no longer in the test, to keep the change inside the review budget; the configuration requires one. Noted in issue 855tests/test_decide.py:1170docs/lessons.md:104adapters/applied.py:194docs/decisions/0212-a-push-past-a-lenss-review-asks-it-again-while-its-thread-gates-and-a-thread-its-later-review-dropped-is-the-kernels-to-resolve.md:11docs/decisions/0212-a-push-past-a-lenss-review-asks-it-again-while-its-thread-gates-and-a-thread-its-later-review-dropped-is-the-kernels-to-resolve.md:30kernel/derive.py:121kernel/derive.py:162sim/world.py:941Second round, of
f675f05af675f05f675f05docs/decisions/0212-a-push-past-a-lenss-review-asks-it-again-while-its-thread-gates-and-a-thread-its-later-review-dropped-is-the-kernels-to-resolve.md:16kernel/derive.py:125kernel/derive.py:165tests/test_decide.py:1304🤖 Generated with Claude Code