You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
A narrow queue App, combsmith-sf-queue, enqueues and dequeues with contents and pull-request write alone (P-2) #381
Under #182. Trial P-2 failed as written, and this issue carries out the Maintainer's decision on it (2026-10-28).
The evidence (trials/P-2.least.json, the second machine-user window, canary pull request 57)
The pr-review App, with every permission it holds (contents read, pull_requests write, checks write, and the reads), was refused both enqueuePullRequest and dequeuePullRequest: FORBIDDEN, "Resource not accessible by integration".
The trial-author App, narrowed to pull_requests: write, was refused both; with contents: write beside it, it enqueued 57 and took it out again, and the Maintainer's reads between saw 57 queued, then out, its approval standing.
The Controller's read saw a queued pull request with metadata: read alone (so read:facts.queue is mapped to it).
An App uses the merge queue only with contents: write, which no reviewer's App may hold.
The decision: a new, narrow App for the queue
The App: combsmith-sf-queue, holding contents: write and pull_requests: write and nothing else, no events, installed on the selected repos the other Apps are.
Its key: in an environment of its own, factory-queue, secret QUEUE_APP_KEY, read only by the step that writes the queue; tools/check_apps.py's job map gains that holder.
Its use: only tightly shaped steps the Kernel decides: an enqueue of the commit the Kernel admitted, and a dequeue it orders. No other write.
config/apps.json: the App's entry, its app_id and installation waiting on the Maintainer's registration and trial P-39 read again; effect:enqueue_merge and effect:dequeue_merge re-pointed from "the Maintainer's grant of contents: write" to this App, held there once registered.
Later, pending the Maintainer's confirmation: the same App may resolve a review thread on a Lens's recorded ruling (P-5 found an App resolves another's thread only with contents: write, the same gate). Not built here.
Done when
The App is registered and read by P-39; config/apps.json names it and maps the two Effects to it; its environment holds its key alone; tools/check_apps.py holds its job and environment; the queue's writes are made through it, each a boundary test and a mutant.
The step that resolves a Lens's thread (issue 389, decision 0083) is not wired to land anything until its dispatched run records count each landed resolution toward max_acts_per_item, read whole from the run records at every call, with a boundary test and a mutant. Until then the Controller records the act not_built, so none goes uncounted.
Window 3 (2026-10-29): the queue App's least permission is contents: write
combsmith-sf-queue (App 5519382, installation 176376387) ran all three of its acts on the canary, each token narrowed to contents: write and metadata: read alone. GitHub granted exactly those in every mint, and each act did what it was asked:
Act
Canary pull request
What GitHub did
Resolve another's thread
70: a person's thread and two of the trial-author App's
Each resolved, resolvedBycombsmith-sf-queue[bot] (User, databaseId 349593770)
Enqueue
70, approved, threads resolved
Queued at 02:24:59Z, AddedToMergeQueueEvent actor combsmith-sf-queue; the queue merged it at 02:34:42Z, MergedEvent actor combsmith-sf-queue
Enqueue, then dequeue
72, approved
Queued at 12:07:01Z, removed at 12:07:05Z, reason manual, actor combsmith-sf-queue; unmerged
Every refusal the window met was about the pull request's state, never permission. P-2.least's FORBIDDEN, "Resource not accessible by integration", did not appear once:
an enqueue before the code owner's approval: "Waiting on code owner review from combsmith/org-leads";
an enqueue with a thread open: "A conversation must be resolved before this pull request can be merged";
a dequeue of a pull request not queued: "Failed to remove PR".
So the three acts map to contents: write. pull_requests: write serves none of them, and the Maintainer removes it from the App. P-39 then reads the App again, and config/apps.json names it with effect:enqueue_merge, effect:dequeue_merge and the resolve act. Least permission was asked by ruling (a), 2026-10-29.
Also read:factory-queue deploys from main alone, can_admins_bypass false, and holds QUEUE_APP_KEY and nothing else (2026-10-29T01:24:17Z).
The fixtures follow in the trials lane's next pull request.
Activity
A person's gate is read before the resolve act (#389)
don-petry commentedon Oct 29, 2026
Window 3 (2026-10-29): the queue App's least permission is
contents: writecombsmith-sf-queue(App 5519382, installation 176376387) ran all three of its acts on the canary, each token narrowed tocontents: writeandmetadata: readalone. GitHub granted exactly those in every mint, and each act did what it was asked:resolvedBycombsmith-sf-queue[bot](User, databaseId 349593770)AddedToMergeQueueEventactorcombsmith-sf-queue; the queue merged it at 02:34:42Z,MergedEventactorcombsmith-sf-queuemanual, actorcombsmith-sf-queue; unmergedEvery refusal the window met was about the pull request's state, never permission. P-2.least's FORBIDDEN, "Resource not accessible by integration", did not appear once:
So the three acts map to
contents: write.pull_requests: writeserves none of them, and the Maintainer removes it from the App. P-39 then reads the App again, andconfig/apps.jsonnames it witheffect:enqueue_merge,effect:dequeue_mergeand the resolve act. Least permission was asked by ruling (a), 2026-10-29.Also read:
factory-queuedeploys frommainalone,can_admins_bypassfalse, and holdsQUEUE_APP_KEYand nothing else (2026-10-29T01:24:17Z).The fixtures follow in the trials lane's next pull request.
🤖 Addressed by Claude Code
A Lens judges, and the queue App resolves its thread as the Kernel's …
The queue App holds the resolve act, and each resolution it lands cou…
Each queue act is a dispatched Run of the queue workflow, once it is …
The queue step reads the pull request again with the queue App's toke…
The queue act's job holds the queue App's key, the job's reads and th…