Repository navigation
The texts port reads what a Lens said on each of its own review threads, and never an edited comment (#856) - #884
Conversation
…ds asked for (#856) A later review can rule on a Finding only if it is shown what its Lens said. adapters/texts.py gains findings: the first comment of each review thread asked for, read by the thread's id and held to this pull request and to that Lens's own account. What is not that, or cannot be read whole, raises. No caller asks yet: handing a re-review its open Findings is the Harness's, in a hand PR. Co-Authored-By: Claude <noreply@anthropic.com>
… has its test (#856) GitHub's author is who made a comment, not who wrote what it holds now: a first comment that was edited, or that GitHub does not say never was, is refused. A field not given proves nothing, so a reply and an edit are each read by an explicit null. An answer that is not what GraphQL gives raises Unanswered, never an AttributeError. The test states the query word for word, and holds the status guard, the list guard and the id's length. From the readers' findings. Co-Authored-By: Claude <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request introduces the ability to retrieve a Lens's comments on its own review threads by adding the findings function in adapters/texts.py along with a GraphQL query, and includes comprehensive unit tests in tests/test_adapters.py. The review feedback recommends several readability improvements in findings, such as renaming the threads parameter to avoid shadowing the imported module, simplifying the duplicate check, and replacing non-idiomatic .get(..., 0) is not None checks with explicit membership and nullness checks.
There was a problem hiding this comment.
All reported issues were addressed across 4 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
…est's (#856) GitHub's answer is held to a whole number before it is compared: Python reads 26.0 and true as equal to a number. From cubic's read. Co-Authored-By: Claude <noreply@anthropic.com>
…bove gives a line for it (#856) The rule stopped waiting when texts.py left the not-built list, and no row named its tests. The four prose lines are three, so the file stays at its 40. From the Factory reviewer's Finding. Co-Authored-By: Claude <noreply@anthropic.com>
…keeps three lines (#856) Co-Authored-By: Claude <noreply@anthropic.com>
|
|
Resolving the reviewer's thread 🤖 Generated with Claude Code |



Part of #856: step 1 of the three the Factory Builder ruled on 2026-11-14, the Maintainer's choice "Full fix, keep auto-release".
What is wrong
"A re-review is given none of its Lens's open Findings, so a thread closes on the silence of one more review" (#856). A review is handed no Finding its Lens raised before, so a later review that says nothing of one has not ruled on it. Since "A push past a Lens's review asks it again while its thread gates, and a thread its later review dropped is the Kernel's to resolve (#833, record 0212)" (#859), live on
factory/v0.1.13, that silence releases the thread.The fix has three steps. This is the first: the read. Nothing changes at run time until the second.
What this changes
adapters/texts.pygainsfindings. It reads what a Lens said on each review thread a caller asks for, by the thread's id, as{id, by, body}with the idthread:and the thread's id: a text as an issue's body is, which a Task carries under its writer's trust. It is never a fact, a decision or a code.adapters/timeline.Accountstells it; never edited; and a body that is text.lastEditedAt, the Lens's own edit included, raises.Unanswered, so that no Task lists a Finding it does not show. A list that is no list, names a thread twice, holds an id of no thread's form or is longer than 50 raises before anything is asked of GitHub.What it does not do
harness/read.pyhands a re-review its Lens's open Findings,harness/apply.pyrefuses a Result with no disposition on a Finding it was shown, and the reviewer's instructions ask for one.harness/is a model Lens's input, so that pull request is the Maintainer's to approve.lastEditedAtfor a description, not for a review comment. I asked GitHub the query word for word, once, as the Maintainer's login, for the reviewer's thread on "Trial P-66, a queued pull request: once the base it waits on moves into conflict with it, the queue takes it out unmerged (Trial: what does the merge queue answer to an enqueue of a head that conflicts with its base? #812)" (Trial P-66, a queued pull request: once the base it waits on moves into conflict with it, the queue takes it out unmerged (#812) #847): it answered aPullRequestReviewThreadwith its pull request,replyTonull,lastEditedAtnull and the author aBotwith its id. An edited review comment's answer I have not seen. The test states the query word for word, so a change to it is a change to a test.harness/task.py's: a Lens's text ranks before an issue's there, and a text over the room left is left out whole. Step 2 must count a Finding as shown only where its text was kept.Checked at this desk
At
9b796a12:tests.test_adapters, 184 tests;make checks, every check ok; the change's 22 mutants, all killed, and no mutant stale of 7,611; gitleaks, no leaks. 314 lines and 27,956 characters as the Kernel counts them, under the 60,000 of the review budget. CI verifies.Reviews
Astra (max): 3 findings, 3 taken. Kimi (max): 1 finding, 1 taken. Carbon: 4 findings, 4 taken. Claude security: 5 findings, 5 taken. Muse: not run (quota), owed. Each read
0b2e8c32; none has read the fixes at9b796a12.lastEditedAtis asked for and an edited comment raises, with two mutantsreplyTois accepted as proof of an opening commentdataorrepositorythat is a string raisesAttributeError, notUnansweredadapters/AGENTS.mdno longer namestexts.py🤖 Generated with Claude Code