Skip to content

With two model Lenses, the review admitted is the one the evidence names (#855) - #882

Merged
don-petry merged 2 commits into
mainfrom
kernel/second-lens-awaited-855
Nov 14, 2026
Merged

don-petry merged 2 commits into
mainfrom
kernel/second-lens-awaited-855

Conversation

@don-petry

@don-petry don-petry commented Nov 14, 2026 •

Copy link
Copy Markdown
Contributor

Part of #855: its third point, which the review of #859 found beside it.

What. With two model Lenses required, kernel/decide.py's _wanted_run admitted the first whatever Lens awaiting_review named. So once the first had reviewed, an item whose second Lens was asked would run the first again, to the Run ceiling.

Record. None, unless the Factory Builder rules one: the rule, admit the review the State awaits, is unchanged, and this mends its reading for a second Lens.

Tests and mutants.

  • tests/test_decide.py::test_with_two_model_lenses_the_one_awaited_is_the_one_admitted failed first, as the issue says: the evidence named the second Lens, and pr-review was admitted again. It passes now.
  • The mutant "the first model Lens is admitted whatever the evidence names" is new, and "the act ceiling stops a Run" follows the new call.
  • All 105 mutants of kernel/decide.py are killed. tests.test_decide, tests.test_transitions and tests.test_issue pass, and so does make checks.

Readers (head ff5043a):

Reader Findings Disposition
Claude review 1 minor Taken in f1b0ee6: the guard on a Lens the configuration does not require could not be reached through go(), and was tested only by a direct call to the private _wanted_run. Both go, and the test calls the Kernel through go() alone
Claude security 1 minor The same, taken
Carbon (gemini-4-carbon-high) none —
Astra (gpt-6-astra) none —
Kimi (kimi-k3.1-pro) Kimi: 0 findings, 0 taken —

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

don-petry and others added 2 commits November 14, 2026 08:20
…mes (#855)

_wanted_run admitted the first model Lens whatever Lens awaiting_review named, so an item whose second Lens was
asked again would run the first to the Run ceiling. It now admits the Lens the evidence names, and none the
configuration does not require. The default configuration requires one model Lens, so nothing changes live.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s, and the test calls the Kernel through go() alone

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 14, 2026 14:27
@coderabbitai

coderabbitai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codeant-ai

codeant-ai Bot commented Nov 14, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #8eae7 Reviewed your PR f1b0ee6 Nov 14, 2026 · 14:27 14:29

@codeant-ai

codeant-ai Bot commented Nov 14, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 14, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-14T14:32:39.680085Z f1b0ee6 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the _wanted_run function in kernel/decide.py to accept an evidence list and use its first element to determine the active lens for review, addressing issue 855 where multiple model lenses are required. A corresponding unit test has been added to verify this behavior. The review feedback suggests adding a defensive check to prevent a potential IndexError or TypeError if the evidence list is empty or None when accessing evidence[0].

Comment thread kernel/decide.py Resolved
@sonarqubecloud

Copy link
Copy Markdown

@codeant-ai

codeant-ai Bot commented Nov 14, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: f1b0ee6bc1f6

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@don-petry
don-petry added this pull request to the merge queue Nov 14, 2026
Merged via the queue into main with commit f557d25 Nov 14, 2026
33 checks passed
@don-petry
don-petry deleted the kernel/second-lens-awaited-855 branch November 14, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants