Repository navigation
With two model Lenses, the review admitted is the one the evidence names (#855) - #882
Conversation
…mes (#855) _wanted_run admitted the first model Lens whatever Lens awaiting_review named, so an item whose second Lens was asked again would run the first to the Run ceiling. It now admits the Lens the evidence names, and none the configuration does not require. The default configuration requires one model Lens, so nothing changes live. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…s, and the test calls the Kernel through go() alone Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Review
This pull request updates the _wanted_run function in kernel/decide.py to accept an evidence list and use its first element to determine the active lens for review, addressing issue 855 where multiple model lenses are required. A corresponding unit test has been added to verify this behavior. The review feedback suggests adding a defensive check to prevent a potential IndexError or TypeError if the evidence list is empty or None when accessing evidence[0].
|



Part of #855: its third point, which the review of #859 found beside it.
What. With two model Lenses required,
kernel/decide.py's_wanted_runadmitted the first whatever Lensawaiting_reviewnamed. So once the first had reviewed, an item whose second Lens was asked would run the first again, to the Run ceiling.Record. None, unless the Factory Builder rules one: the rule, admit the review the State awaits, is unchanged, and this mends its reading for a second Lens.
Tests and mutants.
tests/test_decide.py::test_with_two_model_lenses_the_one_awaited_is_the_one_admittedfailed first, as the issue says: the evidence named the second Lens, andpr-reviewwas admitted again. It passes now.kernel/decide.pyare killed.tests.test_decide,tests.test_transitionsandtests.test_issuepass, and so doesmake checks.Readers (head ff5043a):
go(), and was tested only by a direct call to the private_wanted_run. Both go, and the test calls the Kernel throughgo()alone🤖 Generated with Claude Code