Repository navigation
The simulator and the explorer push a head that leaves the diff as it was, and the world says a thread dropped (#855) - #888
Conversation
… was, and the world says a thread dropped (#855) - sim/world.py: a person's push now and then keeps the content (a_push_can_leave_the_diff_as_it_was, grounded by trials/P-29.base.json, where the content is the hash of the pull request's own diff alone). A Lens's later review now and then drops a thread opened before it. The check on the act takes a dropped thread as an accepted one, and I-11 allows a review asked again on unchanged content once the head was pushed past it while its Lens's thread stands. - tests/test_transitions.py: the explorer's push may keep the diff; from addressing it takes the item to verifying, and once the checks pass a gating Lens is asked again on the same content. - examples/facts.json and tests/support.py carry the dropped fact; the port's reading grounds the new rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…w of the current content, I-11 yields only to a gating thread that asks for the review, and the world refuses each dropped thread the Kernel may not resolve - A push of new content clears every dropped word; the drop is the port's word of a review on the content it replaced. - I-11 lets a Lens be reviewed again on unchanged content only for a gating thread of its own, not accepted and not dropped since the push. - A direct test holds each clause of dropped_since_the_push, with a mutant on each; the seeds test reads each step's own lines and asks every push that kept the diff to have kept the content. - The grounding says why P-29 stands for a push it did not make; the explorer's case keeps a diff unlike the default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… a word that is no yes or no Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
There was a problem hiding this comment.
Code Review
This pull request introduces the concept of a push that leaves a pull request's diff unchanged (such as a merge of the base branch that does not touch any of the PR's files) and models the behavior where a Lens's review can drop a thread. It updates the simulation logic in sim/world.py to handle these scenarios, including checking if a thread was dropped since the last push and allowing a second review of unchanged content under specific conditions. Corresponding tests and examples have been added to validate these transitions. The review feedback suggests improving code readability in sim/world.py by replacing backslash line continuations with PEP 8-compliant implicit line continuations inside parentheses.



Closes #855: its first two points. The third, the two-Lens admission, merged as #882.
What. The seeded simulation and the transitions explorer now make the two things the fix for #833 added rules for, which only unit tests held before.
sim/world.py: a person's push now and then keeps the content. The new GitHub rulea_push_can_leave_the_diff_as_it_wasis grounded bytrials/P-29.base.json; the statement says why P-29 stands for a push it did not make.tests/test_transitions.py: the explorer's push may keep the diff. Fromaddressingit takes the item toverifying, and once the checks pass a gating Lens is asked again on the same content.examples/facts.jsonandtests/support.pycarry the dropped fact, with its counter-example.Record. None: no Kernel rule changes.
Protected edits.
sim/world.pyandtests/test_simulator.py: pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder (assignment 2026-11-14).Seeds pinned.
AGAIN_SEED = 261andDROPPED_SEED = 46.Tests and mutants.
tests.test_simulator,tests.test_transitions,tests.test_adapters,tests.test_decide,tests.test_issue_simulator,tests.test_toolsandtests.test_hooksran 1282 tests with one failure,tests.test_tools.ReadConfinementTrial.test_the_stand_in_timeout_runs_what_gnu_timeout_runs. That one fails the same way onmainon the desk's machine, whose/usr/bin/timeoutis not GNU's; this change does not touch it.make checkspasses.tests/test_decide.pyholds it.Readers (read at 1847ad1, the same diff before a rebase onto
main):The per-reader counts other than Kimi's were kept on the machine the work moved from, and are not restated here from memory.
🤖 Generated with Claude Code