Skip to content

The simulator and the explorer push a head that leaves the diff as it was, and the world says a thread dropped (#855) - #888

Merged
don-petry merged 3 commits into
mainfrom
sim/same-diff-push-855
Nov 16, 2026
Merged

don-petry merged 3 commits into
mainfrom
sim/same-diff-push-855

Conversation

@don-petry

@don-petry don-petry commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Closes #855: its first two points. The third, the two-Lens admission, merged as #882.

What. The seeded simulation and the transitions explorer now make the two things the fix for #833 added rules for, which only unit tests held before.

  • sim/world.py: a person's push now and then keeps the content. The new GitHub rule a_push_can_leave_the_diff_as_it_was is grounded by trials/P-29.base.json; the statement says why P-29 stands for a push it did not make.
  • The world says a thread dropped only for its own Lens's review on the current content, and a push of new content clears every dropped word.
  • The check on the act takes a dropped thread as it takes an accepted one, and refuses each dropped thread the Kernel may not resolve.
  • I-11 yields only to a gating thread of the Lens's own that asks for the review: not accepted, and not dropped since the push.
  • tests/test_transitions.py: the explorer's push may keep the diff. From addressing it takes the item to verifying, and once the checks pass a gating Lens is asked again on the same content.
  • examples/facts.json and tests/support.py carry the dropped fact, with its counter-example.

Record. None: no Kernel rule changes.

Protected edits. sim/world.py and tests/test_simulator.py: pre-approved by the Maintainer 2026-11-08, ruled by the Factory Builder (assignment 2026-11-14).

Seeds pinned. AGAIN_SEED = 261 and DROPPED_SEED = 46.

Tests and mutants.

  • Eleven mutants are added, all killed at 40 seeds.
  • At the default 300 seeds, on this head: tests.test_simulator, tests.test_transitions, tests.test_adapters, tests.test_decide, tests.test_issue_simulator, tests.test_tools and tests.test_hooks ran 1282 tests with one failure, tests.test_tools.ReadConfinementTrial.test_the_stand_in_timeout_runs_what_gnu_timeout_runs. That one fails the same way on main on the desk's machine, whose /usr/bin/timeout is not GNU's; this change does not touch it. make checks passes.
  • Not held by the world: the Kernel mutant "a thread the Kernel is to resolve asks its review again" is not caught by the simulation, since no seed produces that case. tests/test_decide.py holds it.

Readers (read at 1847ad1, the same diff before a rebase onto main):

Reader Disposition
Claude review In; findings taken in 6124ca9 and faef2d3 (the dropped fact's counter-example)
Claude security In; findings taken in 6124ca9
Carbon In; findings taken in 6124ca9
Astra In; findings taken in 6124ca9
Kimi Kimi: 2 findings, 2 taken (both major, both real)

The per-reader counts other than Kimi's were kept on the machine the work moved from, and are not restated here from memory.

🤖 Generated with Claude Code

View guided diff Turn on auto-fix

don-petry and others added 3 commits November 15, 2026 16:09
… was, and the world says a thread dropped (#855)

- sim/world.py: a person's push now and then keeps the content (a_push_can_leave_the_diff_as_it_was, grounded by
  trials/P-29.base.json, where the content is the hash of the pull request's own diff alone). A Lens's later review now
  and then drops a thread opened before it. The check on the act takes a dropped thread as an accepted one, and I-11
  allows a review asked again on unchanged content once the head was pushed past it while its Lens's thread stands.
- tests/test_transitions.py: the explorer's push may keep the diff; from addressing it takes the item to verifying,
  and once the checks pass a gating Lens is asked again on the same content.
- examples/facts.json and tests/support.py carry the dropped fact; the port's reading grounds the new rule.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…w of the current content, I-11 yields only to a gating thread that asks for the review, and the world refuses each dropped thread the Kernel may not resolve

- A push of new content clears every dropped word; the drop is the port's word of a review on the content it replaced.
- I-11 lets a Lens be reviewed again on unchanged content only for a gating thread of its own, not accepted and not
  dropped since the push.
- A direct test holds each clause of dropped_since_the_push, with a mutant on each; the seeds test reads each step's
  own lines and asks every push that kept the diff to have kept the content.
- The grounding says why P-29 stands for a push it did not make; the explorer's case keeps a diff unlike the default.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… a word that is no yes or no

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@don-petry
don-petry requested a review from a team as a code owner November 16, 2026 00:45
@coderabbitai

coderabbitai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

@codeant-ai

codeant-ai Bot commented Nov 16, 2026 •

Copy link
Copy Markdown

CodeAnt  CodeAnt Review Status

✅  Review completed

Status Commit Started (UTC) Finished (UTC)
✅  #360b9 Reviewed your PR faef2d3 Nov 16, 2026 · 00:45 00:51

@codeant-ai

codeant-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T00:49:49.182624Z faef2d3 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@sonarqubecloud

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces the concept of a push that leaves a pull request's diff unchanged (such as a merge of the base branch that does not touch any of the PR's files) and models the behavior where a Lens's review can drop a thread. It updates the simulation logic in sim/world.py to handle these scenarios, including checking if a thread was dropped since the last push and allowing a second review of unchanged content under specific conditions. Corresponding tests and examples have been added to validate these transitions. The review feedback suggests improving code readability in sim/world.py by replacing backslash line continuations with PEP 8-compliant implicit line continuations inside parentheses.

Comment thread sim/world.py Resolved
Comment thread sim/world.py Resolved

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 9 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@codeant-ai

codeant-ai Bot commented Nov 16, 2026

Copy link
Copy Markdown

CodeAnt  CodeAnt PR Risk

🟢  Low Risk

  • The PR appears safe to merge; no actionable issues were identified in the review.

Assessed commit: faef2d3ef61b

@combsmith-sf-pr-review combsmith-sf-pr-review Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No findings against the rubric.

@don-petry
don-petry added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit f213850 Nov 16, 2026
33 checks passed
@don-petry
don-petry deleted the sim/same-diff-push-855 branch November 16, 2026 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The simulator and the transitions explorer never push a head that leaves the diff as it was, and never say a thread dropped

2 participants