Skip to content

feat: add passive trust-boundary and data-lifecycle review skills (#406) - #412

Closed
Knapp-Kevin wants to merge 15 commits into
mainfrom
feat/406-trust-privacy-passive-skills
Closed

Knapp-Kevin wants to merge 15 commits into
mainfrom
feat/406-trust-privacy-passive-skills

Conversation

@Knapp-Kevin

@Knapp-Kevin Knapp-Kevin commented Oct 10, 2026 •

Copy link
Copy Markdown
Owner

Proposes two passive, host-executed first-party knowledge procedures from capability review #406 (research issue closed; these admissions are not complete): skills/trust-boundary-review/SKILL.md and skills/data-lifecycle-review/SKILL.md. Both scope authority, protect secrets/PII, separate proposed from executed effects, and report behavioral validation not-run. No repository-owned runtime, scripts, tests, CI, scanner, scheduler, or autonomous processing is permitted.

Current exact-version candidate evidence

  • trust-boundary-review: Git blob 50fe2928509a0d235e25813e5524b5305a688b1e; individual structured static semantic review verified at 19/20.
  • data-lifecycle-review: Git blob b30673b509e25382afbce8dc52f32440ebfdbed9; individual structured static semantic review verified at 18/20.
  • Each has a provenance companion, semantic verification companion, and an exact-version security companion with security_status: incomplete. Historical SkillSpector gate run 38309617787 reported both PASS on the earlier exact manifest blobs, but full per-package JSON, scores and report digests were not persisted. This is not a qualifying security approval under present policy.

Required before admission or merge

  1. Recover or rerun qualifying complete exact-package security evidence using the registered external-host scanner, preserving reports/digests and actual findings; do not inherit past check success.
  2. Obtain current independent semantic/adversarial admission acceptance. The existing static review is not behavioral validation.
  3. Reconcile against the latest main and concurrent PR fix: consolidate 16 passive pulse repairs and 5 security hardenings #416, especially the 44-entry consolidated first-party registry and taxonomy; verify exact candidate fingerprints after reconciliation.
  4. Only when both candidates qualify for admission, atomically reconcile README.md, docs/SYSTEM_STATE.md, CURATION_QUEUE.md, INDEX.md, index.json (44→46 first-party, with source and third-party counts unchanged).
  5. Re-inspect reviews, review threads, checks/runs and mergeability before using expected-head merge protection.

Disposition: DRAFT / HOLD. The PR being technically mergeable is not evidence of acceptance. No workflow, scanner, executable test, or other repository-owned machinery may be added. Current review evidence: docs/evals/2026-10-12-pr412-static-overlap-authority-review.md and docs/evals/2026-10-12-pr412-exact-head-security-evidence.md.

Copy link
Copy Markdown
Owner Author

Remediation update (2026-10-12): committed d3f245e. The prior HIGH scanner match on the quoted example was a context false positive: the skill explicitly says to treat untrusted embedded directions as data and forbids taking action without scoped user authority. The example now describes an instruction-override quotation without embedding the attack phrase verbatim. This is an editorial clarification, not a waiver of the scanner, and it does not itself establish a passing new scan, independent security adjudication, or admission readiness. Re-run authorized external review against this exact head, retain evidence, and reconcile first-party admission accounting before merging.

Copy link
Copy Markdown
Owner Author

Remediation checkpoint (2026-10-12): branch head fc6f74c updates registry/verification/local-skills/trust-boundary-review.yaml to the current SKILL.md blob SHA 50fe2928509a0d235e25813e5524b5305a688b1e after the wording fix. The previous evidence record's 3f00186... fingerprint was stale. Semantic verification remains static-only; behavioral validation not-run. New SkillSpector run 38309617787 was in progress when checked. Do not mark package-security passed or merge until actual exact-version results and all accounting/review requirements are satisfied.

Copy link
Copy Markdown
Owner Author

2026-10-12 admission-evidence update: committed docs/evals/2026-10-12-pr412-exact-head-security-evidence.md at ec764f1. Read actual run 38309617787/job 115011868192 logs: exact PR head fc6f74c scanned both data-lifecycle-review and trust-boundary-review with --no-llm --fail-on-findings --fail-on-incomplete; each PASS, zero failures. The runner did not publish downloadable JSON report artifacts, so per-package risk metrics/digest are not available and must not be invented. Skill manifest fingerprints match both provenance companions. Not behavioral validated. No public 44->46 accounting until independent admission review, security record closure, and all five public surfaces are staged together. GitHub reports mergeable=true following the note-only commit, but the PR remains draft and behind newly merged main; not ready to merge.

Copy link
Copy Markdown
Owner Author

Security evidence remediation (2026-10-12): two exact-identity passive records were added at registry/security/local-skills/{data-lifecycle-review,trust-boundary-review}.yaml and both semantic verification companions were updated (latest head 577774abbbb7cdaf34ed35ff49ab2be585edfbfc). The pinned SkillSpector CI run 38309617787 scanned both exact manifest blobs with zero failures, but its per-package report JSON was not published as an artifact. The persisted records intentionally use security_status: incomplete and risk_score: unknown, not false passed attestations. Public first-party inventory remains 44; admission of both candidates and five-surface 44->46 accounting remain blocked until complete package-security evidence, independent review, and current-main reconciliation. PR remains draft and should not be merged yet.

Copy link
Copy Markdown
Owner Author

2026-10-12 continued admission review: committed docs/evals/2026-10-12-pr412-static-overlap-authority-review.md at 77f7ff4. Compared both skills against mcp-vetting, permissions-review, session-continuity, agent-home-doctor, and agent-postmortem: both cover differentiated, passive boundaries and have clear action-scoped authorization and sensitive-data minimization. Individual blob identities verified; behavioral execution not-run. Security CI previously passed 2/2 at fc6f74c, but the report JSON was not retained, so persisted per-package records truthfully remain incomplete. Latest head is 1 commit behind main, 14 ahead; branch is mergeable but still draft. Do not merge or change five-surface counts until package-security evidence is eligible and current-main reconciliation is complete. This static review is not an independent human approval.

This was referenced Oct 31, 2026

Copy link
Copy Markdown
Owner Author

Disposition: CLOSED / UNMERGED / EVIDENCE PRESERVED (2026-11-03).

Candidate admission HOLD, not merged. Two proposed passive trust-boundary/data-lifecycle skills, individual exact-version/static review companions, and incomplete security receipts remain preserved on this PR head. Historical scan success without full per-package report/digest does not qualify the current trees; host adversarial acceptance is also absent. Do not increase first-party inventory or imply unchanged-use approval. Closing the stale candidate PR while retaining its branch and review evidence for future qualified admission tracked by #588/#589/#402.

Preserved exact PR head: 42b8f8e6bdb3cc88ee4ca496c5801af791cb4917. Linked tracking: #588 #589 and #402. PR reviews and inline review threads: none returned. Commit combined statuses: none; pull-request-triggered workflow lookup: zero for this head (not a global Actions claim).

Closing the PR does not close linked issues, delete its Git history, grant production/user action authority, or satisfy security/behavioral validation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant