Repository navigation
fix(web): restore default remote cursor rendering - #1910
Merged
Benoît Cortier (CBenoit) merged 1 commit intoSep 8, 2026
Merged
Benoît Cortier (CBenoit) merged 1 commit into
Benoît Cortier (CBenoit) merged 1 commit into
Conversation
build_config() has hardcoded enable_server_pointer: false since the no_server_pointer -> enable_server_pointer rename inverted the flag's polarity without updating this literal. The CLI call site in the same commit correctly negated the old value; this bare literal was missed. The native client already defaults to true (ClientBuilder::enable_server_pointer.unwrap_or(true)), so this restores parity: remote cursor shapes silently never render in the web client today, with no error at any log level, since fast_path.rs::process_pointer_update returns immediately when the flag is false. Fixes Devolutions#1900.
Greg Lamberson (glamberson)
temporarily deployed
to
llm-providers
September 5, 2026 14:18 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
kind/protocol
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The change is a minimal, targeted one-line default fix that aligns with existing client behavior and directly resolves the identified regression without introducing new control flow or API surface.
Pull request overview
Restores the expected default behavior for remote cursor rendering in the WASM/web client by re-enabling server pointer processing in ironrdp-web’s build_config(), matching the native client default and fixing the post-rename polarity regression described in #1900.
Changes:
- Set
enable_server_pointer: trueincrates/ironrdp-web/src/session.rs::build_config()so pointer updates are processed and cursor styles can be applied.
File summaries
| File | Description |
|---|---|
| crates/ironrdp-web/src/session.rs | Fixes the web client config default so server pointer updates are no longer silently dropped, restoring remote cursor shape rendering. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
Anton Mostovoy (antonmos)
added a commit
to antonmos/IronRDP
that referenced
this pull request
Sep 8, 2026
…nnection-negotiation * upstream/master: (124 commits) feat(server): let an authenticated connection preempt an existing session (Devolutions#1476) ci(pr-automation): recover reviewer stages (Devolutions#1922) ci(pr-automation): report review check diagnostics (Devolutions#1926) ci(pr-automation): recover agent runtime (Devolutions#1921) ci(pr-automation): report reviewer recovery (Devolutions#1920) docs(pr-automation): define review recovery intent (Devolutions#1915) feat(web): expose enable_server_pointer from the WASM module (Devolutions#1914) fix(web): restore default remote cursor rendering (Devolutions#1910) feat(usb)!: support SuperSpeed packet sizes (Devolutions#1883) ci(pr-automation): explain reviewer ineligibility (Devolutions#1906) ci(pr-automation): explain skipped reviews (Devolutions#1907) ci(pr-automation): request JSON mode (Devolutions#1908) ci(pr-automation): repair empty agent responses (Devolutions#1905) ci(pr-automation): diagnose invalid repairs (Devolutions#1904) ci(pr-automation): simplify review findings (Devolutions#1901) fix(server): bound accept_finalize so a wedged client cannot hold the server (Devolutions#1890) ci(pr-automation): improve reviewer diagnostics (Devolutions#1898) ci(pr-automation): redispatch explicit retries (Devolutions#1897) test: focus PR automation workflow coverage (Devolutions#1896) feat(agent): add clipboard image support (Devolutions#1877) ... # Conflicts: # crates/ironrdp-server/src/server.rs
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build_config()has hardcodedenable_server_pointer: falsesince theno_server_pointertoenable_server_pointerrename (218fed0) invertedthe flag's polarity without updating this literal. The CLI call site in
the same commit correctly negated the old value (
!args.no_server_pointer);this bare literal in
ironrdp-webwas missed.The native client already defaults to
true(
ClientBuilder::enable_server_pointer.unwrap_or(true)), so this restoresparity. Today, remote cursor shapes silently never render in the web
client:
ironrdp-session::fast_path::process_pointer_updatereturns onits first line when the flag is
false, with no error at any log level,so the regression is invisible until someone reads the source.
Fixes #1900, which independently rebuilt the wasm package with this exact
one-line change and verified all remote cursor shapes work correctly
against a real Windows Server host.
Not bundled here: the issue also suggests exposing this setting on
SessionBuilderso embedders can turn it off deliberately, since nothingin the current public API reaches it. Leaving that as a separate,
smaller follow-up rather than widening this fix's scope.
cargo xtask check fmt/lints/tests/typos/locksandcargo xtask wasm checkall pass.