Skip to content

ci(pr-automation): explain skipped reviews - #1907

Merged
Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
cbenoit-review-gate-summary
Sep 7, 2026
Merged

Benoît Cortier (CBenoit) merged 1 commit into
masterfrom
cbenoit-review-gate-summary

Conversation

@CBenoit

Copy link
Copy Markdown
Member

Publish an Actions job summary when the automated review pipeline is skipped. List every gate and fork-quota blocker so maintainers can understand the decision without inspecting raw JSON logs.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

Publish an Actions job summary when the automated review pipeline is skipped. List every gate and fork-quota blocker so maintainers can understand the decision without inspecting raw JSON logs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The implementation is focused, consistent with existing automation, and adequately tested.

Pull request overview

Adds clear Actions summaries explaining why automated reviews were skipped.

Changes:

  • Reports all failed review gates and quota blockers.
  • Adds focused unit and workflow integration coverage.
  • No material findings identified.
File summaries
File Description
.github/workflows/labeler.yml Publishes the skip summary.
.github/pr-automation/review-skip-summary.js Builds human-readable skip reasons.
.github/pr-automation/automation.test.js Tests gate, quota, and workflow behavior.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 0
  • Review effort level: Balanced

@github-actions github-actions Bot added needs-review A human reviewer is the current next actor risk/low Self-contained change with no cross-crate behavioral effect scope/tooling Build, CI, release, or developer tooling size/S Size: up to 199 counted lines and 5 files; exceeds XS in either measure labels Sep 4, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Independent review of PR #1907: it adds a review-skip-summary module, unit tests, and a workflow block in resolve-review-state that publishes a job summary when the review pipeline is skipped. I verified the branching against the real producers: review-gate publishes gate.reason only on its catch path, fork-rate-limit emits limited/unavailable/allowed quota shapes, and resolve-review-state runs with always() so results are available even when the gate fails. Reason ordering matches the tested outputs, the fallback guarantees a non-empty list, and the state output is written before the summary block, so a summary failure cannot lose the state. Only minor, optional helper-extraction opportunities remain; no correctness, safety, or protocol issues were found. The skeptical reviewer timed out, so only the two code-compressor candidates exist; both are valid low-severity maintainability notes and are published (one with a corrected line range).

Comment thread .github/pr-automation/review-skip-summary.js
Comment thread .github/pr-automation/review-skip-summary.js
@github-actions github-actions Bot added ai-reviewed/1 One automated review completed and removed needs-review A human reviewer is the current next actor labels Sep 5, 2026
@CBenoit
Benoît Cortier (CBenoit) merged commit d4e2157 into master Sep 7, 2026
43 checks passed
@CBenoit
Benoît Cortier (CBenoit) deleted the cbenoit-review-gate-summary branch September 7, 2026 20:03
Anton Mostovoy (antonmos) added a commit to antonmos/IronRDP that referenced this pull request Sep 8, 2026
…nnection-negotiation

* upstream/master: (124 commits)
  feat(server): let an authenticated connection preempt an existing session (Devolutions#1476)
  ci(pr-automation): recover reviewer stages (Devolutions#1922)
  ci(pr-automation): report review check diagnostics (Devolutions#1926)
  ci(pr-automation): recover agent runtime (Devolutions#1921)
  ci(pr-automation): report reviewer recovery (Devolutions#1920)
  docs(pr-automation): define review recovery intent (Devolutions#1915)
  feat(web): expose enable_server_pointer from the WASM module (Devolutions#1914)
  fix(web): restore default remote cursor rendering (Devolutions#1910)
  feat(usb)!: support SuperSpeed packet sizes (Devolutions#1883)
  ci(pr-automation): explain reviewer ineligibility (Devolutions#1906)
  ci(pr-automation): explain skipped reviews (Devolutions#1907)
  ci(pr-automation): request JSON mode (Devolutions#1908)
  ci(pr-automation): repair empty agent responses (Devolutions#1905)
  ci(pr-automation): diagnose invalid repairs (Devolutions#1904)
  ci(pr-automation): simplify review findings (Devolutions#1901)
  fix(server): bound accept_finalize so a wedged client cannot hold the server (Devolutions#1890)
  ci(pr-automation): improve reviewer diagnostics (Devolutions#1898)
  ci(pr-automation): redispatch explicit retries (Devolutions#1897)
  test: focus PR automation workflow coverage (Devolutions#1896)
  feat(agent): add clipboard image support (Devolutions#1877)
  ...

# Conflicts:
#	crates/ironrdp-server/src/server.rs

This branch was previously deployed

1 inactive deployment
llm-providers — 7b11db58 Deployed Sep 4, 2026 by CBenoit via Classify pull request #5056
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai-reviewed/1 One automated review completed risk/low Self-contained change with no cross-crate behavioral effect scope/tooling Build, CI, release, or developer tooling size/S Size: up to 199 counted lines and 5 files; exceeds XS in either measure

Development

Successfully merging this pull request may close these issues.

3 participants