Skip to content

ci(pr-automation): explain reviewer ineligibility - #1906

Merged
Benoît Cortier (CBenoit) merged 4 commits into
masterfrom
cbenoit-explain-reviewer-ineligibility
Sep 7, 2026
Merged

Benoît Cortier (CBenoit) merged 4 commits into
masterfrom
cbenoit-explain-reviewer-ineligibility

Conversation

@CBenoit

Copy link
Copy Markdown
Member

Post a bounded policy comment when contributor history blocks review.

Reuse the marker lifecycle to avoid duplicates and remove stale guidance
after eligibility changes.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

Post a bounded policy comment when contributor history blocks review.

Reuse the marker lifecycle to avoid duplicates and remove stale guidance
after eligibility changes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The published policy comment must include an approved LLM attribution footer.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Adds lifecycle-managed guidance when contributor history prevents automated review.

Changes:

  • Posts bounded eligibility guidance.
  • Prevents duplicates and removes stale comments.
  • Adds lifecycle test coverage.
File summaries
File Review
.github/pr-automation/write-state.js Renders guidance, but lacks the required LLM attribution footer.
.github/pr-automation/resolve-state.js Manages comment creation and cleanup.
.github/pr-automation/automation.test.js Tests content, deduplication, and cleanup.
Review details
  • Files reviewed: 3/3 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread .github/pr-automation/write-state.js
@github-actions github-actions Bot added needs-review A human reviewer is the current next actor risk/low Self-contained change with no cross-crate behavioral effect scope/tooling Build, CI, release, or developer tooling size/S Size: up to 199 counted lines and 5 files; exceeds XS in either measure labels Sep 4, 2026
Append the required no-human-feedback footer to the automated
contributor eligibility comment.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Comment thread .github/pr-automation/write-state.js Outdated
Drop comment wording assertions after the intentional footer removal.
Assert that ineligible reviews preserve review counts and require
maintainer review, retaining marker and comment lifecycle coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
Benoît Cortier (CBenoit) merged commit b043d37 into master Sep 7, 2026
41 checks passed
@CBenoit
Benoît Cortier (CBenoit) deleted the cbenoit-explain-reviewer-ineligibility branch September 7, 2026 20:31
Anton Mostovoy (antonmos) added a commit to antonmos/IronRDP that referenced this pull request Sep 8, 2026
…nnection-negotiation

* upstream/master: (124 commits)
  feat(server): let an authenticated connection preempt an existing session (Devolutions#1476)
  ci(pr-automation): recover reviewer stages (Devolutions#1922)
  ci(pr-automation): report review check diagnostics (Devolutions#1926)
  ci(pr-automation): recover agent runtime (Devolutions#1921)
  ci(pr-automation): report reviewer recovery (Devolutions#1920)
  docs(pr-automation): define review recovery intent (Devolutions#1915)
  feat(web): expose enable_server_pointer from the WASM module (Devolutions#1914)
  fix(web): restore default remote cursor rendering (Devolutions#1910)
  feat(usb)!: support SuperSpeed packet sizes (Devolutions#1883)
  ci(pr-automation): explain reviewer ineligibility (Devolutions#1906)
  ci(pr-automation): explain skipped reviews (Devolutions#1907)
  ci(pr-automation): request JSON mode (Devolutions#1908)
  ci(pr-automation): repair empty agent responses (Devolutions#1905)
  ci(pr-automation): diagnose invalid repairs (Devolutions#1904)
  ci(pr-automation): simplify review findings (Devolutions#1901)
  fix(server): bound accept_finalize so a wedged client cannot hold the server (Devolutions#1890)
  ci(pr-automation): improve reviewer diagnostics (Devolutions#1898)
  ci(pr-automation): redispatch explicit retries (Devolutions#1897)
  test: focus PR automation workflow coverage (Devolutions#1896)
  feat(agent): add clipboard image support (Devolutions#1877)
  ...

# Conflicts:
#	crates/ironrdp-server/src/server.rs

This branch was previously deployed

1 inactive deployment
llm-providers — 55a20e2b Deployed Sep 7, 2026 by CBenoit via Classify pull request #5137
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review A human reviewer is the current next actor risk/low Self-contained change with no cross-crate behavioral effect scope/tooling Build, CI, release, or developer tooling size/S Size: up to 199 counted lines and 5 files; exceeds XS in either measure

Development

Successfully merging this pull request may close these issues.

3 participants