Skip to content

test: focus PR automation workflow coverage - #1896

Merged
Benoît Cortier (CBenoit) merged 2 commits into
masterfrom
cbenoit-pr-automation-test-cleanup
Sep 4, 2026
Merged

Benoît Cortier (CBenoit) merged 2 commits into
masterfrom
cbenoit-pr-automation-test-cleanup

Conversation

@CBenoit

Copy link
Copy Markdown
Member

Remove brittle source-text assertions that duplicate workflow YAML.

Retain computed behavior and focused trust-boundary contracts.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

Remove brittle source-text assertions that duplicate workflow YAML.

Retain computed behavior and focused trust-boundary contracts.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The secret-boundary test can pass while either review job lacks its required provider environment.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Focuses PR automation tests on computed behavior and trust boundaries rather than brittle YAML duplication.

Changes:

  • Removes broad workflow source-text assertions.
  • Adds reusable-review secret and trusted-checkout checks.
  • Retains focused force, label, and review behavior tests.

Protocol and documentation passes were skipped because only automation tests changed.

File summaries
File Description
.github/pr-automation/automation.test.js Refocuses workflow test coverage.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread .github/pr-automation/automation.test.js Outdated
@github-actions github-actions Bot added needs-review A human reviewer is the current next actor risk/low Self-contained change with no cross-crate behavioral effect scope/tooling Build, CI, release, or developer tooling size/S Size: up to 199 counted lines and 5 files; exceeds XS in either measure labels Sep 4, 2026
Check the provider environment and API key together in every reusable workflow job that consumes the secret.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@CBenoit
Benoît Cortier (CBenoit) merged commit 996d8db into master Sep 4, 2026
42 checks passed
@CBenoit
Benoît Cortier (CBenoit) deleted the cbenoit-pr-automation-test-cleanup branch September 4, 2026 01:48
Anton Mostovoy (antonmos) added a commit to antonmos/IronRDP that referenced this pull request Sep 8, 2026
…nnection-negotiation

* upstream/master: (124 commits)
  feat(server): let an authenticated connection preempt an existing session (Devolutions#1476)
  ci(pr-automation): recover reviewer stages (Devolutions#1922)
  ci(pr-automation): report review check diagnostics (Devolutions#1926)
  ci(pr-automation): recover agent runtime (Devolutions#1921)
  ci(pr-automation): report reviewer recovery (Devolutions#1920)
  docs(pr-automation): define review recovery intent (Devolutions#1915)
  feat(web): expose enable_server_pointer from the WASM module (Devolutions#1914)
  fix(web): restore default remote cursor rendering (Devolutions#1910)
  feat(usb)!: support SuperSpeed packet sizes (Devolutions#1883)
  ci(pr-automation): explain reviewer ineligibility (Devolutions#1906)
  ci(pr-automation): explain skipped reviews (Devolutions#1907)
  ci(pr-automation): request JSON mode (Devolutions#1908)
  ci(pr-automation): repair empty agent responses (Devolutions#1905)
  ci(pr-automation): diagnose invalid repairs (Devolutions#1904)
  ci(pr-automation): simplify review findings (Devolutions#1901)
  fix(server): bound accept_finalize so a wedged client cannot hold the server (Devolutions#1890)
  ci(pr-automation): improve reviewer diagnostics (Devolutions#1898)
  ci(pr-automation): redispatch explicit retries (Devolutions#1897)
  test: focus PR automation workflow coverage (Devolutions#1896)
  feat(agent): add clipboard image support (Devolutions#1877)
  ...

# Conflicts:
#	crates/ironrdp-server/src/server.rs

This branch was previously deployed

1 inactive deployment
llm-providers — 2775425b Deployed Sep 4, 2026 by CBenoit via Classify pull request #4936
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review A human reviewer is the current next actor risk/low Self-contained change with no cross-crate behavioral effect scope/tooling Build, CI, release, or developer tooling size/S Size: up to 199 counted lines and 5 files; exceeds XS in either measure

Development

Successfully merging this pull request may close these issues.

2 participants