Repository navigation
ci(pr-automation): diagnose invalid repairs - #1904
Merged
Benoît Cortier (CBenoit) merged 1 commit intoSep 4, 2026
Merged
Conversation
Preserve the second validation failure in the action failure reason when the single correction attempt remains invalid. Use schema paths instead of model-controlled instance paths so the added diagnostic cannot disclose response property names. Invalid structured output remains rejected. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
September 4, 2026 17:26 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
needs-review
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation is focused, safely avoids model-controlled paths, and has appropriate regression coverage.
Pull request overview
Preserves detailed validation failures after an unsuccessful repair while preventing model-controlled property names from appearing in diagnostics.
Changes:
- Reports the second validation failure.
- Uses schema paths for safer diagnostics.
- Adds validator and end-to-end regression tests.
No material findings identified; protocol and documentation reviews were not applicable.
File summaries
| File | Description |
|---|---|
.github/actions/openai-agent/src/agent.js |
Improves safe repair-failure diagnostics. |
.github/actions/openai-agent/test/agent.test.js |
Tests diagnostic propagation and property-name redaction. |
.github/actions/openai-agent/test/main.test.js |
Tests action outputs and failure events. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 0
- Review effort level: Balanced
Benoît Cortier (CBenoit)
enabled auto-merge (squash)
September 4, 2026 17:31
Benoît Cortier (CBenoit)
disabled auto-merge
September 4, 2026 17:52
Benoît Cortier (CBenoit)
deleted the
cbenoit-fix-agent-repair-handling
branch
September 4, 2026 17:52
Anton Mostovoy (antonmos)
added a commit
to antonmos/IronRDP
that referenced
this pull request
Sep 8, 2026
…nnection-negotiation * upstream/master: (124 commits) feat(server): let an authenticated connection preempt an existing session (Devolutions#1476) ci(pr-automation): recover reviewer stages (Devolutions#1922) ci(pr-automation): report review check diagnostics (Devolutions#1926) ci(pr-automation): recover agent runtime (Devolutions#1921) ci(pr-automation): report reviewer recovery (Devolutions#1920) docs(pr-automation): define review recovery intent (Devolutions#1915) feat(web): expose enable_server_pointer from the WASM module (Devolutions#1914) fix(web): restore default remote cursor rendering (Devolutions#1910) feat(usb)!: support SuperSpeed packet sizes (Devolutions#1883) ci(pr-automation): explain reviewer ineligibility (Devolutions#1906) ci(pr-automation): explain skipped reviews (Devolutions#1907) ci(pr-automation): request JSON mode (Devolutions#1908) ci(pr-automation): repair empty agent responses (Devolutions#1905) ci(pr-automation): diagnose invalid repairs (Devolutions#1904) ci(pr-automation): simplify review findings (Devolutions#1901) fix(server): bound accept_finalize so a wedged client cannot hold the server (Devolutions#1890) ci(pr-automation): improve reviewer diagnostics (Devolutions#1898) ci(pr-automation): redispatch explicit retries (Devolutions#1897) test: focus PR automation workflow coverage (Devolutions#1896) feat(agent): add clipboard image support (Devolutions#1877) ... # Conflicts: # crates/ironrdp-server/src/server.rs
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Preserve the second validation failure in the action failure reason when the single correction attempt remains invalid.
Use schema paths instead of model-controlled instance paths so the added diagnostic cannot disclose response property names. Invalid structured output remains rejected.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com