Skip to content

ci(pr-automation): simplify review findings - #1901

Merged
Benoît Cortier (CBenoit) merged 3 commits into
masterfrom
cbenoit-reviewer-severity-labels
Sep 4, 2026
Merged

Benoît Cortier (CBenoit) merged 3 commits into
masterfrom
cbenoit-reviewer-severity-labels

Conversation

@CBenoit

Copy link
Copy Markdown
Member

Report severity as the actionable review signal and leave blocking decisions to pull request authors.

Remove redundant classification and model-schema version fields, retain questions as a boolean marker, and publish a green review when no findings remain.

Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com

Report severity as the actionable review signal and leave blocking
decisions to pull request authors.

Remove redundant classification and model-schema version fields, retain
questions as a boolean marker, and publish a green review when no
findings remain.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Copilot AI balanced review requested due to automatic review settings September 4, 2026 15:54
Describe only the intended fields without naming removed concepts.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The review-check lookup needs legacy-ID fallback to preserve rollout behavior.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Simplifies automated review findings by using severity and question status, removing schema versioning, and publishing green reviews when no findings remain.

Changes:

  • Updates review schemas, validators, prompts, state handling, and documentation.
  • Adds severity/question indicators and coverage for revised behavior.
  • Changes review check identifiers to SHA-only values.
File summaries
File Review
.github/workflows/labeler.yml Moderate: SHA-only lookup must fall back to legacy final-review-v1:<sha> checks to avoid incorrectly consuming a second review.
.github/workflows/labeler.intent.md Documents simplified review output.
.github/pr-automation/write-state.js Renders severity, question, and green-review indicators.
.github/pr-automation/validate-final-review.js Validates simplified final-review fields.
.github/pr-automation/validate-classifier.js Removes schema-version validation.
.github/pr-automation/validate-candidate-review.js Validates severity and question markers.
.github/pr-automation/schemas/final-review.json Updates final-review schema.
.github/pr-automation/schemas/classifier.json Removes schema metadata.
.github/pr-automation/schemas/candidate-review.json Updates candidate-review schema.
.github/pr-automation/resolve-state.js Derives findings state and publishes reviews.
.github/pr-automation/prompts/skeptical.md Updates skeptical-review output guidance.
.github/pr-automation/prompts/protocol-reviewer.md Updates protocol-review output guidance.
.github/pr-automation/prompts/general-reviewer.md Updates final-review guidance.
.github/pr-automation/prompts/code-compressor.md Updates compression-review guidance.
.github/pr-automation/automation.test.js Tests validation and rendering changes.
.github/PR_AUTOMATION.md Documents visible review indicators.
Review details
  • Files reviewed: 16/16 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread .github/workflows/labeler.yml Outdated
Recognize any successful GitHub Actions review check already scoped to
the exact head and check name. This preserves second-review eligibility
across the switch to SHA-only check identifiers without legacy coupling.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@github-actions github-actions Bot added needs-review A human reviewer is the current next actor risk/low Self-contained change with no cross-crate behavioral effect scope/tooling Build, CI, release, or developer tooling size/L Size: up to 899 counted lines and 20 files; exceeds M in either measure labels Sep 4, 2026
@CBenoit
Benoît Cortier (CBenoit) merged commit a297a8f into master Sep 4, 2026
41 checks passed
@CBenoit
Benoît Cortier (CBenoit) deleted the cbenoit-reviewer-severity-labels branch September 4, 2026 17:30
Anton Mostovoy (antonmos) added a commit to antonmos/IronRDP that referenced this pull request Sep 8, 2026
…nnection-negotiation

* upstream/master: (124 commits)
  feat(server): let an authenticated connection preempt an existing session (Devolutions#1476)
  ci(pr-automation): recover reviewer stages (Devolutions#1922)
  ci(pr-automation): report review check diagnostics (Devolutions#1926)
  ci(pr-automation): recover agent runtime (Devolutions#1921)
  ci(pr-automation): report reviewer recovery (Devolutions#1920)
  docs(pr-automation): define review recovery intent (Devolutions#1915)
  feat(web): expose enable_server_pointer from the WASM module (Devolutions#1914)
  fix(web): restore default remote cursor rendering (Devolutions#1910)
  feat(usb)!: support SuperSpeed packet sizes (Devolutions#1883)
  ci(pr-automation): explain reviewer ineligibility (Devolutions#1906)
  ci(pr-automation): explain skipped reviews (Devolutions#1907)
  ci(pr-automation): request JSON mode (Devolutions#1908)
  ci(pr-automation): repair empty agent responses (Devolutions#1905)
  ci(pr-automation): diagnose invalid repairs (Devolutions#1904)
  ci(pr-automation): simplify review findings (Devolutions#1901)
  fix(server): bound accept_finalize so a wedged client cannot hold the server (Devolutions#1890)
  ci(pr-automation): improve reviewer diagnostics (Devolutions#1898)
  ci(pr-automation): redispatch explicit retries (Devolutions#1897)
  test: focus PR automation workflow coverage (Devolutions#1896)
  feat(agent): add clipboard image support (Devolutions#1877)
  ...

# Conflicts:
#	crates/ironrdp-server/src/server.rs

This branch was previously deployed

1 inactive deployment
llm-providers — f564aadc Deployed Sep 4, 2026 by CBenoit via Classify pull request #5012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-review A human reviewer is the current next actor risk/low Self-contained change with no cross-crate behavioral effect scope/tooling Build, CI, release, or developer tooling size/L Size: up to 899 counted lines and 20 files; exceeds M in either measure

Development

Successfully merging this pull request may close these issues.

2 participants