Repository navigation
ci(pr-automation): simplify review findings - #1901
Merged
Benoît Cortier (CBenoit) merged 3 commits intoSep 4, 2026
Merged
Conversation
Report severity as the actionable review signal and leave blocking decisions to pull request authors. Remove redundant classification and model-schema version fields, retain questions as a boolean marker, and publish a green review when no findings remain. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Describe only the intended fields without naming removed concepts. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Benoît Cortier (CBenoit)
had a problem deploying
to
llm-providers
September 4, 2026 15:54 — with
GitHub Actions
Error
Copilot started reviewing on behalf of
Benoît Cortier (CBenoit)
September 4, 2026 15:54
View session
Benoît Cortier (CBenoit)
had a problem deploying
to
llm-providers
September 4, 2026 15:56 — with
GitHub Actions
Error
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The review-check lookup needs legacy-ID fallback to preserve rollout behavior.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Simplifies automated review findings by using severity and question status, removing schema versioning, and publishing green reviews when no findings remain.
Changes:
- Updates review schemas, validators, prompts, state handling, and documentation.
- Adds severity/question indicators and coverage for revised behavior.
- Changes review check identifiers to SHA-only values.
File summaries
| File | Review |
|---|---|
.github/workflows/labeler.yml |
Moderate: SHA-only lookup must fall back to legacy final-review-v1:<sha> checks to avoid incorrectly consuming a second review. |
.github/workflows/labeler.intent.md |
Documents simplified review output. |
.github/pr-automation/write-state.js |
Renders severity, question, and green-review indicators. |
.github/pr-automation/validate-final-review.js |
Validates simplified final-review fields. |
.github/pr-automation/validate-classifier.js |
Removes schema-version validation. |
.github/pr-automation/validate-candidate-review.js |
Validates severity and question markers. |
.github/pr-automation/schemas/final-review.json |
Updates final-review schema. |
.github/pr-automation/schemas/classifier.json |
Removes schema metadata. |
.github/pr-automation/schemas/candidate-review.json |
Updates candidate-review schema. |
.github/pr-automation/resolve-state.js |
Derives findings state and publishes reviews. |
.github/pr-automation/prompts/skeptical.md |
Updates skeptical-review output guidance. |
.github/pr-automation/prompts/protocol-reviewer.md |
Updates protocol-review output guidance. |
.github/pr-automation/prompts/general-reviewer.md |
Updates final-review guidance. |
.github/pr-automation/prompts/code-compressor.md |
Updates compression-review guidance. |
.github/pr-automation/automation.test.js |
Tests validation and rendering changes. |
.github/PR_AUTOMATION.md |
Documents visible review indicators. |
Review details
- Files reviewed: 16/16 changed files
- Comments generated: 1
- Review effort level: Balanced
Recognize any successful GitHub Actions review check already scoped to the exact head and check name. This preserves second-review eligibility across the switch to SHA-only check identifiers without legacy coupling. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
September 4, 2026 15:59 — with
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
deleted the
cbenoit-reviewer-severity-labels
branch
September 4, 2026 17:30
Anton Mostovoy (antonmos)
added a commit
to antonmos/IronRDP
that referenced
this pull request
Sep 8, 2026
…nnection-negotiation * upstream/master: (124 commits) feat(server): let an authenticated connection preempt an existing session (Devolutions#1476) ci(pr-automation): recover reviewer stages (Devolutions#1922) ci(pr-automation): report review check diagnostics (Devolutions#1926) ci(pr-automation): recover agent runtime (Devolutions#1921) ci(pr-automation): report reviewer recovery (Devolutions#1920) docs(pr-automation): define review recovery intent (Devolutions#1915) feat(web): expose enable_server_pointer from the WASM module (Devolutions#1914) fix(web): restore default remote cursor rendering (Devolutions#1910) feat(usb)!: support SuperSpeed packet sizes (Devolutions#1883) ci(pr-automation): explain reviewer ineligibility (Devolutions#1906) ci(pr-automation): explain skipped reviews (Devolutions#1907) ci(pr-automation): request JSON mode (Devolutions#1908) ci(pr-automation): repair empty agent responses (Devolutions#1905) ci(pr-automation): diagnose invalid repairs (Devolutions#1904) ci(pr-automation): simplify review findings (Devolutions#1901) fix(server): bound accept_finalize so a wedged client cannot hold the server (Devolutions#1890) ci(pr-automation): improve reviewer diagnostics (Devolutions#1898) ci(pr-automation): redispatch explicit retries (Devolutions#1897) test: focus PR automation workflow coverage (Devolutions#1896) feat(agent): add clipboard image support (Devolutions#1877) ... # Conflicts: # crates/ironrdp-server/src/server.rs
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Report severity as the actionable review signal and leave blocking decisions to pull request authors.
Remove redundant classification and model-schema version fields, retain questions as a boolean marker, and publish a green review when no findings remain.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com