Repository navigation
feat(usb)!: support SuperSpeed packet sizes - #1883
Merged
Benoît Cortier (CBenoit) merged 5 commits intoSep 7, 2026
Merged
Conversation
`endpoint_zero_max_packet_size` took the negotiated speed and used it to pick between the two encodings USB defines for `bMaxPacketSize0`: the literal byte count of USB 2.0, and the base-2 exponent SuperSpeed uses because 512 does not fit in the field. Signed-off-by: uchouT <i@uchout.moe>
`is_valid_for_usb2` and `usb2_max_payload` were scoped to USB 2.0 and answered `false` and `None` for SuperSpeed, deferring its endpoint semantics. A consumer holding a SuperSpeed configuration descriptor therefore had no way to validate an endpoint or size its payload. Signed-off-by: uchouT <i@uchout.moe>
Signed-off-by: uchouT <i@uchout.moe>
uchouT (uchouT)
force-pushed
the
usb-superspeed
branch
from
September 4, 2026 02:36
7265931 to
e73f06b
Compare
uchouT (uchouT)
marked this pull request as ready for review
September 4, 2026 02:37
uchouT (uchouT)
temporarily deployed
to
llm-providers
September 4, 2026 02:37 — with 
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
breaking-change
Benoît Cortier (CBenoit)
temporarily deployed
to
llm-providers
September 4, 2026 15:53 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
Benoît Cortier (CBenoit)
left a comment
Benoît Cortier (CBenoit)
left a comment
Member
There was a problem hiding this comment.
Thank you for looking into this! I don’t see any issue with this code, I’ll just see what the reviewer pipeline says about the small details 🙂
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
It drops required USB 2.0 speed validation and gives incomplete SuperSpeed payload semantics.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 7/7 changed files
- Comments generated: 4
- Review effort level: Balanced
Signed-off-by: uchouT <i@uchout.moe>
Signed-off-by: uchouT <i@uchout.moe>
uchouT (uchouT)
temporarily deployed
to
llm-providers
September 5, 2026 06:02 — with
GitHub Actions
Inactive
GitHub Actions
Inactive
github-actions
Bot
added
risk/unknown
Benoît Cortier (CBenoit)
enabled auto-merge (squash)
September 7, 2026 20:37
Anton Mostovoy (antonmos)
added a commit
to antonmos/IronRDP
that referenced
this pull request
Sep 8, 2026
…nnection-negotiation * upstream/master: (124 commits) feat(server): let an authenticated connection preempt an existing session (Devolutions#1476) ci(pr-automation): recover reviewer stages (Devolutions#1922) ci(pr-automation): report review check diagnostics (Devolutions#1926) ci(pr-automation): recover agent runtime (Devolutions#1921) ci(pr-automation): report reviewer recovery (Devolutions#1920) docs(pr-automation): define review recovery intent (Devolutions#1915) feat(web): expose enable_server_pointer from the WASM module (Devolutions#1914) fix(web): restore default remote cursor rendering (Devolutions#1910) feat(usb)!: support SuperSpeed packet sizes (Devolutions#1883) ci(pr-automation): explain reviewer ineligibility (Devolutions#1906) ci(pr-automation): explain skipped reviews (Devolutions#1907) ci(pr-automation): request JSON mode (Devolutions#1908) ci(pr-automation): repair empty agent responses (Devolutions#1905) ci(pr-automation): diagnose invalid repairs (Devolutions#1904) ci(pr-automation): simplify review findings (Devolutions#1901) fix(server): bound accept_finalize so a wedged client cannot hold the server (Devolutions#1890) ci(pr-automation): improve reviewer diagnostics (Devolutions#1898) ci(pr-automation): redispatch explicit retries (Devolutions#1897) test: focus PR automation workflow coverage (Devolutions#1896) feat(agent): add clipboard image support (Devolutions#1877) ... # Conflicts: # crates/ironrdp-server/src/server.rs
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ironrdp-usbcould not describe a SuperSpeed device:is_valid_for_usb2rejected every SuperSpeed endpoint, andendpoint_zero_max_packet_sizerequired a bus speed to readbMaxPacketSize0.That speed parameter added nothing. USB 3.2 Section 9.6.1 admits only 9 there, as a base-2 exponent, while USB 2.0 admits only 8, 16, 32 and 64, stated literally, so the two encodings are disjoint and the value identifies itself. Requiring a speed only let a caller contradict the descriptor, which is exactly what a transport that cannot express SuperSpeed ends up doing.
Endpoint zero now decodes from the value alone, and the endpoint predicate carries the USB 3.2 Section 9.6.6 limits, so
is_valid_for_usb2andusb2_max_payloadlose their USB 2.0 names.Marc-André Lureau (@elmarco) has helped test with a USB 3 device from FreeRDP.