Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. |
|
Merge hold (owner request, 2026-10-21): Keep this vold exFAT timeout change out of |
Vold module review — deployment not yet ready (2026-10-21)The isolated upstream change is sensible: on the pinned LineageOS I made two small commits to this draft to prevent unintended release churn when the module is off: the existing selection fingerprint bytes are retained until vold is selected, and Blockers before merge + scheduled enablement + force-publish:
Current decision: retain draft status; do not merge, enable scheduled production builds, or publish an untested |
…ope GrapheneOS out
…rotates out nightly
Baseline-first CI progress (2026-10-22 UTC)The ordering is now enforced in code: Historical source identity is now pinned to the SHA-256 CI: #39697359803 passed the complete normal test job at exact PR head The rollout remains draft and unmerged; both LineageOS and GrapheneOS production defaults remain off for this module, the approved patched binary hash/staging tag remain blank, and no OTA release or force-publish was dispatched. Next gate is to provision that runner and obtain a real |
Stage-1 baseline prerequisite merged — 2026-10-22The independent, unmodified-vold-only infrastructure has been merged to
Retain this #157 draft unmerged. Do not enable the scheduled selector or force-publish a replacement |
2026-10-22 — Build-scope correction / dependency feasibility findingThe baseline workflow already invokes Additional reproducibility blocker: the pinned
Neither Review the exact The manual baseline run #39699955476 did not reach compilation: Suggested safe next engineering sequence: (1) audit/recover/pin the vendor configuration and its provenance; (2) create a separate read-only, nonpublishing, bounded |
Acquire exact TheMuppets vendor candidates with complete inventories and real pinned-source regeneration. Add persistent local setup, staged source builds, authenticated fresh reference extraction, and unchanged exact-byte acceptance. No Actions runner is required for local builds. Validated head: 768df41 CI: https://github.com/0cwa/ModOS/actions/runs/39786297037 78 local tests and workflow contracts passed. Real vendor preparation and no-fetch resume succeeded; official Repo/avbroot setup succeeded. Android compilation and original-vold equality remain unproved. Draft timeout module #157 and production gates remain unchanged.
…ion gates Integrate current diagnostics and Lineage-only BCR behavior, resolve conflicts, and reuse verified original-vold build setup. Verify pinned Sony vendor inputs, reject stale outputs/dependency bypasses/hidden source edits, and require patch restoration plus source revalidation before accepting artifacts. Keep the module default-off, GrapheneOS excluded, and artifact approvals blank. Thirteen Python suites and nine shell suites pass on the combined tree; no real byte-identical Android baseline or device acceptance is claimed. Uploaded tree matches locally reviewed tree d86b090.
Preserve the default-off vold gate while keeping the draft current with all reviewed ROM/module changes. Eight affected shell suites and nine Python suites pass after this integration, including Shizuku, draft vold, shared source guards, workflow routing and selection identity. Artifact approvals remain blank; real original-vold reproduction and device acceptance remain outstanding. Exact uploaded tree: d3331c5.
Incorporate the refreshed Shizuku integration parent without changing the reviewed draft tree d3331c5. Qualification gates and artifact approvals remain unchanged.
Keep the baseline, source lock, approved-artifact blanks and default-off qualification contract intact while incorporating the reviewed ModOS dependency sync. This refresh does not establish a byte-identical Android build or device acceptance.
…ation Merge the reviewed main branch without changing its unqualified source baseline, artifact pins, or draft status.
ChatGPT refreshed this draft against merged main
5d6f52042b3a0fdd0aeefda3bfa499cf12ae25f3, including the upstream sync in #175 and publication-continuity guard in #177, and reassessed its remaining qualification.November 10 review
2f6a6d9db1e86928b8aef3c368c9d0544878d072passed CI 42769256763, including the new publication-continuity and strict helper checks. The source baseline, builder, blank artifact/provenance pins and qualification contract remain unchanged.Keep this PR in draft. Accepting #174 would make this implementation unnecessary; preserve it as a fallback until that decision.
Purpose and current status
Prepare an optional source-built
voldreplacement for LineageOS 24.0 pdx235, increasing only the exFAT fsck timeout from 45 to 120 seconds.This PR remains a draft pending real binary and device qualification. The optional vold module remains default-off, GrapheneOS is excluded, and the approved binary digest, staging tag, and provenance digest remain blank.
Baseline-first contract
The source contract remains pinned to the official
lineage-24.0-20261016-nightly-pdx235-signedOTA, SHA-2568af46661a1440e98018bb2abb155317d6d4ae54e051160f0786b75c1e6806c82, and the complete 1,243-project source manifest.Before applying the timeout patch, the unmodified executable must match the publisher-authenticated OTA's
/system/bin/voldbyte for byte. The patched builder requires the actual baseline binary, authenticated reference, and matching receipt; a receipt alone is insufficient.A registered GitHub runner is optional. The existing local original-vold workflow supports persistent source/vendor acquisition, bounded dependency exploration, compilation, and authenticated comparison. This draft's patched builder currently requires its separate full-manifest baseline receipt and complete source checkout. Those full-manifest commands can run on a suitable local Linux x86_64 host or the optional dedicated Actions runner. A subset receipt must not be relabeled as full-manifest proof.
Previous review refresh
cp2aconfiguration without roomservice downloads.assume-unchangedandskip-worktreeflags that can conceal modified source files.Previous validation
The refreshed combined tree passes 13 Python suites and 9 shell suites, including draft/source/build contracts, diagnostic parsing, device-audit fixtures, local baseline tools, vendor verification, module selection, schedules, workflow routing, ROM fingerprints, and root-mode handling.
Real Bash and Git fixtures cover patch application/rollback, missing fresh output, unexpected source changes, dependency bypass rejection, and hidden tracked-file modifications. YAML parsing, Python compilation, shell syntax, and diff checks also pass. Uploaded blobs and the complete final tree match the locally reviewed tree
d3331c5dea1ddc11b5ac8af767f7a9fb3aa51d61. After incorporating #171, all eight affected shell suites and nine Python suites also passed.The prior refreshed head
c107fee5be55ee6b9d9fc7832237389501bc5b5bpassed repository CI 42531832054. The branch is conflict-free against the mergedmain. The opt-in exact-baseline and paired OTA qualification jobs were skipped in this run, so no real binary or device proof is implied. These local checks are synthetic and orchestration tests. No real Android baseline build, modified OTA qualification, or physical-device acceptance was completed.Remaining qualification
The latest recorded manual baseline run, 39699955476, failed its runner prerequisite and skipped compilation. No newer baseline execution appeared in the manual-run history checked during this review.
Each newer nightly requires fresh source pins, exact-baseline reproduction, and patch qualification. See the full draft contract and local/runner instructions. Do not merge or enable production use merely because synthetic CI passes.