Repository navigation
Fix system-patched Shizuku startup without wireless debugging - #171
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Resolve ROM fingerprint test conflicts while retaining diagnostic, BCR and Shizuku digest coverage. Preserve the Lineage-only BCR policy and default-off Shizuku behavior. Independent adapter, upstream policy and post-boot audit review found no blocking defect. Twelve Python suites and ten shell suites pass on the combined tree, including Shizuku launcher/checker tests and shared build contracts. Physical-device startup acceptance remains documented and outstanding. Uploaded tree matches locally reviewed tree f5b48b9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
ModOS already had an opt-in Shizuku adapter, but its rootless boot path had concrete startup defects: no explicit init-to-shell SELinux transition, a forking native starter whose parent immediately exits under init, and incomplete native libraries for the preinstalled manager. Shizuku's own boot receiver could also enable USB/wireless debugging.
Changes
u:r:shell:s0domain, ADB supplementary groups, and a ten-second restart interval.libadb.so,librish.so,libshizuku.so) for both rootless and Magisk modes.The option remains default-off. Separate rootless and Magisk builds are supported; the existing rejection of
ROOT_MODE=bothremains because those outputs share one product image.Enable the no-debugging boot service
In the existing
[build]section:Manual GrapheneOS single-device/multi-device and LineageOS workflows also accept
shizuku: truewithroot-mode: rootless.Validation
Passed locally:
git diff --check.6e273ab0e991c4e79bc8b1bbb9b9dd739ccac1a8712a541a214078886b7b790f, and parsed the complete native payload for all four ABIs. ARM64 ELF dependencies are system libraries.No complete OTA build or physical-device boot was performed here. The README specifies cold-boot/reboot testing with USB and wireless debugging disabled, client approval checks, and subsequent optional USB diagnostics. Host tests establish source/build behavior, not target-device runtime acceptance.
Upstream basis
Final integration review (2026-11-08)
Resolved conflicts with current main while retaining both Shizuku and diagnostic adapter-digest tests, and incorporated #169's Lineage-only BCR policy. Independent adapter/upstream-policy review and post-boot/identity review found no blocking defect.
The combined tree passes 12 Python suites and 10 shell suites, including Shizuku, diagnostics/device audit, original-vold/source safeguards, configuration, ROM/module selection, schedules, workflows, root modes, Magisk verification, and source care-map policy. Uploaded blobs and the complete tree match the locally reviewed tree
f5b48b9df6ad40435dd94d69fefa64ec4aec1029.Final repository CI 42531829359 passed for head
c8e7d456e40debe750cb7b8025b7267cfd7425a0. Merged after independent review, current-main integration, and the complete repository test job.Shizuku remains default-off. Physical cold-boot, debugging-disabled startup, actual SELinux/Binder behavior, and normal client approval acceptance remain explicitly outstanding.