Skip to content

Keep BCR for LineageOS and exclude it from GrapheneOS - #169

Merged
0cwa merged 4 commits into
mainfrom
integration/bcr-lineage-only-20261108
Nov 8, 2026
Merged

0cwa merged 4 commits into
mainfrom
integration/bcr-lineage-only-20261108

Conversation

@0cwa

@0cwa 0cwa commented Nov 8, 2026 •

Copy link
Copy Markdown
Owner

Why

BCR is still available upstream and in the pinned helper. ModOS currently selects it for both ROM families; the requested policy is to retain it for LineageOS and exclude it from GrapheneOS.

Changes

  • Preserve the signed BCR 3.11 acquisition/verification path, helper pin, and default-on LineageOS behavior for rootless and Magisk builds. Expose the Lineage manual toggle with a true default.
  • Apply a common ROM policy before dependency acquisition, direct patching, helper arguments, and selection fingerprinting. GrapheneOS resolves BCR to false even if an older configuration requests true; malformed booleans still fail before side effects.
  • Set GrapheneOS release and schedule defaults to false. Normalize schedule exports and reusable-workflow inputs, and record the effective selection in release notes.
  • Keep BCR and its version in the existing selection identity. Disabled GrapheneOS records false/disabled and cannot reuse an older BCR-enabled selection.
  • Exercise BCR=true for LineageOS and BCR=false for GrapheneOS in paired nonpublishing CI qualification.

This change builds on the merged #167/#168 diagnostics integration.

Validation

Independent code review completed. Passed module selection/argv and acquisition tests, ROM/fingerprint contracts, scheduled definitions, workflow contracts, Lineage routing, executable-tool routing, declarations, typed configuration, and paired root-mode tests. Regressions cover stale true requests, invalid configuration before side effects, Lineage opt-out, canonical disabled identity, and fresh-shell release reporting. Workflow YAML, shell syntax, and git diff checks pass.

All uploaded blob hashes and the complete tree match the locally reviewed tree 01db66f1c127abe95aa67bac8b6a7b22b06058ca. Full CI and paired nonpublishing OTA qualification 42530216936 passed for head f1391b8e595045ce9a5cd799cd788d008be94ea6. Both source OTAs and rootless/Magisk outputs verified. The LineageOS job verified the signed BCR 3.11 archive and injected BCR; the GrapheneOS job explicitly skipped BCR. Graphene's diagnostic guard passed without warnings; Lineage passed with its three source AVB warnings and no observed output warnings or MSD fallback. Merged after these checks. This does not advance dependency pins or claim new physical-device validation.

0cwa added 4 commits November 7, 2026 21:35
Keep source AVB warnings visible and reject unsafe output warnings, MSD debug fallback, and missing compiled-policy coverage before publication. Disable unqualified pdx235 MSD defaults, add a bounded read-only HAL-label audit, and fingerprint the diagnostic policy.

Consolidate the shared helper compatibility manifest and remove the retired Path-import workaround without modifying the pinned helper or upstream MSD archive.
Recognize the pinned MSD policy tool's load/save warning blocks and older-Android type fallbacks rather than reporting a warning-free build. Scope detail collection to consecutive lines, preserve the existing security-error classification and bounded reporting, and add eleven regression tests.

This is a diagnostic follow-up to PR #167; it does not change signing, module archives, SELinux policy rules, or pdx235 MSD defaults.
…61108

fix: retain unprefixed SELinux build warnings
Resolve BCR against ROM family before downloads, helper arguments, and selection identity. Keep signed BCR 3.11 and default-on Lineage behavior; normalize all Graphene requests to disabled. Align schedules, workflow defaults, CI qualification, and release reporting.

Validated the module, ROM identity, schedule, workflow, configuration, executable routing and root-mode regressions. Uploaded tree matches locally reviewed tree 01db66f.
@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: 1efffa9a-9b22-40cc-9a0f-b26a56da7d31
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@0cwa
0cwa merged commit 2d7c653 into main Nov 8, 2026
6 checks passed
0cwa added a commit that referenced this pull request Nov 8, 2026
Resolve GitHub's ambiguous merge-base conflict after #169 landed. Local git merge-tree produces the already reviewed and CI-passing tree f5b48b9; this commit changes ancestry only.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant