Repository navigation
Keep BCR for LineageOS and exclude it from GrapheneOS - #169
Merged
Merged
Conversation
Keep source AVB warnings visible and reject unsafe output warnings, MSD debug fallback, and missing compiled-policy coverage before publication. Disable unqualified pdx235 MSD defaults, add a bounded read-only HAL-label audit, and fingerprint the diagnostic policy. Consolidate the shared helper compatibility manifest and remove the retired Path-import workaround without modifying the pinned helper or upstream MSD archive.
Recognize the pinned MSD policy tool's load/save warning blocks and older-Android type fallbacks rather than reporting a warning-free build. Scope detail collection to consecutive lines, preserve the existing security-error classification and bounded reporting, and add eleven regression tests. This is a diagnostic follow-up to PR #167; it does not change signing, module archives, SELinux policy rules, or pdx235 MSD defaults.
…61108 fix: retain unprefixed SELinux build warnings
Resolve BCR against ROM family before downloads, helper arguments, and selection identity. Keep signed BCR 3.11 and default-on Lineage behavior; normalize all Graphene requests to disabled. Align schedules, workflow defaults, CI qualification, and release reporting. Validated the module, ROM identity, schedule, workflow, configuration, executable routing and root-mode regressions. Uploaded tree matches locally reviewed tree 01db66f.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
BCR is still available upstream and in the pinned helper. ModOS currently selects it for both ROM families; the requested policy is to retain it for LineageOS and exclude it from GrapheneOS.
Changes
This change builds on the merged #167/#168 diagnostics integration.
Validation
Independent code review completed. Passed module selection/argv and acquisition tests, ROM/fingerprint contracts, scheduled definitions, workflow contracts, Lineage routing, executable-tool routing, declarations, typed configuration, and paired root-mode tests. Regressions cover stale true requests, invalid configuration before side effects, Lineage opt-out, canonical disabled identity, and fresh-shell release reporting. Workflow YAML, shell syntax, and git diff checks pass.
All uploaded blob hashes and the complete tree match the locally reviewed tree
01db66f1c127abe95aa67bac8b6a7b22b06058ca. Full CI and paired nonpublishing OTA qualification 42530216936 passed for headf1391b8e595045ce9a5cd799cd788d008be94ea6. Both source OTAs and rootless/Magisk outputs verified. The LineageOS job verified the signed BCR 3.11 archive and injected BCR; the GrapheneOS job explicitly skipped BCR. Graphene's diagnostic guard passed without warnings; Lineage passed with its three source AVB warnings and no observed output warnings or MSD fallback. Merged after these checks. This does not advance dependency pins or claim new physical-device validation.