Repository navigation
Conversation
Recognize the pinned MSD policy tool's load/save warning blocks and older-Android type fallbacks rather than reporting a warning-free build. Scope detail collection to consecutive lines, preserve the existing security-error classification and bounded reporting, and add eleven regression tests. This is a diagnostic follow-up to PR #167; it does not change signing, module archives, SELinux policy rules, or pdx235 MSD defaults.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the
|
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope and dependency
Focused follow-up to #167, based on its reviewed head
75a028ee3b23c4a118f9a3adf9cbe6f256f5b946. This PR deliberately targetsintegration/msd-build-diagnostics, notmain, so it does not duplicate the existing mitigation or alter that branch before review. Merge this into #167 before promoting the combined change to main, or retarget after #167 lands.Reproduced issue
While reviewing the remaining build-log concerns, I found an additional diagnostic blind spot. The pinned MSD v2.5 policy tool emits these messages without a
WARNprefix:Warnings when loading sepolicy:followed by- ...detail lines;Warnings when saving sepolicy:followed by- ...detail lines;Type not found: <type>; assuming old version of Android.With complete source/output verification markers and a successful helper exit, the previous parser reported
passed, zero warnings for each shape. This was reproduced with synthetic logs matching the upstream spellings; it is not a claim that additional policy warnings occurred in the previously reviewed production runs.Changes
sepolicy_compatibility_fallbackwarnings rather than silently treating the run as warning-free.sudebug fallback, unsafe output/unclassified AVB warnings, missing verification coverage, and helper failures. Policy-warning formatting cannot waive those errors.runtime_validation: not_testedintact. Explain the expanded warning-line counts in the Markdown report.Validation performed
python -m py_compile src/build_diagnostics.py tests/build_diagnostics_test.pypassed.git diff --checkpassed.The full repository CI and real OTA builds were not run locally; the available local environment cannot resolve GitHub for repository/dependency downloads. This PR's normal CI can provide the wider regression check. The existing paired-OTA qualification recorded in #167 belongs to its earlier head, not to this follow-up.
Remaining physical-device boundary
This does not re-enable MSD on pdx235, modify a signed module archive, change SELinux rules or signing policy, or remove the original Lineage source-AVB warnings. #167 remains the primary mitigation. Actual gadget-HAL domain identification, compiled-policy qualification, export/unexport, HAL pause/resume, USB recovery, and AVC inspection on the physical device remain prerequisites to claiming MSD is fixed there. No ROM was flashed or published, and no PR was merged.