Repository navigation
Guard MSD fallbacks and simplify upstream compatibility - #167
Conversation
Keep source AVB warnings visible and reject unsafe output warnings, MSD debug fallback, and missing compiled-policy coverage before publication. Disable unqualified pdx235 MSD defaults, add a bounded read-only HAL-label audit, and fingerprint the diagnostic policy. Consolidate the shared helper compatibility manifest and remove the retired Path-import workaround without modifying the pinned helper or upstream MSD archive.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Recognize the pinned MSD policy tool's load/save warning blocks and older-Android type fallbacks rather than reporting a warning-free build. Scope detail collection to consecutive lines, preserve the existing security-error classification and bounded reporting, and add eleven regression tests. This is a diagnostic follow-up to PR #167; it does not change signing, module archives, SELinux policy rules, or pdx235 MSD defaults.
|
Follow-up review found an additional reporting gap, addressed in #168 (stacked on this PR's current head; this branch is unchanged). The diagnostic guard previously returned #168 retains these diagnostics with bounded, scoped details, preserves the existing fatal MSD/AVB checks and original log streaming, and adds 11 regressions. All 45 diagnostic tests pass locally, along with Python compilation and Recommended review order: merge #168 into this branch, validate the combined head, then consider this PR for main. The pdx235 MSD defaults, module archives and policy rules are unchanged by the follow-up; actual HAL/policy and physical-device functional qualification are still required before re-enabling MSD. No production publication or merge was performed. |
…61108 fix: retain unprefixed SELinux build warnings
Why
The reviewed production jobs completed final OTA verification and publication, but LineageOS pdx235 still emitted source-AVB warnings and MSD v2.5's emulator
sufallback. A successful helper exit was therefore insufficient to describe those logs as clean or to establish correct MSD HAL targeting.What changes
suis rejected. Export/unexport, HAL coordination, USB recovery and AVC inspection remain device checks.Pathimport workaround, and document the remaining upstream boundaries and removal conditions. The helper revision and signed MSD archive are unchanged.Validation
git diff --checkpass.Fresh paired OTA qualification
CI run 42411870728 completed successfully for head
75a028ee3b23c4a118f9a3adf9cbe6f256f5b946. The CI merge checkout07a616d2cea043738cb14683f7a4e9abd5a51c8bhas the exact same tree as the reviewed head. The full test job passed, including the compiled-policy and corresponding-source bundle checks.passed; complete coverage; 0 source/output/unclassified warnings; no fallbackpassed_with_warnings; complete coverage; 3 source AVB warnings, 0 output/unclassified warnings; no MSD injection or fallbackBoth fresh helper logs and retained JSON/Markdown reports were inspected. Reports remain explicit that runtime validation is
not_tested. These were nonpublishing builds; production publication jobs were skipped.Remaining acceptance
This mitigates unqualified MSD delivery; it does not claim that MSD is fixed on pdx235 hardware. The pinned Qualcomm source provides a candidate mapping, but the actual installed domain, compiled policy and functional behavior must be observed before re-enabling MSD. See the qualification checklist and upstream maintenance guide.
Final combined qualification (2026-11-08)
After merging #168, CI run 42529754007 passed for combined head
2272a15781f64f1b17422395830aa5dbc9fc4f9a. The full test job and both nonpublishing paired OTA qualification jobs succeeded. GrapheneOS shiba source and both outputs verified with diagnostic statuspassed. LineageOS pdx235 source and both outputs verified withpassed_with_warnings: three source AVB warnings (AOSP keys/flags), no observed output AVB warnings, and no MSD injection/debug fallback. Physical-device MSD acceptance remains outstanding; pdx235 MSD stays disabled.Merged into main after code review and these checks. The separate Lineage-only BCR policy is tracked in #169.