Skip to content

preserve the published pdx235 Companion signer - #177

Merged
0cwa merged 8 commits into
mainfrom
review/companion-continuity-20261110
Nov 10, 2026
Merged

0cwa merged 8 commits into
mainfrom
review/companion-continuity-20261110

Conversation

@0cwa

@0cwa 0cwa commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

ChatGPT prepared and independently reviewed this publication guard. Final hosted CI passed at exact head 5acf900166c13480ab31e1dc1e52cf1dec96827c.

Why

Both current pdx235 feeds already advertise the rootless/Magisk d349d72 OTAs from run 42754348737. That run built, cryptographically verified and published the ModOS-signed Companion variant. Returning the feeds to the official Companion would change its signer and lower its version code. This guard preserves the published signing identity until an explicit Android migration is reviewed.

Changes

  • Bind the helper's locked module report to each exact final OTA SHA-256 only after every output verifies. Metadata generation and publication reopen that report and check the output binding.
  • Resolve canonical pdx235 and XQ-DC72 rootless/Magisk feeds from one immutable gh-pages commit. Known legacy URLs always require the exact checked-in asset IDs and digests, even if replaced metadata adds newer identity fields.
  • Bind actual upload paths, release tag, selection metadata and proposed feed URLs to the same verified output. Before changing either pointer, also require uploaded OTA, selection and signature digests to match.
  • Refuse signer changes/removal, unknown legacy evidence, API errors, direct alias publication, the wrong ROM family, stale branches and changed feed snapshots. There is no force-publish or environment bypass for migration.
  • Integrate the already-qualified upstream sync from Sync PixeneOS upstream and verify current dependency releases #175 through parent 53e2160594ee06e3c9190e3b0edabf6ff48d5104, preserving its upstream ancestry.

Validation

CI 42768356958 passed at the final guard head. It executed all 20 continuity regressions, strict compatibility checks against the genuine pinned helper, the new executable postflight success/failure regression, and the full existing deterministic suite and endpoint checks.

Independent review confirmed the helper binding on both b553f46 and #173's 902ed62, including refusal to emit a report if either output verification fails. It also checked the live legacy asset IDs/digests and reviewed all publisher routes. The final legacy-relabel and alternate-path/symlink regressions address the review findings. No blocking code findings remain.

The underlying upstream sync separately passed its full test job and real nonpublishing LineageOS and GrapheneOS qualification builds in CI 42764252726. Final reconstructed guard code was executed in hosted CI after the local execution service became unavailable; earlier local checks are not being substituted for that result.

Operational effect

This PR does not edit existing releases, feeds or the schedule. Until #173 is adopted, main's official-Companion selection will be refused at publication because the current feeds already use the custom signer. #173 preserves that existing signer choice. Same-signer updates remain possible; any signer migration needs separate review and Android acceptance evidence.

Successful build/publication checks do not establish physical-device boot, ART behavior, signer/data migration or live billing. See the continuity contract for scope and exact prior-release evidence.

pixincreate and others added 7 commits November 9, 2026 19:16
…create#379)

Co-authored-by: Renovate Bot <renovatebot@non-existent-email.com>
…increate#382)

Co-authored-by: Renovate Bot <renovatebot@non-existent-email.com>
)

Co-authored-by: Renovate Bot <renovatebot@non-existent-email.com>
…ate#380)

Co-authored-by: Renovate Bot <renovatebot@non-existent-email.com>
…te#378)

Co-authored-by: Renovate Bot <renovatebot@non-existent-email.com>
…ocks

Merge all five upstream commits through 7b8a012. Update AFSR 2.1.0, official avbroot 3.39.0, Custota 6.9 and MSD 2.6 with publisher-verified archive/member locks. Renovate 46.3.13 was separately reviewed and merged in #172. Preserve the maintained helper, guarded source verifier and device policies. Record signed-artifact, source, CLI, filesystem, compatibility and deterministic test evidence.
Bind the helper's verified module report to both final OTA hashes. Check exact legacy release receipts, canonical feeds and aliases, incoming selection/output/feed paths, release tags, and uploaded asset digests before publication. Reject signer changes, removal, unknown evidence and direct alias/family bypasses without changing existing releases or feeds.

Reconstructed through GitHub after executor loss. Final validation is pending hosted CI and independent review; this commit is for a draft PR only.
@coderabbitai

coderabbitai Bot commented Nov 10, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: e15d42bf-04b0-4542-9963-4a55aff9da90
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Require exact pinned identities for known legacy OTA URLs even if a replaced selection asset adds modern fields. Exercise this relabel attempt and use genuinely distinct artifact URLs, IDs and bytes for modern publication fixtures. Extend direct upload regressions to alternate directories and symlinks.

Independent review correction; final validation pending hosted CI.
@0cwa
0cwa marked this pull request as ready for review November 10, 2026 06:29
@0cwa
0cwa merged commit 5d6f520 into main Nov 10, 2026
4 checks passed
@0cwa 0cwa changed the title ChatGPT: preserve the published pdx235 Companion signer preserve the published pdx235 Companion signer Nov 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants