Skip to content

Reject hidden source edits in the original vold build gate - #170

Merged
0cwa merged 2 commits into
mainfrom
fix/vold-hidden-source-edits-20261108
Nov 8, 2026
Merged

0cwa merged 2 commits into
mainfrom
fix/vold-hidden-source-edits-20261108

Conversation

@0cwa

@0cwa 0cwa commented Nov 8, 2026

Copy link
Copy Markdown
Owner

Problem

While reviewing draft #157, a real Git regression demonstrated that modified source files marked assume-unchanged or skip-worktree could produce an empty git status and pass the original-build pristine-source gate. The compiler reads those modified bytes even though status hides them.

Change

Require each pinned project to resolve to its own Git worktree and reject these index flags before accepting its clean status. Preserve exact revision, manifest, vendor and output checks. This is a focused fix to the shared original-vold tooling already on main; it does not enable the draft timeout module or waive its real baseline/device requirements.

Validation

Both real Git subtests failed against the old gate and now reject the hidden edits. All 17 original-build tests and 7 baseline-CI tests pass. Independent review confirmed the fix and clean application without draft timeout-module changes. git diff --check passes, and uploaded blobs/tree match the locally validated tree 1808b19a21419e402252dabea7342af7c80f63de.

Repository CI is required before merge. No real Android build or device acceptance is claimed.

Require each pinned source project to be its own Git worktree and reject assume-unchanged/skip-worktree entries before trusting clean status. Real Git regressions reproduce both previously accepted hidden edits.

Validated 17 original-build tests and 7 baseline-CI tests; uploaded tree matches reviewed tree 1808b19.
@coderabbitai

coderabbitai Bot commented Nov 8, 2026 •

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Advanced
  • Run ID: de49a16d-0d2d-491a-8c0f-f207464f4652
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Teach the source-closure command fixture to return the Git worktree root and index state for the stricter clean-source gate. All 13 source-closure tests pass alongside the real Git hidden-edit regression.
@0cwa
0cwa merged commit 4c60755 into main Nov 8, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant