Repository navigation
Reject hidden source edits in the original vold build gate - #170
Merged
Merged
Conversation
Require each pinned source project to be its own Git worktree and reject assume-unchanged/skip-worktree entries before trusting clean status. Real Git regressions reproduce both previously accepted hidden edits. Validated 17 original-build tests and 7 baseline-CI tests; uploaded tree matches reviewed tree 1808b19.
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
|
Teach the source-closure command fixture to return the Git worktree root and index state for the stricter clean-source gate. All 13 source-closure tests pass alongside the real Git hidden-edit regression.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
While reviewing draft #157, a real Git regression demonstrated that modified source files marked
assume-unchangedorskip-worktreecould produce an emptygit statusand pass the original-build pristine-source gate. The compiler reads those modified bytes even though status hides them.Change
Require each pinned project to resolve to its own Git worktree and reject these index flags before accepting its clean status. Preserve exact revision, manifest, vendor and output checks. This is a focused fix to the shared original-vold tooling already on main; it does not enable the draft timeout module or waive its real baseline/device requirements.
Validation
Both real Git subtests failed against the old gate and now reject the hidden edits. All 17 original-build tests and 7 baseline-CI tests pass. Independent review confirmed the fix and clean application without draft timeout-module changes.
git diff --checkpasses, and uploaded blobs/tree match the locally validated tree1808b19a21419e402252dabea7342af7c80f63de.Repository CI is required before merge. No real Android build or device acceptance is claimed.