Repository navigation
feat(onboarding): build medium-tier contract details once - #1557
Merged
gabrielseco merged 4 commits intoOct 15, 2026
Merged
Conversation
Moves POL, NGA, IRL, SWE and NLD onto the jsf v1 build-once path, like #1507 did for the high tier. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (291 total)
✅ Bundle size check passed |
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report
|
| Metric | Current | Previous | Change | Status |
|---|---|---|---|---|
| Lines | 89.58% | 89.59% | -0.02% | 🔴 |
| Statements | 89.45% | 89.47% | -0.02% | 🔴 |
| Functions | 88.48% | 88.48% | 0% | ⚪ |
| Branches | 81.21% | 81.24% | -0.02% | 🔴 |
Detailed Breakdown
Lines Coverage
- Covered: 5396 / 6024
- Coverage: 89.58%
- Change: -0.02% (-1 lines)
Statements Coverage
- Covered: 5461 / 6105
- Coverage: 89.45%
- Change: -0.02% (-1 statements)
Functions Coverage
- Covered: 1428 / 1614
- Coverage: 88.48%
- Change: 0% (0 functions)
Branches Coverage
- Covered: 3350 / 4125
- Coverage: 81.21%
- Change: -0.02% (-1 branches)
✅ Coverage check passed
gabrielseco
marked this pull request as ready for review
October 14, 2026 03:25
…t doc Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
jordividaller
approved these changes
Oct 15, 2026
gabrielseco
deleted the
workbench/g-2026-10-14-jsf-v1-pol-nga-irl-swe-nld
branch
October 15, 2026 14:07
This was referenced Oct 16, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contract details for Poland, Nigeria, Ireland, Sweden and the Netherlands (the
mediumtier), plus Australia, Mexico, South Africa, Malaysia and the Dominican Republic, now use the newer form engine that builds the form once, like the high-tier countries do since #1507.Why
We're moving contract details onto the build-once path country by country. The first five are the
mediumtier inscripts/reports/embedded-integration-country-tiers.json. AUS and MEX are alsomedium; ZAF, MYS and DOM arelow. All ten already have their example-app version bumps merged, so this is the second step of the rollout and can be reverted on its own.What changed
Toggle details
src/flows/Onboarding/utils.ts: addsPOL,NGA,IRL,SWE,NLD,ZAF,AUS,MYS,DOM,MEXtoJSF_V1_CONTRACT_DETAILS_COUNTRIES.usesJsfV1ContractDetailsnow routes them touseContractDetailsSchema.src/flows/Onboarding/tests/utils.test.ts: folds theusesJsfV1ContractDetailsexpectations into one parameterized case covering every country on the build-once path, including the ten new ones.docs/USE_HEADLESS_FORM_ROLLOUT.md: records this batch against feat(onboarding): build medium-tier contract details once #1557. The table is reflowed byoxfmt, so the diff there is wider than the one-row change.No public API change. The list is internal.
Example app pins on
main:Not compared against the latest backend schemas by hand; the schema canary report is the source for that.
Screenshots
N/A
Related Resources
scripts/reports/embedded-integration-country-tiers.jsonTesting
example/app in a browser. Not done yet: feat(onboarding): build high-tier contract details once #1507 checked each country's contract details step (empty submit, fill and save, reload, resubmit, money in cents). That still needs doing for the ten countries above.Unit tests were not run locally; CI covers them.
🤖 Generated with Claude Code
Note
Medium Risk
Contract details form lifecycle and money handling differ between rebuild and buildOnce; ten countries switch paths without browser QA noted in the PR description.
Overview
Ten more onboarding countries now take the build-once contract details path (
useContractDetailsSchema) instead of the legacy rebuild flow: medium tier POL, NGA, IRL, SWE, NLD plus AUS, MEX, ZAF, MYS, DOM.The change is a single internal allowlist update in
JSF_V1_CONTRACT_DETAILS_COUNTRIESinutils.ts, which drivesusesJsfV1ContractDetailsandgetContractDetailsStrategy. Unit tests fold all build-once countries into one parameterizedusesJsfV1ContractDetailscase. The headless-form rollout doc records this batch as #1557 (table reflow is formatting only).No public API changes; behaviour for countries still on the list (e.g. FRA, CAN) is unchanged.
Reviewed by Cursor Bugbot for commit 129f6b0. Bugbot is set up for automated code reviews on this repo. Configure here.