Repository navigation
chore(example): bump NLD contract_details schema version to 6 - #1524
Merged
Merged
Conversation
Pin the Netherlands to contract_details v6 in the example app and document v3-v6 in the NLD schema changelog and the version matrix. Also fixes the NLD guide intro, which said Nigeria. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
jordividaller
approved these changes
Oct 13, 2026
This was referenced Oct 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The example app now uses the Netherlands' latest contract details form (v6), and the NLD schema changelog covers v3-v6.
Why
NLD.mdalso said "Nigeria" in its intro.What changed
Toggle details
jsonSchemaVersions.ts: NLDcontract_details2 → 6.schemaVersions.ts: unchanged, because it already lists NLD v1–v6.NLD.mdgains v3–v6 sections (v6 marked current), its intro now says Netherlands, and the README version matrix row is updated. NLD was already in the README migration list. Each entry is based on tiger'sversion_changelog(v4–v6) or a diff of the tiger snapshots (v3):work_hours_per_weekandholiday_allowance); can reject part-time salaries accepted on v2annual_gross_salary_fieldsetcontract_duration_type,contract_end_datenested reference becomesnested_fields(a list)Screenshots
N/A
Related Resources
c5213c4f(v3, part-time prorated minimum),546122a2(v4, annual gross salary component and reserve messaging),0e1d9044(v5, extreme salary acknowledgement),5ce44da9(v6, seniority block)Testing
example/app in a browsernpm run schema-canary -- --country=NLD --versions=pinned,latestagainst sandbox: build and submit pass on both v6 (pinned, run after the bump) and latesteor_seniority_block,eor_seniority_block_v2_ftc(v6 seniority block); extreme-salary acknowledgement (v5)🤖 Generated with Claude Code
Note
Low Risk
Documentation and example-app pin only; partners’ production behavior is unchanged unless they adopt the new pin or migration notes themselves.
Overview
Pins the example onboarding flow to Netherlands contract details v6 (was v2) and documents what changed in v3–v6 for integrators upgrading from older pins.
Docs:
NLD.mdnow lists v3–v6 (prorated part-time minimum salary—breaking for submits on v3; shared salary fieldset and reserve messaging on v4; extreme-salary acknowledgement on v5; seniority-based fixed-term restrictions, no defaultcontract_duration_type, andnested_field→nested_fieldson v6). The intro typo (“Nigeria”) is fixed, and the country README matrix shows NLD at v6 (October 2026).Code: Only
example/src/flows/Onboarding/jsonSchemaVersions.tschanges (NLD.contract_details: 6). No SDK or public API changes.Reviewed by Cursor Bugbot for commit e887dbc. Bugbot is set up for automated code reviews on this repo. Configure here.