Skip to content

chore(example): bump NGA contract_details schema version to 5 - #1525

Merged
gabrielseco merged 2 commits into
mainfrom
chore/bump-nga-contract-details-v5
Oct 13, 2026
Merged

gabrielseco merged 2 commits into
mainfrom
chore/bump-nga-contract-details-v5

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Oct 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The example app now uses the Netherlands' latest contract details form (v6), and the NLD schema changelog covers v3-v6.

Why

  • NLD was still pinned to v2 while the backend is on v6.
  • Pinning the example to latest makes us run the form partners will get when they upgrade.
  • NLD.md also said "Nigeria" in its intro.

What changed

Toggle details
  • jsonSchemaVersions.ts: NLD contract_details 2 → 6.
  • schemaVersions.ts: unchanged, because it already lists NLD v1–v6.
  • Docs: NLD.md gains v3–v6 sections (v6 marked current), its intro now says Netherlands, and the README version matrix row is updated. NLD was already in the README migration list. Each entry is based on tiger's version_changelog (v4–v6) or a diff of the tiger snapshots (v3):
    • v3: prorated minimum annual gross salary for part-time employees (based on work_hours_per_week and holiday_allowance); can reject part-time salaries accepted on v2
    • v4: high-salary reserve messaging, salary fields grouped in annual_gross_salary_fieldset
    • v5: extreme-salary acknowledgement
    • v6: seniority block on fixed-term contracts, no default for contract_duration_type, contract_end_date nested reference becomes nested_fields (a list)
  • No public API change.

Screenshots

N/A

Related Resources

  • Tiger commits that cut each version: c5213c4f (v3, part-time prorated minimum), 546122a2 (v4, annual gross salary component and reserve messaging), 0e1d9044 (v5, extreme salary acknowledgement), 5ce44da9 (v6, seniority block)

Testing

  • Tested against the example/ app in a browser
  • npm run schema-canary -- --country=NLD --versions=pinned,latest against sandbox: build and submit pass on both v6 (pinned, run after the bump) and latest
  • Feature flag: eor_seniority_block, eor_seniority_block_v2_ftc (v6 seniority block); extreme-salary acknowledgement (v5)

🤖 Generated with Claude Code


Note

Low Risk
Documentation and example version pinning only; contract validation changes apply when integrators opt into newer schema versions.

Overview
Pins the example onboarding flow to Nigeria contract_details v5 (jsonSchemaVersions.ts: 2 → 5) so local testing matches the latest backend schema.

Docs now treat v5 as current for NGA: NGA.md adds migration-oriented notes for v3 (high-salary reserve messaging, jsf v1, salary fieldset grouping), v4 (extreme high-salary acknowledgement), and v5 (seniority-date block on fixed-term contracts / contract_end_date, flag-gated). The country README version matrix row is updated to v5 and October 2026.

No public SDK API changes—only example configuration and schema changelog documentation.

Reviewed by Cursor Bugbot for commit ab29561. Bugbot is set up for automated code reviews on this repo. Configure here.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-bsk1l9cgh-remotecom.vercel.app
Latest Commit:ab29561

Deployed with vercel-action

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-cpgreq9qd-remotecom.vercel.app
Latest Commit:ab29561

Deployed with vercel-action

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

📊 Coverage Report

⚪ Coverage unchanged

Metric Current Previous Change Status
Lines 89.58% 89.58% 0% ⚪
Statements 89.46% 89.46% 0% ⚪
Functions 88.47% 88.47% 0% ⚪
Branches 81.21% 81.21% 0% ⚪

Detailed Breakdown

Lines Coverage
  • Covered: 5393 / 6020
  • Coverage: 89.58%
  • Change: 0% (0 lines)
Statements Coverage
  • Covered: 5458 / 6101
  • Coverage: 89.46%
  • Change: 0% (0 statements)
Functions Coverage
  • Covered: 1427 / 1613
  • Coverage: 88.47%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 3345 / 4119
  • Coverage: 81.21%
  • Change: 0% (0 branches)

✅ Coverage check passed

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@gabrielseco
gabrielseco merged commit e947134 into main Oct 13, 2026
14 checks passed
@gabrielseco
gabrielseco deleted the chore/bump-nga-contract-details-v5 branch October 13, 2026 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants