Skip to content

chore(example): bump ZAF contract_details schema version to 5 - #1563

Merged
gabrielseco merged 3 commits into
mainfrom
chore/bump-zaf-contract-details-v5
Oct 14, 2026
Merged

gabrielseco merged 3 commits into
mainfrom
chore/bump-zaf-contract-details-v5

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The example app now uses South Africa's latest contract details form (v5). South Africa also gets its own schema changelog.

Why

  • ZAF was still pinned to v1 while the backend is on v5.
  • Pinning the example to latest makes us run the form partners will get when they upgrade.

What changed

Toggle details
  • jsonSchemaVersions.ts: ZAF contract_details 1 → 5.
  • schemaVersions.ts: unchanged, because it already lists ZAF v1–v5.
  • Docs: new ZAF.md covering v2–v5, plus South Africa in the README's migration list and version matrix. Tiger carries a changelog only for v5 (in ZAF.ex); v2–v4 are inferred from the snapshot diffs and tiger commit messages.
    • v2: reserve messaging on annual_gross_salary and a fieldset with part_time_salary_confirmation; jsf v1 engine.
    • v3: extreme-salary acknowledgement, flag-gated.
    • v4: self-serve fixed-term capped at 12 months (contract_duration_fixed_term_months required for fixed_term); probation_period max drops from 6 to 3 months for non-admins, with a warning.
    • v5 (tiger): fixed-term blocked when seniority is recognized (Remote Admins exempt, flags eor_seniority_block, eor_seniority_block_v2_ftc); contract duration moves to the shared contract_duration component and the contract_duration_type / contract_end_date definitions are removed (inferred).
  • Breaking for submits: v4 caps fixed-term at 12 months and probation at 3 months for non-admin requests; v5 blocks fixed-term when seniority is recognized.
  • Tiger's root ZAF schema is the current v5 (snapshots 1–4 are frozen), so v5 is latest and nothing is ahead.
  • No public API change.

Screenshots

N/A

Related Resources

  • Tiger snapshots: apps/tiger/priv/json_schemas/contract_details/snapshots/ZAF/{1..4}.json plus root ZAF.json for v5
  • Tiger commits: 95bb50a9 (FTC cap and probation guardrails), c2665f7d (seniority block), 07d3080d (allOf merge order)

Testing

  • Tested against the example/ app in a browser
  • npm run schema-canary -- --country=ZAF --checks=pinned,latest,submit against sandbox after the bump (pinned v5, latest, submit v5): all pass.

🤖 Generated with Claude Code


Note

Low Risk
Documentation and example-app version pinning only; no production API or auth changes in this diff.

Overview
Aligns the example onboarding app with South Africa’s current EOR contract-details schema by bumping ZAF contract_details from v1 to v5 in jsonSchemaVersions.ts, so local flows match what partners see on the latest backend form.

Adds South Africa contract-details documentation: a new ZAF.md changelog (v2–v5, with v5 as current) and entries in the countries README list and version matrix (v5, October 2026). The doc highlights behavioral deltas integrators care about when upgrading—e.g. v4’s 12-month fixed-term cap and shorter non-admin probation max, and v5’s seniority-based fixed-term blocking plus migration to the shared contract_duration component.

Reviewed by Cursor Bugbot for commit ccae355. Bugbot is set up for automated code reviews on this repo. Configure here.

gabrielseco and others added 2 commits October 14, 2026 05:43
Pin South Africa to contract_details v5 in the example app and document
v2-v5 in a new ZAF schema changelog, the migration list and the version
matrix.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-rd00has8b-remotecom.vercel.app
Latest Commit:ccae355

Deployed with vercel-action

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-me7gi8dki-remotecom.vercel.app
Latest Commit:ccae355

Deployed with vercel-action

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage Report

⚪ Coverage unchanged

Metric Current Previous Change Status
Lines 89.58% 89.58% 0% ⚪
Statements 89.46% 89.46% 0% ⚪
Functions 88.47% 88.47% 0% ⚪
Branches 81.21% 81.21% 0% ⚪

Detailed Breakdown

Lines Coverage
  • Covered: 5393 / 6020
  • Coverage: 89.58%
  • Change: 0% (0 lines)
Statements Coverage
  • Covered: 5458 / 6101
  • Coverage: 89.46%
  • Change: 0% (0 statements)
Functions Coverage
  • Covered: 1427 / 1613
  • Coverage: 88.47%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 3345 / 4119
  • Coverage: 81.21%
  • Change: 0% (0 branches)

✅ Coverage check passed

@gabrielseco
gabrielseco merged commit cf75520 into main Oct 14, 2026
14 checks passed
@gabrielseco
gabrielseco deleted the chore/bump-zaf-contract-details-v5 branch October 14, 2026 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants