Repository navigation
feat(onboarding): build high-tier contract details once - #1507
Merged
Merged
Conversation
Move CAN, GBR, IND, PHL and USA contract details onto the jsf v1 path (useContractDetailsSchema, built once with useHeadlessForm). These are the high-tier countries for the embedded integration. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
📦 Bundle Size Report
Size Limits
Largest Files (Top 5)
View All Files (291 total)
✅ Bundle size check passed |
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Contributor
|
Deploy preview for remote-flows ready!
Deployed with vercel-action |
Contributor
|
Deploy preview for adp-cost-calculator ready!
Deployed with vercel-action |
Contributor
📊 Coverage Report⚪ Coverage unchanged
Detailed BreakdownLines Coverage
Statements Coverage
Functions Coverage
Branches Coverage
✅ Coverage check passed |
…details-high-tier
cammellos
approved these changes
Oct 13, 2026
Merged
jordividaller
approved these changes
Oct 13, 2026
2 tasks
gabrielseco
added a commit
that referenced
this pull request
Oct 15, 2026
* feat(onboarding): build medium-tier contract details once Moves POL, NGA, IRL, SWE and NLD onto the jsf v1 build-once path, like #1507 did for the high tier. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> * update countries * docs(headless-form): record medium tier and extra countries in rollout doc Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Sonnet 5.5 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Contract details for Canada, the United Kingdom, India, the Philippines and the United States now use the newer form engine that builds the form once, like France, Italy, Germany and Spain already do.
Why
We're moving contract details onto the build-once path country by country, starting with the countries the embedded integration uses most. These five are the
hightier inscripts/reports/embedded-integration-country-tiers.json.The rollout covers five countries a week in two steps:
contract_detailspin to latest.This PR is the build-once step for the high tier. It's kept separate from the version bumps so either one can be reverted on its own.
What changed
Toggle details
src/flows/Onboarding/utils.ts: addsCAN,GBR,IND,PHL,USAtoJSF_V1_CONTRACT_DETAILS_COUNTRIES.usesJsfV1ContractDetailsnow routes these countries touseContractDetailsSchemainstead of the legacy contract details path.src/flows/Onboarding/tests/utils.test.ts: covers the five new countries.No public API change. The list is internal.
Example app pins compared with tiger's latest, as of 2026-10-12:
All five are on latest. The version bumps for CAN, IND, PHL and USA have merged into
main, so this PR moves them onto the build-once path against their latest schemas.Screenshots
N/A
Related Resources
scripts/reports/embedded-integration-country-tiers.jsonTesting
example/app in a browser (contract details step for each of CAN, GBR, IND, PHL, USA)contract_detailsmatch what was sent.🤖 Generated with Claude Code
Note
Medium Risk
Switches contract-details form strategy for five production countries, affecting money handling and conditional-field behavior; rollout assumes schema version pins are bumped separately first.
Overview
Onboarding contract details for Canada, UK, India, Philippines, and the US now follow the same build-once path as France, Italy, Germany, and Spain, by extending
JSF_V1_CONTRACT_DETAILS_COUNTRIESinutils.tssousesJsfV1ContractDetails/getContractDetailsStrategyreturnbuildOnceinstead of the legacy rebuild hook.Unit tests assert those five codes are treated as jsf v1. The headless-form rollout doc is updated to record the high-tier migration (#1507) and the phased country move off
useLegacyContractDetailsSchema.Reviewed by Cursor Bugbot for commit 17b6ed7. Bugbot is set up for automated code reviews on this repo. Configure here.