Skip to content

chore(example): bump DOM contract_details schema version to 6 - #1560

Merged
gabrielseco merged 2 commits into
mainfrom
chore/bump-dom-contract-details-v6
Oct 14, 2026
Merged

gabrielseco merged 2 commits into
mainfrom
chore/bump-dom-contract-details-v6

Conversation

@gabrielseco

@gabrielseco gabrielseco commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

The example app now uses the Dominican Republic's latest contract details form (v6). The Dominican Republic also gets its own schema changelog.

Why

  • DOM was still pinned to v1 while the backend is on v6.
  • Pinning the example to latest makes us run the form partners will get when they upgrade.

What changed

Toggle details
  • jsonSchemaVersions.ts: DOM contract_details 1 → 6.
  • schemaVersions.ts: unchanged, because it already lists DOM v1–v6.
  • Docs: new DOM.md covering v2–v6, plus the Dominican Republic in the README's migration list and version matrix. Tiger has no x-rmt-schema-changelog for DOM, so entries are inferred from snapshot diffs (and tiger commit messages).
    • v2: schema metadata only (old JSF engine marker).
    • v3: reserve messaging and fieldset on annual_gross_salary.
    • v4: jsf v1 engine.
    • v5: contract_duration_type replaced by the dom_contract_duration component; fixed-term blocked when seniority is recognized, Remote Admins exempt (flag-gated).
    • v6: extreme-salary acknowledgement.
  • Possibly breaking for submits: v5 removes the standalone contract_duration_type field and its fixed-term options.
  • Tiger's snapshots end at v5, so v6 is the current root schema (not a frozen snapshot yet).
  • No public API change.

Screenshots

N/A

Related Resources

  • Tiger snapshots: apps/tiger/priv/json_schemas/contract_details/snapshots/DOM/{2..5}.json plus the current DOM.json (v6)

Testing

  • Tested against the example/ app in a browser
  • npm run schema-canary -- --country=DOM --checks=pinned,latest,submit against sandbox after the bump (pinned v6, latest, submit v6): all pass.

🤖 Generated with Claude Code


Note

Low Risk
Documentation and example-app version pinning only; no library or API changes, though the documented v5 schema shift may affect DOM submit payloads when partners upgrade.

Overview
The example onboarding app now pins Dominican Republic (DOM) contract_details from v1 to v6, aligning the demo with the current backend schema.

Docs: Adds DOM.md with migration notes for v2–v6 (JSF engine upgrades, salary reserve messaging, dom_contract_duration replacing contract_duration_type, extreme-salary acknowledgement) and lists DOM in the country README migration index and version matrix (v6, October 2026).

Integrators upgrading past v5 should expect submit payload changes around contract duration fields; most intermediate steps are documented as flag-gated or additive.

Reviewed by Cursor Bugbot for commit 04917b7. Bugbot is set up for automated code reviews on this repo. Configure here.

gabrielseco and others added 2 commits October 14, 2026 05:43
Pin the Dominican Republic to contract_details v6 in the example app and
document v2-v6 in a new DOM schema changelog, the migration list and the
version matrix.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Deploy preview for remote-flows ready!

Project:remote-flows
Status: ✅  Deploy successful!
Preview URL:https://remote-flows-klh9wqghe-remotecom.vercel.app
Latest Commit:04917b7

Deployed with vercel-action

@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Deploy preview for adp-cost-calculator ready!

Project:adp-cost-calculator
Status: ✅  Deploy successful!
Preview URL:https://adp-cost-calculator-8n5yuiy34-remotecom.vercel.app
Latest Commit:04917b7

Deployed with vercel-action

@github-actions

Copy link
Copy Markdown
Contributor

📊 Coverage Report

⚪ Coverage unchanged

Metric Current Previous Change Status
Lines 89.58% 89.58% 0% ⚪
Statements 89.46% 89.46% 0% ⚪
Functions 88.47% 88.47% 0% ⚪
Branches 81.21% 81.21% 0% ⚪

Detailed Breakdown

Lines Coverage
  • Covered: 5393 / 6020
  • Coverage: 89.58%
  • Change: 0% (0 lines)
Statements Coverage
  • Covered: 5458 / 6101
  • Coverage: 89.46%
  • Change: 0% (0 statements)
Functions Coverage
  • Covered: 1427 / 1613
  • Coverage: 88.47%
  • Change: 0% (0 functions)
Branches Coverage
  • Covered: 3345 / 4119
  • Coverage: 81.21%
  • Change: 0% (0 branches)

✅ Coverage check passed

@gabrielseco
gabrielseco merged commit 9f7da95 into main Oct 14, 2026
14 checks passed
@gabrielseco
gabrielseco deleted the chore/bump-dom-contract-details-v6 branch October 14, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants