Repository navigation
[access] test(backgroundjob): cover eight zero-coverage background jobs - #7523
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5
|
The red Newman API Test Suite check does not come from this PR. It fails at the step "PHPUnit unit suite (in-container, HARD GATE)". That step currently fails the same way on every PR, including JS-only ones such as #7510.
The 48 extra tests are exactly this PR's 48 new tests, and all of them pass. The failing tests are No fix exists yet, and it belongs in its own PR. #7519 has the details. Generated by Claude Code |
|
The red quality / … checks ( This PR only adds PHP test files under
#7519 has the evidence for each check. Each needs its own fix on Generated by Claude Code |
|
The quality / PHP Quality (phpcs) and quality / Hydra Gates checks fail for reasons outside this PR, which only adds files under
Both are standing debt on Generated by Claude Code |
|
The quality / PHP Quality (phpmd) check isn't red because of this PR either. The repo's Generated by Claude Code |
|
If the quality / Frontend Tests (unit) check (the jest suite) is red, this PR is not the cause. The PR adds only PHPUnit files under Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49083/49093 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 13:08 UTC
Download the full PDF report from the workflow artifacts.
SIG coverage round t1, lane T04: PHP unit tests for background jobs.
Covered
This PR adds new test files only and changes no production code. The new tests carry no
@coversor#[CoversClass].phpunit.xmlsetsbeStrictAboutCoverageMetadata=true, and that is why the existingConnectionSeamReportJobTestandImportPreviewRunnerGoldenTestrecord 0: they execute classes that are missing from their@useslists, so PHPUnit marks them risky and discards their coverage.BulkLegalHoldJob is left at 48% on purpose. Lines 79–95 look wrong. The job calls
MagicMapperInterface::findAll(filters: [], schema: $schemaId, _rbac: false, _multitenancy: false), butMagicObjectFinderInterface::findAllhas no_rbacor_multitenancyparameter, and itsschemaparameter takes a?Schemaentity, not an id. PHP therefore throwsError(unknown named parameter).catch (Exception)does not catch anError, so no legal hold is ever placed. A test of that path would pin the bug, so this PR only covers the refusal path and the catch path. The bug needs its own fix.Ran
php -d pcov.enabled=1 -d pcov.directory=lib vendor/bin/phpunit -c phpunit.xml --coverage-clover /tmp/jobs.xml --filter '<the 8 new test classes>' tests/Unit/BackgroundJob: OK (48 tests, 94 assertions), 0 risky. This was a subset run, so the coverage figures are a lower bound.weak.phpover tests/Unit/BackgroundJob reports none of the new files.Mutation samples (each reverted)
$others === []->!== []-> 5 tests failed$interval < MIN-><=-> 1 test failed$swept < SWEEP_BATCH-><=-> 3 tests failed=== null->!== null-> 4 tests failed=== PHASE_COMMIT->!==-> 6 tests failed=== ''->!== ''-> 5 tests failed!== []->=== []-> 2 tests failed|| $summary['failed'] > 0-> 1 test failedThe tests were written with Claude Code.
Generated by Claude Code