Repository navigation
test(apphost): cover store installer, store sources, document loader, feature toggles, bootstrap and calendar transformer gaps - #7584
Conversation
…document loader, feature toggles, bootstrap and calendar transformer gaps Assisted-by: ClaudeCode:claude-opus-5-5
|
The red Newman API Test Suite check is not caused by this PR. The check fails at the step "PHPUnit unit suite (in-container, HARD GATE)". That step is currently red on every PR with the same result: 11 errors, 11 failures and 1 warning. Compare #7510, a JS-only PR (49064 tests). This run had 49099 tests and the same 11 / 11 / 1, so none of this PR's new tests failed. The failures are in tests this PR doesn't touch: Generated by Claude Code |
|
This PR only adds PHP test files, so the quality / … checks that are red on it are failing for reasons that come from
The evidence is in #7519. Each check needs its own fix on Generated by Claude Code |
|
This adds to my earlier comment. Three more checks are red for reasons outside this PR:
This PR changes only Generated by Claude Code |
|
The red quality / Frontend Tests (unit) check (the jest suite) is not caused by this PR. This PR adds only PHPUnit files under Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49070/49080 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 18:10 UTC
Download the full PDF report from the workflow artifacts.
SIG coverage round t1, lane T04: PHP unit tests for the AppHost store and services, plus the calendar transformer.
Covered
This PR adds new test files only. It changes no production code and adds no coverage metadata.
Bootstrap measurement.
BootstrapBehaviourTestcovers lines 371–376, the store-controller factory. Those lines show as uncovered whenever the pre-existing riskyBootstrapAdminSettingsCharacterisationTestruns in the same process. The 238/239 figure comes from--filter 'BootstrapBehaviourTest|BootstrapTest|BootstrapFactoryChainTest'.Left uncovered
[Area/City].new DateTime()rejects those strings, so the catch fallback always runs first."2026-01-01 10:00:00 Europe/Amsterdam"is formatted as20260101T100000Z. This needs its own fix.file_get_contentsreturningfalsecannot be reached without a file-read seam.glob()returningfalse, (b).idOf()given a non-array, (b). The caller always passes an array.preg_splitreturningfalseor empty, (b).Ran
php -d pcov.enabled=1 -d pcov.directory=lib vendor/bin/phpunit -c phpunit.xml --coverage-clover ... --filter '<classes>' tests/Unit/AppHost tests/Unit/Calendar: OK (128 tests, 317 assertions).GenericStoreServiceTestandRegisterDescriptorServiceTest, also pass. The figures above are from subset runs, so they are a lower bound.weak.phpreports none of the new files.Mutation samples (each reverted)
'error'->'installed'-> 1 test failed'DATE'->'DATE-TIME'-> 1 test failed$complete = false->true-> 1 test failedOUTCOME_OKinstead of the lookup's outcome -> 1 test failed>= 300->>= 600-> 2 tests failedappName: $appId->'x'-> 1 test failed=== false->=== true-> 1 test failedgetKeyreturns appId -> 1 test failedThe tests were written with Claude Code.
Generated by Claude Code