Repository navigation
[access] test(command): cover eight occ commands to 100% statements - #7519
Conversation
Assisted-by: ClaudeCode:claude-opus-5-5
…s import commands Assisted-by: ClaudeCode:claude-opus-5-5
…ft pass Assisted-by: ClaudeCode:claude-opus-5-5
|
The red Newman API Test Suite check is not caused by this PR. It fails in the step "PHPUnit unit suite (in-container, HARD GATE)". The same 11 errors, 11 failures and 1 warning show up on unrelated PRs that day, including the JS-only #7510 (run 42568091384). Those failures are in
The 50 extra tests are exactly this PR's 50 new tests, and all of them pass. Locally, Generated by Claude Code |
|
The red quality / Frontend Check (test:l10n:parity) check isn't caused by this PR. This PR only adds files under The same failure happens on plain A recently merged change added that English string to Generated by Claude Code |
|
The red quality / Vue Quality (eslint) check doesn't come from this PR. This PR adds only PHP test files, and eslint does not lint PHP. The run reports 16 errors, all in files outside this PR. For example, The fix belongs in its own PR. None exists yet. Generated by Claude Code |
|
The red quality / Frontend Check (test:l10n) and quality / Frontend Check (format) checks are not caused by this PR either. This PR only adds PHP test files under
Both need their own fixes on Generated by Claude Code |
|
The red quality / PHP Quality (phpstan) check is not caused by this PR. phpstan only analyses Generated by Claude Code |
|
The red quality / PHP Quality (psalm) check doesn't come from this PR either. Generated by Claude Code |
|
The red quality / Hydra Gates check is not caused by this PR either. The 7 failing gates all inspect production code under
The findings are standing debt on Generated by Claude Code |
|
This PR does not cause the red quality / PHP Quality (phpcs), quality / PHP Quality (phpmd) or quality / Frontend Tests (unit) checks. This PR only adds files under
All three failures come from Generated by Claude Code |
|
The red quality / Integration Tests (Newman) check is not caused by this PR either. That job runs the Postman collections against a booted app built from The job log shows production-side errors. One example is Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49085/49095 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 13:05 UTC
Download the full PDF report from the workflow artifacts.
SIG coverage round t1, lane T04: PHP unit tests for console commands.
Covered
New test files only, with no production changes. None of them carries
@coversor#[CoversClass].phpunit.xmlsetsbeStrictAboutCoverageMetadata=true, and that setting is why several existing tests for these classes record 0 coverage: they execute classes that are not in their@useslist, so PHPUnit marks them risky and discards their coverage.The tests drive each command through
CommandTesterand assert the exit code, the exact output and the exact service calls and arguments. Only the injected interfaces are mocked. Every early return, refusal and catch has its own test.Ran
php -d pcov.enabled=1 -d pcov.directory=lib vendor/bin/phpunit -c phpunit.xml --coverage-clover /tmp/cmd.xml --filter '<the 8 new test classes>' tests/Unit/Command: OK (50 tests, 175 assertions), 0 risky.clover_files.pyon the result gives 310/310. This is a subset run, so it is a lower bound on the full-suite number.weak.phpover tests/Unit/Command reports none of the new files.Mutation samples (each reverted)
$write === false->=== true-> 2 tests failed$rowCount < 0->< -1-> 1 test failed$map === []->!== []-> 2 tests failedmembers === 0->=== -1-> 2 tests failed|| $report['empty'] > 0-> 1 test failedisEmpty(...) === true->=== false-> 1 test failedreturn true->return falsein isNote -> 1 test failed!==->===in the option filter -> 3 tests failedcatch InvalidArgumentException->catch \DomainException-> 1 test failedmin(..., MAX_REMOVALS)cap -> 1 test failedThe tests were written with Claude Code.
Generated by Claude Code