Repository navigation
[access] test(command): cover reconcile/purge/backfill command gaps, three maintenance jobs and the class alias map - #7556
Conversation
…e maintenance jobs and the class alias map Assisted-by: ClaudeCode:claude-opus-5-5
|
The red Newman API Test Suite check on this PR has 12 failures. The baseline that all PRs share has 11. The extra failure is this PR's own test, The test assumes no The fix is in #7640. That PR contains this PR's commit plus a one-line test change: the test now checks that an eager-only map adds no registration, instead of expecting a count of zero. The lane rules don't allow pushing to an open PR, so please merge #7640 instead of this one. The other 11 failures are the shared baseline described on #7519. Generated by Claude Code |
|
This PR adds only PHP test files. None of the red quality / … checks come from it; they are failing on
The evidence is in #7519 and #7523. This PR's one real defect is the Generated by Claude Code |
…oted [access] test(appinfo): let the class alias map test run inside a booted app (supersedes #7556)
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ 49058/49069 · 19 skipped | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 16:36 UTC
Download the full PDF report from the workflow artifacts.
SIG coverage round t1, lane T04: PHP unit tests for maintenance commands and jobs. The
[access]prefix is there because the purge command deletes objects and the group reconciler handles RBAC groups.Covered
This PR only adds new test files; it changes no production code and adds no coverage metadata.
Notes:
ConsistencyCheckJobstampsranAtwithnew DateTime(), which is not injectable. The test therefore checks only the ATOM format of that value, never the value itself. Pinning the exact value would need a production seam: using the injectedITimeFactorywould provide one.ClassAliasMapkeeps a process-wide static "autoloader registered" flag, so its coverage depends on which tests ran before it. The new tests run in separate processes, which makes their count stable whatever the order.Ran
php -d pcov.enabled=1 -d pcov.directory=lib vendor/bin/phpunit -c phpunit.xml --coverage-clover /tmp/cj.xml --filter '<new + existing tests for these classes>' tests/Unit/Command tests/Unit/BackgroundJob tests/Unit/AppInfo: OK (50 tests, 146 assertions). This is a subset run, so its coverage is a lower bound.weak.phpreports none of the new files.Mutation samples (each reverted)
!== (int)$registerFilter->===-> 1 test failedwritten++->written---> 2 tests failed'{}'->'null'-> 1 test failedself::$lazy !== []condition -> 1 test failedThe tests were written with Claude Code.
Generated by Claude Code