Repository navigation
[access] test(apphost): cover the generic AppHost controllers and deep-link listener - #7538
Conversation
… and preferences controllers and the deep-link listener Assisted-by: ClaudeCode:claude-opus-5-5
|
The red Newman API Test Suite check was not caused by this PR. It fails in the "PHPUnit unit suite (in-container, HARD GATE)" step. That step currently fails on every PR, including the JS-only #7510:
The 31 extra tests are exactly this PR's 31 new tests, and they all pass. The failing tests are Generated by Claude Code |
|
This PR only adds PHP test files, so these quality / … checks are red for reasons that have nothing to do with it:
The evidence is in #7519. Each check needs its own fix on Generated by Claude Code |
|
This adds to my earlier comment and covers three more checks this PR does not cause:
This PR changes only Generated by Claude Code |
|
This PR does not cause any red quality / Frontend Tests (unit) (jest) result. It adds only PHPUnit files under Generated by Claude Code |
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ✅ | ||||
| build | ✅ | ||||
| check-specs | ✅ | ||||
| test-l10n | ❌ | ||||
| test-l10n-parity | ❌ | ||||
| format | ❌ | ||||
| check-schema-l10n | ✅ | ||||
| test-coverage-ratchet | ✅ | ||||
| composer | ✅ | ✅ 168/168 | |||
| npm | ✅ | ✅ 641/641 | |||
| app:check-code | ⏭️ | ||||
| info.xml | ✅ | ||||
| REUSE | ✅ | ||||
| lockfile sync | ✅ | ||||
| PHPUnit | ❌ cancelled — no verdict | ||||
| Newman | ❌ 1625/1628 | ||||
| Playwright | ⏭️ deferred: E2E runs locally and on the promotion path only. This pull request targets development, so the suite is asked once per promotion into beta and main rather than once per push per open pull request. Run it locally with npx playwright test, or from the Actions tab on a branch with no open pull request into development. |
||||
| Hydra gates | ❌ |
Quality workflow — 2026-11-09 15:19 UTC
Download the full PDF report from the workflow artifacts.
SIG coverage round t1, lane T04: PHP unit tests for the generic AppHost controllers. The settings and preferences controllers enforce admin checks, which is why this carries the
[access]prefix.Covered
This PR adds new test files only and changes no production code. The new tests carry no coverage metadata, because
phpunit.xmlsetsbeStrictAboutCoverageMetadata=true.The tests check the admin refusals (
isAdmin === false), the CORS branch, and thesetPreferencerefusal of a bad key with 400. They also cover the index/update catch blocks and the deep-link guards for an empty schema slug, a missing manifest and invalid JSON.Left uncovered: in
GenericDeepLinkRegistrationListener::loadDeepLinks(), thereturn [];that runs whenfile_get_contentsreturnsfalseafteris_readablehas passed. A test cannot reach it without a production seam (an injectable reader).Ran
php -d pcov.enabled=1 -d pcov.directory=lib vendor/bin/phpunit -c phpunit.xml --coverage-clover /tmp/ctl.xml --filter '<the 7 new classes + existing GenericSettingsControllerBaseTest, GenericPreferencesControllerTest>' tests/Unit/AppHost: OK (48 tests, 121 assertions), 0 risky. This is a subset run, so the figures above are a lower bound.weak.phpover tests/Unit/AppHost reports none of the new files.Mutation samples (each reverted)
cors === true->!== true-> 2 tests failedanswer !== null->=== null-> 2 tests failedisAdmin === false->=== true-> 1 test failedisAdmin === false->=== true-> 1 test failedsafeKey === ''->=== 'zz'-> 1 test failedschemaSlug === ''guard -> 1 test failedThe tests were written with Claude Code.
Generated by Claude Code